From patchwork Tue Oct 3 17:00:10 2017 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Szabolcs Nagy X-Patchwork-Id: 23301 Received: (qmail 22515 invoked by alias); 3 Oct 2017 17:00:27 -0000 Mailing-List: contact libc-alpha-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Unsubscribe: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: libc-alpha-owner@sourceware.org Delivered-To: mailing list libc-alpha@sourceware.org Received: (qmail 22336 invoked by uid 89); 3 Oct 2017 17:00:25 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-24.8 required=5.0 tests=AWL, BAYES_00, GIT_PATCH_0, GIT_PATCH_1, GIT_PATCH_2, GIT_PATCH_3, RCVD_IN_DNSWL_NONE, SPF_HELO_PASS, SPF_PASS autolearn=ham version=3.3.2 spammy= X-HELO: EUR01-HE1-obe.outbound.protection.outlook.com Authentication-Results: spf=none (sender IP is ) smtp.mailfrom=Szabolcs.Nagy@arm.com; Message-ID: <59D3C21A.4010704@arm.com> Date: Tue, 03 Oct 2017 18:00:10 +0100 From: Szabolcs Nagy User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.8.0 MIME-Version: 1.0 To: GNU C Library CC: nd@arm.com Subject: [PATCH][BZ #22243] fix log2(0) and log(10) in downward rounding X-ClientProxiedBy: AM5PR04CA0015.eurprd04.prod.outlook.com (2603:10a6:206:1::28) To HE1PR0802MB2489.eurprd08.prod.outlook.com (2603:10a6:3:d8::23) X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 15b79af2-6dbd-4c31-e5c4-08d50a803a9c X-MS-Office365-Filtering-HT: Tenant X-Microsoft-Antispam: UriScan:; BCL:0; PCL:0; RULEID:(22001)(2017030254152)(48565401081)(2017052603199)(49563074)(201703131423075)(201703031133081)(201702281549075); SRVR:HE1PR0802MB2489; X-Microsoft-Exchange-Diagnostics: 1; HE1PR0802MB2489; 3:a2Hkc68Bc7j4Gs4OGLOpC9WAM+NOZrUW5Box/XiceBAaXKZDVeAk+FYNpltnM4HWS7xuo7gWjJQyO3IrQqXT45CPRaTG3xw+91SrxnG2VE7yV/gAb0dhoCsWMf0u4xqcCgMh8BP7A4RI7AvwTILaldq3cLxXmnCgO9d+ZySwzKaX4c1gy5WyYSdv5Q4qccUKpGh18X+ykoqAA7sZRf+3OnU7RuBz/nBf6rkEO5zoxCsyDJQ+l/ufqgJLO45RTT7b; 25:1Bo2dLDD7ZQjNx/t5yTU/Kqi0Q02Wy+WzJgWpc7WgjBdW8Qp8+yq0MdKJeMnFDn8sr57sBdGvpTUpZuu9zihf8/Tl5mAoZr1lOHakQIE+TUXMg9Y4Fvz984pmo24yVn62FPFe4NLJVY0xYLAwM57+rF5EKX50DWJ7cR/yUvC9ZPOYNzaXzszDgMHxGL472l8fqIw4UlcnoUe17FIifCclOHEUlEEP7zsyv3nCa1E7zghmehy1UwxpQOk9zBdC7scJO0Syz7XerU22zZXCwigYGg0EKQrX1bexlV7PF8+WfE79VtN451fhKp26g4EK0737RViETxyNiq8fYMjmeB4Bw==; 31:H9yHhmwURKSOhCPEvFUFXthwvQ8uLw6adKgx8zzGLdlIiXj+iavGz4maoxN+I4vNveStmxn+g91YDMzdWSqEWfX74DJqsbo06k3KvqQZ6PGQ/Xf4fXWs/ZfDaj0EoEXlOP+ANXj5OktyOaKR3r+jOzTR0ER8paViq/yH5cSNDYezmTXY9Xdkcvy39lsO16f6h1h37DmpasoL3iXDCSTDMHJ9R212tqHJ9L/wmsVkP7c= X-MS-TrafficTypeDiagnostic: HE1PR0802MB2489: NoDisclaimer: True X-Microsoft-Exchange-Diagnostics: 1; HE1PR0802MB2489; 20:dqkvXSjDytDJUqSrFqHFMwY5rcyvYd8OvFwzCEZF/UfqzQ4WfM9js4T6K5fDGVNdnMMyVHpZPGTZpb1U+EVZuuuDVoYj26choFkwXsnVBbZxqFWhYzSRBjjLJsxiYIxfIzGHEK46cRKnuBSjJ/rYvAU3h1c5WqFo5Ha16+9prEE=; 4:mWe7LAM2iUDqLPF3RKeXdCGSiQhZ5su2i44yTHRuPJ2O9KYg84t1OwsZaIXTIFx0CROy2iriXadNXchIi78+IIol4leiF8a8NDDeIKoGup3PKTnNC1XekEyzNEUN/QOrJbF5+WlfvdGB4YPTr9Cfkl0vorvAUQZGcl9HZloPPMrrFaNQ4FAYfXlvLA2lWZ9vRydxfPdRC1hWzhGOPAo2TfCtRJKZGYlzGuTffUGP6PgZ9xnsYhiXINRjizPMJdIDSWzKCQHR36p/HhZh0vt+6ejbCLC2eSLiXXpRMyMB/t0= X-Exchange-Antispam-Report-Test: UriScan:(180628864354917); X-Microsoft-Antispam-PRVS: X-Exchange-Antispam-Report-CFA-Test: BCL:0; PCL:0; RULEID:(100000700101)(100105000095)(100000701101)(100105300095)(100000702101)(100105100095)(102415395)(6040450)(2401047)(5005006)(8121501046)(100000703101)(100105400095)(93006095)(93001095)(10201501046)(3002001)(6055026)(6041248)(20161123558100)(20161123562025)(20161123564025)(20161123555025)(201703131423075)(201702281528075)(201703061421075)(201703061406153)(20161123560025)(6072148)(201708071742011)(100000704101)(100105200095)(100000705101)(100105500095); SRVR:HE1PR0802MB2489; BCL:0; PCL:0; RULEID:(100000800101)(100110000095)(100000801101)(100110300095)(100000802101)(100110100095)(100000803101)(100110400095)(100000804101)(100110200095)(100000805101)(100110500095); SRVR:HE1PR0802MB2489; X-Forefront-PRVS: 044968D9E1 X-Forefront-Antispam-Report: SFV:NSPM; SFS:(10009020)(6009001)(6049001)(376002)(346002)(39860400002)(199003)(189002)(377424004)(6916009)(66066001)(270700001)(5000100001)(106356001)(568964002)(87266999)(65816999)(33656002)(101416001)(97736004)(5660300001)(68736007)(6666003)(50986999)(65806001)(2476003)(36756003)(189998001)(65956001)(80316001)(77096006)(105586002)(64126003)(3846002)(4610100001)(4326008)(59896002)(2906002)(6486002)(83506001)(25786009)(86362001)(54356999)(81166006)(16526017)(478600001)(6116002)(16586007)(8936002)(21490400003)(8676002)(72206003)(58126008)(305945005)(7736002)(81156014)(16576012)(53936002)(84326002)(316002)(5890100001); DIR:OUT; SFP:1101; SCL:1; SRVR:HE1PR0802MB2489; H:[10.2.206.69]; FPR:; SPF:None; PTR:InfoNoRecords; A:1; MX:1; LANG:en; Received-SPF: None (protection.outlook.com: arm.com does not designate permitted sender hosts) X-Microsoft-Exchange-Diagnostics: =?us-ascii?Q?1; HE1PR0802MB2489; 23:W0AQE+f30fkHBxhkzA480u46Wa8hNhUEes1FHC7?= =?us-ascii?Q?SZa18HRdrGt5LIMkOBOP8b+RGpb24h9m3MpSEe5JYWImBoS9Nn7NLDte3xq0?= =?us-ascii?Q?4Np/nfO5g/+8hIlYb6Aiyl+bKwUjxlgoXZJKhkMe87bXgtUBunGMZJVWmsoR?= =?us-ascii?Q?CqWA77WyNY0CVn5khdT9aMcg11wVyL2ghgATzjgYr4c/QL7FPPwHsC7obR00?= =?us-ascii?Q?XOrtEMWf50T4ZNTBbiK1ohgJRiOqEE1vm0soG+AWQHforXu911v3BM2UUbrn?= =?us-ascii?Q?afchquTD0ZXfY/fc0Owb5F2lF8V2MLloV56s28u2oiwKvQmUsgaZDmw3fUch?= =?us-ascii?Q?jGPGAhq0JQEMqqw7AUIfxxGY+UhjF/dIaZu4ssJEnIhqDpwz7qVG1UPujg4c?= =?us-ascii?Q?Ow0BRm2qiKM1eXAoxdNbDNZoaoYl+ABSht6SldXxcqZ/f3rpkXAZZRMZSAtZ?= =?us-ascii?Q?aI3KlQX9RhwXNNTZBzbNF7XUs4TI+YGbQTHbyerQuvFXiP7vx0EdlvvsvL1F?= =?us-ascii?Q?b3zE1GxV1WRZOXwT9Nv3rHTPzZtAlpRIqVyVBOboUaVCgpPmzCXaK58AAABO?= =?us-ascii?Q?z8zkBNF/PSgct1BN3ZvjvnXcDf3PvJk6IX6PQK3vYpJ3UI4cnJbperP3X/61?= =?us-ascii?Q?AKpJRtymwWElE4+9e6hYijx9PtWjTTsbHL//ghT0Il53cvfZPvqQZXQ+jPCv?= =?us-ascii?Q?383gDjVvW8UVgpsyAwQlrX9a7JpVwmnCqC3JXN+HMFX8L2RyvTQiIwnIVcdD?= =?us-ascii?Q?uPiPmGs9/cw+UEIzeHvj3bYVf7ZsbJeD2SOECf/hvLjkiKfE9DsSVSChmwAR?= =?us-ascii?Q?icayool0eG6BMMKYVvAE0sVXi8T+DUWimLzRqX4H3ABb41oh7vERB/6X6AjT?= =?us-ascii?Q?VlbsjSZMoxlLi2jSQdMp+H0dwRI8jV8XWTSXJeZKwArLBOCLlRs0X8A1zExB?= =?us-ascii?Q?bdIQhc24080m3ajq74NwG1adoky0dS6Bnb5dEtbTeHQE+iTWzlxqtgZZNJ84?= =?us-ascii?Q?Q/df9iOf22enXbb5CfLpq0gc3lIdYAeAcGTvMxUOr6e7yWziBgQ4OShVlKKH?= =?us-ascii?Q?+rtBFcWxrGnxlkaDWJUTockIdP21MPbmFTVoH3gB1c86ueWZ81TEuXlxQmCy?= =?us-ascii?Q?IoagmnqVlLU5TTJkFrkrf8b00/jb4uhUy0/CrGAFJiEvzI1EUf987I8A+COL?= =?us-ascii?Q?WrSfq0n78VkC5UhNfTdWVLIPPgBAa77YG6AOo5M7ZMux6ZPELQnm0r8YEtjQ?= =?us-ascii?Q?204n5qZaRe9uvIcAolpzNqaERhMA6KuqsUBbFavH6eiv4iA1/DYDJrkBGgtv?= =?us-ascii?Q?yDRs+zcXVCHqXFi3Bo0F2nJksjvQQNR1HidpRCPDGhBIUXL9kwLG6VQlqx6q?= =?us-ascii?Q?J2wZLCyj4FpPhdQAS85EZnqppYd0mxNl6dw1u/qY09uvJ48Do?= X-Microsoft-Exchange-Diagnostics: 1; HE1PR0802MB2489; 6:N5Qc5eA44z86aCogClTmgg3ORebGyi1cWK6bCiMcKORHcUbQdWWhS2gacvwSoaKFVbJzUvzqtH0QjWpQyhUR3ewrYYYYyMbUEVFTEe4geeO1nB6yPI/X7mHBCqB7yJpQhR8f0ksoXe9cLA0POhNaV+k/w/2x3299sEskH2MRh/tYGoJsyUG+dM+yuZpIcoSLIyWnyEgxd03nVVMDAMozGX7YWcbH7pw7d0TrBdMi8bMTAWsFW+U0zdbY13bJKS/3ORwoN2vhjd4oIjLo/TWPX9WmR+Kv9o5A4BBWQgjnjQ1pPq39h3okIXICjmCf4dsn+VcgLzQUiO4X2UsYwgD2MA==; 5:eF5JpMKZdEKD9rmob99LvFUXlRIFgHoUE93u1XvJOyXoT9MvFR4Lg7hsP+RkcQ14Q8j5fsihE9sAKqrW8OMr6X0q2Lt6YizSvxYjwMTJNu4oV2rArkAGBHGLcI+zEDwXVsmqor3h8tzYD84fFpfbjjO+/7usxVKnxMYFDG3iRh4=; 24:SCw8rJq1ygYUbD2DUHc0w7KaRTJ6EkRx77tcmv0UjHqYwneNZGvRAN5GEBgcbNuEoCzpJuRTgJiL2KZcEOUQbo/GGzkES2zX6/jbfAQnXnY=; 7:WN/k2STnIlkmOqlzUXYVDudOprYEj+EhbjVFU7VRn9Mr9oqUSwXKkPHndqOSD+Hsm581GcQ4IgJZMNHRFNXwFKvro9aX8FyQk8MWMfhua8p68bCxYnl8TFbKV0k2DKr8fyEIvFm6dH7xrmX8pHWiAwYqFEQ6q5akbG6fminCe/8T7A2JScq/widloWGLGr/0oeAK/d6SujXW8pSAsEdxzPR8NemoFt5HFtcP4983Rpw= SpamDiagnosticOutput: 1:99 SpamDiagnosticMetadata: NSPM X-OriginatorOrg: arm.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 03 Oct 2017 17:00:19.4652 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: f34e5979-57d9-4aaa-ad4d-b122a662184d X-MS-Exchange-Transport-CrossTenantHeadersStamped: HE1PR0802MB2489 On 64bit targets if the SVID compat wrapper is suppressed (e.g. static linking) then log2(0) and log10(0) returned inf instead of -inf. 2017-10-03 Szabolcs Nagy [BZ #22243] * sysdeps/ieee754/dbl-64/wordsize-64/e_log10.c (__ieee754_log10): Use fabs. * sysdeps/ieee754/dbl-64/wordsize-64/e_log2.c (__ieee754_log2): Likewise. diff --git a/sysdeps/ieee754/dbl-64/wordsize-64/e_log10.c b/sysdeps/ieee754/dbl-64/wordsize-64/e_log10.c index 4f5a81669e..cd5567182f 100644 --- a/sysdeps/ieee754/dbl-64/wordsize-64/e_log10.c +++ b/sysdeps/ieee754/dbl-64/wordsize-64/e_log10.c @@ -65,7 +65,7 @@ __ieee754_log10 (double x) if (hx < INT64_C(0x0010000000000000)) { /* x < 2**-1022 */ if (__glibc_unlikely ((hx & UINT64_C(0x7fffffffffffffff)) == 0)) - return -two54 / (x - x); /* log(+-0)=-inf */ + return -two54 / fabs (x); /* log(+-0)=-inf */ if (__glibc_unlikely (hx < 0)) return (x - x) / (x - x); /* log(-#) = NaN */ k -= 54; diff --git a/sysdeps/ieee754/dbl-64/wordsize-64/e_log2.c b/sysdeps/ieee754/dbl-64/wordsize-64/e_log2.c index 5ccb78cf03..f08d5b337d 100644 --- a/sysdeps/ieee754/dbl-64/wordsize-64/e_log2.c +++ b/sysdeps/ieee754/dbl-64/wordsize-64/e_log2.c @@ -81,7 +81,7 @@ __ieee754_log2 (double x) if (hx < INT64_C(0x0010000000000000)) { /* x < 2**-1022 */ if (__glibc_unlikely ((hx & UINT64_C(0x7fffffffffffffff)) == 0)) - return -two54 / (x - x); /* log(+-0)=-inf */ + return -two54 / fabs (x); /* log(+-0)=-inf */ if (__glibc_unlikely (hx < 0)) return (x - x) / (x - x); /* log(-#) = NaN */ k -= 54;