From patchwork Fri Sep 29 11:10:36 2017 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Szabolcs Nagy X-Patchwork-Id: 23226 Received: (qmail 29379 invoked by alias); 29 Sep 2017 11:10:49 -0000 Mailing-List: contact libc-alpha-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Unsubscribe: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: libc-alpha-owner@sourceware.org Delivered-To: mailing list libc-alpha@sourceware.org Received: (qmail 28831 invoked by uid 89); 29 Sep 2017 11:10:48 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-24.7 required=5.0 tests=AWL, BAYES_00, GIT_PATCH_0, GIT_PATCH_1, GIT_PATCH_2, GIT_PATCH_3, RCVD_IN_DNSWL_NONE, SPF_HELO_PASS, SPF_PASS autolearn=ham version=3.3.2 spammy=HX-HELO:sk:EUR02-V, Hx-spam-relays-external:sk:EUR02-V, H*RU:sk:EUR02-V, H*r:sk:EUR02-V X-HELO: EUR02-VE1-obe.outbound.protection.outlook.com Authentication-Results: spf=none (sender IP is ) smtp.mailfrom=Szabolcs.Nagy@arm.com; Message-ID: <59CE2A2C.7000007@arm.com> Date: Fri, 29 Sep 2017 12:10:36 +0100 From: Szabolcs Nagy User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.8.0 MIME-Version: 1.0 To: GNU C Library CC: nd@arm.com Subject: [PATCH 5/5 v2] Do not wrap logf, log2f and powf References: <59CE27D3.4050205@arm.com> In-Reply-To: <59CE27D3.4050205@arm.com> X-ClientProxiedBy: VI1PR0602CA0014.eurprd06.prod.outlook.com (2603:10a6:800:bc::24) To VI1PR0802MB2495.eurprd08.prod.outlook.com (2603:10a6:800:b6::23) X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 33644358-c4f9-4639-0303-08d5072ab9de X-MS-Office365-Filtering-HT: Tenant X-Microsoft-Antispam: UriScan:; BCL:0; PCL:0; RULEID:(22001)(2017030254152)(48565401081)(2017052603199)(49563074)(201703131423075)(201703031133081)(201702281549075); SRVR:VI1PR0802MB2495; X-Microsoft-Exchange-Diagnostics: 1; VI1PR0802MB2495; 3:mvzjPejXOceYpChh915vWLOMB0s3JwW3VYwhxYZA13Fo3I7MuR4sqSJosEURO5QDsOhLpQqDkGbp8/I0KRqhAVGf6oEUqZi/l4YhVxarhAKjRrJxv6GCwy6yVVBCvRi7BlrZQKBa78fvmM1XhkzXNG1PQRmmoJyANGbyHpzV3R5DZp4B4CnkcupLAqn4Q1ynJ4B+IXR/usq6sdHQl8mWwDEFpXXAlflli8r2ln3TrZvlBtE8a4MaukqmnXUiVOSl; 25:FXSAN6v86OCsBHFJk5+SA0Jj6pvhvc+BmdNt7MCbMK1Fw0Z24rFHtkOPuwObnlwIlGs/ZzrE4wCDwg65SlLEyqIdozvXqd7H8DX88bxErjiUYX+LDBwLyH1LCu7wyzcodlAQVQNhuMXqc213sloKJfzYAlT+bn+kJWPIuM9gpj8G4sbx8/gDBV2KpImBZhFadCf2iD8Jh4Hcgsjhr0D50KUawTyMNnkFHGcjn48ywVI4D4WOofrlYHAoxp8OJ8PHlSA2SvNiF0j3th/pyttgJEuLJ5E4iCyTULM2PFhdKJMRl4w13TKudZAW1tN5u2AGD2ZyRCH3CbQa8OTJPgJhaA==; 31:oJTYcrzgURFvjvfBUB0Pi9csK7dbjHvl4fynnd3nAR4WFF2XJ4jUJyXyzcekzXJpTNIVXWp4Af2iMRkcEu+p1YfZyGv6qUL8YhVoyijf7uIIhtiD8CJgYWE3LW+ElXChFmL1k+6PsoXrxZ1vgvtD4HFWODBmxxRLHTpQj66J90y0Mfqjw2tuhz9dmpMfZwLH+Jv2M/gPYLzlM8BDix5Z9B7dI7m6l5w4fDCY05FVaWc= X-MS-TrafficTypeDiagnostic: VI1PR0802MB2495: NoDisclaimer: True X-Microsoft-Exchange-Diagnostics: 1; VI1PR0802MB2495; 20:/cB5tk3VSN60ytlQOYgICnA0iTBG0GcTi9OzU7zfIMVtUGujYAwBG3SOJ41qtki/PlDRfS1l/V5vZWKfpa7045bJp+a820OhP0iBX+O72lGnPI2stu9ZVsShBypM/P/f+gGdt2anXENOphp2kGSWscgZaz7xuGVMgOkLFC0AEL4=; 4:8t+DzIJiwglFA2anOAwAdByuxFxIhl7dtDFiz0pSGMGZkJoxP4sGRLy0aMvK30fqBCUjzW0SfQmMY737C+j3ZYTe0lNw14tTdaZJI/lp4gLyDuq63TveyIc6ogcaBsN39ArJo6nKv60YMc2MmJ07XkB2XuuAEsABkbAZoX3dflpvo/0udgXKMu6gUoR5FqwPS3y0XrxLJ4pkbU8DwzqTzGauLZmC+b0gAM7WBlzzkDCt3MqqOdNPlkasuOjrmGq0 X-Exchange-Antispam-Report-Test: UriScan:; X-Microsoft-Antispam-PRVS: X-Exchange-Antispam-Report-CFA-Test: BCL:0; PCL:0; RULEID:(100000700101)(100105000095)(100000701101)(100105300095)(100000702101)(100105100095)(102415395)(6040450)(2401047)(5005006)(8121501046)(3002001)(10201501046)(93006095)(93001095)(100000703101)(100105400095)(6055026)(6041248)(201703131423075)(201702281528075)(201703061421075)(201703061406153)(20161123564025)(20161123560025)(20161123562025)(20161123558100)(20161123555025)(6072148)(201708071742011)(100000704101)(100105200095)(100000705101)(100105500095); SRVR:VI1PR0802MB2495; BCL:0; PCL:0; RULEID:(100000800101)(100110000095)(100000801101)(100110300095)(100000802101)(100110100095)(100000803101)(100110400095)(100000804101)(100110200095)(100000805101)(100110500095); SRVR:VI1PR0802MB2495; X-Forefront-PRVS: 0445A82F82 X-Forefront-Antispam-Report: SFV:NSPM; SFS:(10009020)(6049001)(6009001)(346002)(376002)(189002)(199003)(65956001)(81156014)(2476003)(5000100001)(65806001)(64126003)(6116002)(5660300001)(7736002)(305945005)(66066001)(6486002)(6666003)(3846002)(16576012)(83506001)(86362001)(97736004)(316002)(50986999)(84326002)(72206003)(76176999)(58126008)(16586007)(87266999)(65816999)(54356999)(4610100001)(68736007)(80316001)(5890100001)(16526017)(8936002)(478600001)(101416001)(106356001)(568964002)(81166006)(105586002)(564344004)(6916009)(8676002)(2950100002)(2906002)(53936002)(36756003)(77096006)(25786009)(189998001)(4326008)(270700001)(33656002)(59896002); DIR:OUT; SFP:1101; SCL:1; SRVR:VI1PR0802MB2495; H:[10.2.206.69]; FPR:; SPF:None; PTR:InfoNoRecords; MX:1; A:1; LANG:en; Received-SPF: None (protection.outlook.com: arm.com does not designate permitted sender hosts) X-Microsoft-Exchange-Diagnostics: =?us-ascii?Q?1; VI1PR0802MB2495; 23:N4grHXMLKsXMpc7aM8tHnnVUIk6NHzlCjmi6OSe?= =?us-ascii?Q?5teFBdNXWwXFbaQ6sSIJlJXHuRwVycI7dG7f7faVH9pDU2mLgJ5OizjOoeKS?= =?us-ascii?Q?AZAjATfvNA/mkADNXEfizvcosf9c/T+M2KA4AGUB6OZ8evKGrfAp7xTAcwhg?= =?us-ascii?Q?QD+82NIyN5A3e2/P6h2GBEUztUCb0yYh2RSuppkXuZLc3WucbFwFEtcU2k2G?= =?us-ascii?Q?YnvUbgwFdG/d693hw/WOaSaR+FK0iogsI6kjluLS7gTajdhbO0uVCDGnMpEL?= =?us-ascii?Q?qTHY0R9UK1dxwOcr13REBCy3e1EtTxAMD2xXgRpkflQqbGgaqEhFJfai5BkU?= =?us-ascii?Q?9p6xu+RZqaXvjZ3Ih0C4xNRvXVVihCM0QwSn5si1JbFaa6N50ef9yvlzC8To?= =?us-ascii?Q?8an9apSeNSa9L7w5KylNr7P+6Jt9DeLiZX3XrV5512lmzp8ESkjzci4F42rX?= =?us-ascii?Q?waTWoQdn6goHhGclIzH0oSRYrkDc0/xAK3xp9b6i6t2zeRoi/B/MVvZnmPhG?= =?us-ascii?Q?2mr6iQo4PURrYYSNCyfR85BEkc4WSysT6+elH/5EwfdCPO5n51LoIy9mmfBq?= =?us-ascii?Q?RlGUn/S3g2KidNzuPXwPOyLWF2XKqIvXoEG5UDo8RxLY9TjeTylTj/g55awt?= =?us-ascii?Q?CeNqYIqxfKa9lD1lwCYCnmdH0mFc5KVTcWflSjTYHy1hV4BTx9fcaKpSM3z2?= =?us-ascii?Q?Q14aYT7KDbkhvfp4woThdxAwQlJvJtHIlWwXb/9P8pJ/zUVRX1PICpAEdP/Z?= =?us-ascii?Q?fuPMRJmGE6d+i0NjbmiCoJvlPQVe02zx72oLAkIs4IuxHL4q1HVNx8SQbicZ?= =?us-ascii?Q?OvYEWezV9LDaqkUDhQRg0gOOwdym3BCFsDNPowGdAYD81Wl9T32cVFwF688t?= =?us-ascii?Q?ITAP7MT53cGOetWa33O9gSuAg0nfq/xkJybJBWr2L56GL6fqlpTB3UYOP78l?= =?us-ascii?Q?RYQyM8saTuiFQWtSeq8n6lKT9J5f3Y9z6HVKIu8Y9JwcWRqJRtHcecBSIxxl?= =?us-ascii?Q?SCBEAiLtZrk3aV1GmGNifXbGDuP+yYpXWNdBuucH/5zvoJJcMCXeM59YdGfd?= =?us-ascii?Q?YxE1obV0cGaePTDhLeuuZAwsp7Do93Get/aBk78kMgNezpan6PJ2HKFejQWZ?= =?us-ascii?Q?vkQjGD7ryQbFbN1u/UstZceWDHYWJzwBKSxlLpc1Hx8ykWtU3ejG5LSi0Vp1?= =?us-ascii?Q?uctpsAEw2rLsYvm7Me5J6e+mKqNKvaXmibq5t8LMcjvqhYQuWW6A8ENl7tRD?= =?us-ascii?Q?x2mLGQBMd/ezHO5JyAkitLmopbnrRZ/ydt6tg+G8DjOr7mn5xHGKQLKIHxF7?= =?us-ascii?Q?KCWIIt+oPLk/h1hdAkynuX+Ukf6w7uRIZetBXLVx5jHW6Ipg9o1sSety+sSm?= =?us-ascii?Q?VLVeG9YoDYEFHmDBe+LFBi+GVc8MvxYR3XSh+DOVvfKb4wIaP?= X-Microsoft-Exchange-Diagnostics: 1; VI1PR0802MB2495; 6:lr5PN4QOUcwvgHJVUXjJo6aQ9Kuzslbs0e6ELtDbkk+ITBS3KyDReJRE7K60RvEA8t0D733yt1+JkDiSYO9rchbh8fkeHUFvedmyo+2ZQU8dCJMkaiAG6JI8/00aeHzj0WYXacVBUwkyW2numVz4OwFQLLibKSin61k7kqz5gRDw9/8rnsyZpltTvLKLtGc87SBBAP9XWLkKdfZKjTkSgODppXNqCeHwY5wSjv/f8CC2o9RVustJWcW3phrI9C6sVxXGD3IyPGzigwndxQUZiE3cOaecO+/aGb0CrHl9aIqX4lTptOpg2nxREeAnjI78Hji7q2R7oR84cMMN+/UoUA==; 5:O2+W8xuwJoe+MKH4hXRxqFBGUUNyLQ9be4Ey2VwQH4ewAxpC4x0mFzcTWFmxBjOIB1wTmaLv1zoXc+t/BvvpL7vH93AGU3gK/iV3SXr5ykVGYPGWAiE/s5NozzExZ//WCI42zTDy/SQTQIezpD9NtvAIKACCAmoMb4HKLzoScQQ=; 24:a03cp7HWtW9mMSAJL3dErl9HdCzXN97tXs0hpAvEM5fpZPgxmHBmSjvcx0jTfKB1KRLCkVya6z7pWcXa90KM5h/GD7SOdGUz7bILPUo/jd8=; 7:WOsXeu5LrWfRVDT+mBQJN9GnXPI3/klls7gBIYDosVdrTAwnVnNfPoZD+o4JYJGSWo/fR2bvvpU1ZAqGpCfnfncr1aAs6Y5ZMZqgwv+LX0n8LpvoypwOvqkAeudIdwH0i2YZcAXYmjSd67VuBJoel07Xh27bJk0Uh8J9DsKTRKCe7pL4JgYPCyosul2Ilnn/I/kFTX+TZnkiQKyEbq+Z76J2V5tYYGQXCD+Hry1hYR4= SpamDiagnosticOutput: 1:99 SpamDiagnosticMetadata: NSPM X-OriginatorOrg: arm.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 29 Sep 2017 11:10:42.9430 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: f34e5979-57d9-4aaa-ad4d-b122a662184d X-MS-Exchange-Transport-CrossTenantHeadersStamped: VI1PR0802MB2495 v2: - ifndefs for multiarch support. From dc230e23df20ac3ab13e2cc2e858083c0550bb31 Mon Sep 17 00:00:00 2001 From: Szabolcs Nagy Date: Wed, 13 Sep 2017 18:14:26 +0100 Subject: [PATCH 5/5] Do not wrap logf, log2f and powf The new generic logf, log2f and powf code don't need wrappers any more, they set errno inline so only use the wrappers on targets that need it. 2017-09-19 Szabolcs Nagy * sysdeps/ieee754/flt-32/e_log2f.c (__log2f): Define without wrapper. * sysdeps/ieee754/flt-32/e_logf.c (__logf): Likewise * sysdeps/ieee754/flt-32/e_powf.c (__powf): Likewise * sysdeps/ieee754/flt-32/w_log2f.c: New file. * sysdeps/ieee754/flt-32/w_logf.c: New file. * sysdeps/ieee754/flt-32/w_powf.c: New file. * sysdeps/i386/fpu/w_log2f.c: New file. * sysdeps/i386/fpu/w_logf.c: New file. * sysdeps/i386/fpu/w_powf.c: New file. * sysdeps/m68k/m680x0/fpu/w_log2f.c: New file. * sysdeps/m68k/m680x0/fpu/w_logf.c: New file. * sysdeps/m68k/m680x0/fpu/w_powf.c: New file. --- sysdeps/i386/fpu/w_log2f.c | 1 + sysdeps/i386/fpu/w_logf.c | 1 + sysdeps/i386/fpu/w_powf.c | 1 + sysdeps/ieee754/flt-32/e_log2f.c | 9 +++++++-- sysdeps/ieee754/flt-32/e_logf.c | 9 +++++++-- sysdeps/ieee754/flt-32/e_powf.c | 9 +++++++-- sysdeps/ieee754/flt-32/w_log2f.c | 1 + sysdeps/ieee754/flt-32/w_logf.c | 1 + sysdeps/ieee754/flt-32/w_powf.c | 1 + sysdeps/m68k/m680x0/fpu/w_log2f.c | 1 + sysdeps/m68k/m680x0/fpu/w_logf.c | 1 + sysdeps/m68k/m680x0/fpu/w_powf.c | 1 + 12 files changed, 30 insertions(+), 6 deletions(-) create mode 100644 sysdeps/i386/fpu/w_log2f.c create mode 100644 sysdeps/i386/fpu/w_logf.c create mode 100644 sysdeps/i386/fpu/w_powf.c create mode 100644 sysdeps/ieee754/flt-32/w_log2f.c create mode 100644 sysdeps/ieee754/flt-32/w_logf.c create mode 100644 sysdeps/ieee754/flt-32/w_powf.c create mode 100644 sysdeps/m68k/m680x0/fpu/w_log2f.c create mode 100644 sysdeps/m68k/m680x0/fpu/w_logf.c create mode 100644 sysdeps/m68k/m680x0/fpu/w_powf.c diff --git a/sysdeps/i386/fpu/w_log2f.c b/sysdeps/i386/fpu/w_log2f.c new file mode 100644 index 0000000000..3f5c71cec2 --- /dev/null +++ b/sysdeps/i386/fpu/w_log2f.c @@ -0,0 +1 @@ +#include diff --git a/sysdeps/i386/fpu/w_logf.c b/sysdeps/i386/fpu/w_logf.c new file mode 100644 index 0000000000..ea48d1356e --- /dev/null +++ b/sysdeps/i386/fpu/w_logf.c @@ -0,0 +1 @@ +#include diff --git a/sysdeps/i386/fpu/w_powf.c b/sysdeps/i386/fpu/w_powf.c new file mode 100644 index 0000000000..d133216f5b --- /dev/null +++ b/sysdeps/i386/fpu/w_powf.c @@ -0,0 +1 @@ +#include diff --git a/sysdeps/ieee754/flt-32/e_log2f.c b/sysdeps/ieee754/flt-32/e_log2f.c index 6c42f27843..ef13b372cb 100644 --- a/sysdeps/ieee754/flt-32/e_log2f.c +++ b/sysdeps/ieee754/flt-32/e_log2f.c @@ -18,6 +18,7 @@ #include #include +#include #include "math_config.h" /* @@ -34,7 +35,7 @@ Relative error: 1.9 * 2^-26 (before rounding.) #define OFF 0x3f330000 float -__ieee754_log2f (float x) +__log2f (float x) { /* double_t for better performance on targets with FLT_EVAL_METHOD==2. */ double_t z, r, r2, p, y, y0, invc, logc; @@ -85,4 +86,8 @@ __ieee754_log2f (float x) y = y * r2 + p; return (float) y; } -strong_alias (__ieee754_log2f, __log2f_finite) +#ifndef __log2f +strong_alias (__log2f, __ieee754_log2f) +strong_alias (__log2f, __log2f_finite) +versioned_symbol (libm, __log2f, log2f, GLIBC_2_27); +#endif diff --git a/sysdeps/ieee754/flt-32/e_logf.c b/sysdeps/ieee754/flt-32/e_logf.c index b8d262441f..ea847b57ec 100644 --- a/sysdeps/ieee754/flt-32/e_logf.c +++ b/sysdeps/ieee754/flt-32/e_logf.c @@ -18,6 +18,7 @@ #include #include +#include #include "math_config.h" /* @@ -35,7 +36,7 @@ Relative error: 1.957 * 2^-26 (before rounding.) #define OFF 0x3f330000 float -__ieee754_logf (float x) +__logf (float x) { /* double_t for better performance on targets with FLT_EVAL_METHOD==2. */ double_t z, r, r2, y, y0, invc, logc; @@ -84,4 +85,8 @@ __ieee754_logf (float x) y = y * r2 + (y0 + r); return (float) y; } -strong_alias (__ieee754_logf, __logf_finite) +#ifndef __logf +strong_alias (__logf, __ieee754_logf) +strong_alias (__logf, __logf_finite) +versioned_symbol (libm, __logf, logf, GLIBC_2_27); +#endif diff --git a/sysdeps/ieee754/flt-32/e_powf.c b/sysdeps/ieee754/flt-32/e_powf.c index 644a18d05e..08d2c6d058 100644 --- a/sysdeps/ieee754/flt-32/e_powf.c +++ b/sysdeps/ieee754/flt-32/e_powf.c @@ -18,6 +18,7 @@ #include #include +#include #include "math_config.h" /* @@ -139,7 +140,7 @@ zeroinfnan (uint32_t ix) } float -__ieee754_powf (float x, float y) +__powf (float x, float y) { unsigned long sign_bias = 0; uint32_t ix, iy; @@ -214,4 +215,8 @@ __ieee754_powf (float x, float y) } return (float) exp2_inline (ylogx, sign_bias); } -strong_alias (__ieee754_powf, __powf_finite) +#ifndef __powf +strong_alias (__powf, __ieee754_powf) +strong_alias (__powf, __powf_finite) +versioned_symbol (libm, __powf, powf, GLIBC_2_27); +#endif diff --git a/sysdeps/ieee754/flt-32/w_log2f.c b/sysdeps/ieee754/flt-32/w_log2f.c new file mode 100644 index 0000000000..1cc8931700 --- /dev/null +++ b/sysdeps/ieee754/flt-32/w_log2f.c @@ -0,0 +1 @@ +/* Not needed. */ diff --git a/sysdeps/ieee754/flt-32/w_logf.c b/sysdeps/ieee754/flt-32/w_logf.c new file mode 100644 index 0000000000..1cc8931700 --- /dev/null +++ b/sysdeps/ieee754/flt-32/w_logf.c @@ -0,0 +1 @@ +/* Not needed. */ diff --git a/sysdeps/ieee754/flt-32/w_powf.c b/sysdeps/ieee754/flt-32/w_powf.c new file mode 100644 index 0000000000..1cc8931700 --- /dev/null +++ b/sysdeps/ieee754/flt-32/w_powf.c @@ -0,0 +1 @@ +/* Not needed. */ diff --git a/sysdeps/m68k/m680x0/fpu/w_log2f.c b/sysdeps/m68k/m680x0/fpu/w_log2f.c new file mode 100644 index 0000000000..3f5c71cec2 --- /dev/null +++ b/sysdeps/m68k/m680x0/fpu/w_log2f.c @@ -0,0 +1 @@ +#include diff --git a/sysdeps/m68k/m680x0/fpu/w_logf.c b/sysdeps/m68k/m680x0/fpu/w_logf.c new file mode 100644 index 0000000000..ea48d1356e --- /dev/null +++ b/sysdeps/m68k/m680x0/fpu/w_logf.c @@ -0,0 +1 @@ +#include diff --git a/sysdeps/m68k/m680x0/fpu/w_powf.c b/sysdeps/m68k/m680x0/fpu/w_powf.c new file mode 100644 index 0000000000..d133216f5b --- /dev/null +++ b/sysdeps/m68k/m680x0/fpu/w_powf.c @@ -0,0 +1 @@ +#include -- 2.11.0