From patchwork Wed Sep 13 10:48:47 2017 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Szabolcs Nagy X-Patchwork-Id: 22865 Received: (qmail 55117 invoked by alias); 13 Sep 2017 10:48:55 -0000 Mailing-List: contact libc-alpha-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Unsubscribe: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: libc-alpha-owner@sourceware.org Delivered-To: mailing list libc-alpha@sourceware.org Received: (qmail 54819 invoked by uid 89); 13 Sep 2017 10:48:54 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-24.6 required=5.0 tests=AWL, BAYES_00, GIT_PATCH_0, GIT_PATCH_1, GIT_PATCH_2, GIT_PATCH_3, RCVD_IN_DNSWL_NONE, SPF_HELO_PASS, SPF_PASS autolearn=ham version=3.3.2 spammy=HX-ClientProxiedBy:sk:DB6PR02 X-HELO: EUR01-DB5-obe.outbound.protection.outlook.com Authentication-Results: spf=none (sender IP is ) smtp.mailfrom=Szabolcs.Nagy@arm.com; Message-ID: <59B90D0F.1000207@arm.com> Date: Wed, 13 Sep 2017 11:48:47 +0100 From: Szabolcs Nagy User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.8.0 MIME-Version: 1.0 To: GNU C Library CC: nd@arm.com Subject: [PATCH 4/4] Do not wrap expf and exp2f References: <59B90BDF.7000503@arm.com> In-Reply-To: <59B90BDF.7000503@arm.com> X-ClientProxiedBy: DB6PR0201CA0015.eurprd02.prod.outlook.com (2603:10a6:4:3f::25) To DB6PR0802MB2485.eurprd08.prod.outlook.com (2603:10a6:4:9b::23) X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 8a570e6f-57cd-4e71-d786-08d4fa950484 X-MS-Office365-Filtering-HT: Tenant X-Microsoft-Antispam: UriScan:; BCL:0; PCL:0; RULEID:(300000500095)(300135000095)(300000501095)(300135300095)(300000502095)(300135100095)(22001)(2017030254152)(48565401081)(300000503095)(300135400095)(49563074)(201703131423075)(201703031133081)(201702281549075)(300000504095)(300135200095)(300000505095)(300135600095)(300000506095)(300135500095); SRVR:DB6PR0802MB2485; X-Microsoft-Exchange-Diagnostics: 1; DB6PR0802MB2485; 3:wLOq2hW3I43bFMhwCqlx//uMEwXdkRQPzT6nlKiDDeQ1B23Ji3ihiEfX5TSrnGyWoTkHwIFak+BWWYtGM9NlxzVJpSmk3zyqbX+/P9yZs7DRSwhba6zf8D+jy9PbJuqNfcxb+nV/0go/wLyBbeIj+9chOSXjrsRRic3GkldJkpkzuv7TgICHYmMbNfrpkZ5TDV57iHxiUPSr+zLj8+enkJmOhm7+q7PrIymQMAfA/FkJFtiG/xgafKuILHHEZlGN; 25:z+vk4qduQhKyTuPfSO1rodSio7OY9LOCX62h5REWqcl1fJMVrer7SbzItXtfq/h0nwC5XReud6tZsWUL0d55vv5PBLy2tj1pfsuCQjguRZKgk6YbfXGtUPUTQ7OthXYfJ6ZurV91GaSyEJBtx+8JQREAz8bIEWL5UkYnZiO8A49iz20xO2eQn0b8txnDeLqFUArY/Liu74L+9/UOpXTWdZqrV4RY1crT7JK7B2scaoV2vHSmMZVKejoA9OHLgOny8Gm59edVeepTbp0ZkgUUa4cZFEmjlkneBPo4KUkFp9vP8v1emrYkUW3qb9Jc1TfHSkgmrnArp2lLmwPMIgJzmw==; 31:a3/3sUbK50DV8M8tqAGYCFd6z3bDKMoa6XhW/AjdGI2Al9QyqYkpU/v9V4AJBe5IVNLlcZoZEd9Y8UGcuwEhxSds6tCctxUjc0HTRc8uB5cSnwTEXxpwRYZxToBdEiQwoSi1BcIFtB8Fn7Vw02TMejngFi6ifKWUAnn3FfwpMxz6AxW6NR6rSLl3mZpj9zUZL4ps6N7wWops013T7evJczWmfUIGOfmeJG6blPYPFeQ= X-MS-TrafficTypeDiagnostic: DB6PR0802MB2485: NoDisclaimer: True X-Microsoft-Exchange-Diagnostics: 1; DB6PR0802MB2485; 20:MkcwngLFXb/19ad7F6GLSeKqk+YTLYBGrKndnAZaYETalQ9KRAq29kP+B1VkpKwt+iyaq9dXZnuoNewKO8fVs/grzWRoVy3x8MR8EFIq+OuS/OsSLjtY5VZN4t7ep/zxgRflUKzvJ2ZB5HD2JvCX6PHAcQLdy7nqXj9Mg43HWsI=; 4:0PTccCbIGKM+lUSpeaFNy3NxbmwM81FF7WY6o2WJoVckbgJ+gf8+KDdWzedwknP94KQOo2WXSZjXd2YasG6QMf6297RjGpZNKDiCwcDOON/I2akyOHMmBCmaa25QIl8LUMcf3JHjy1VeHQhTbsRMh6fIrpQm0lWjn960AM9gIkwWr9h9iGCX8jismbqvH5C6DLJ3FJ7oo8+AnFh/kiVdhDfM1h9j0WpxX+rQSyb+5TGTAloFzhRIGp0WiMn7sgkgN5e5D1vt/Rax362L05zmefd7DyfY87i9sUIPAZmqemo= X-Exchange-Antispam-Report-Test: UriScan:(180628864354917); X-Microsoft-Antispam-PRVS: X-Exchange-Antispam-Report-CFA-Test: BCL:0; PCL:0; RULEID:(100000700101)(100105000095)(100000701101)(100105300095)(100000702101)(100105100095)(102415395)(6040450)(2401047)(8121501046)(5005006)(93006095)(93001095)(100000703101)(100105400095)(10201501046)(3002001)(6055026)(6041248)(20161123558100)(201703131423075)(201702281528075)(201703061421075)(201703061406153)(20161123560025)(20161123564025)(20161123555025)(20161123562025)(6072148)(201708071742011)(100000704101)(100105200095)(100000705101)(100105500095); SRVR:DB6PR0802MB2485; BCL:0; PCL:0; RULEID:(100000800101)(100110000095)(100000801101)(100110300095)(100000802101)(100110100095)(100000803101)(100110400095)(100000804101)(100110200095)(100000805101)(100110500095); SRVR:DB6PR0802MB2485; X-Forefront-PRVS: 042957ACD7 X-Forefront-Antispam-Report: SFV:NSPM; SFS:(10009020)(4630300001)(7370300001)(6009001)(6049001)(346002)(366002)(376002)(39860400002)(189002)(377424004)(199003)(87266999)(68736007)(54356999)(33656002)(80316001)(189998001)(65816999)(77096006)(76176999)(270700001)(50986999)(105586002)(64126003)(6486002)(568964002)(7350300001)(5660300001)(86362001)(4610100001)(59896002)(53936002)(97736004)(4001350100001)(4326008)(316002)(2906002)(65806001)(72206003)(478600001)(65956001)(66066001)(110136004)(8676002)(101416001)(36756003)(6916009)(106356001)(81156014)(16576012)(81166006)(84326002)(7736002)(25786009)(83506001)(3846002)(2476003)(16526017)(305945005)(5890100001)(6116002)(2950100002); DIR:OUT; SFP:1101; SCL:1; SRVR:DB6PR0802MB2485; H:[10.2.206.69]; FPR:; SPF:None; PTR:InfoNoRecords; MX:1; A:1; LANG:en; Received-SPF: None (protection.outlook.com: arm.com does not designate permitted sender hosts) X-Microsoft-Exchange-Diagnostics: =?us-ascii?Q?1; DB6PR0802MB2485; 23:fc/75JhGJFA971TkEoO45WEpHzT4iBd4uPU3U8T?= =?us-ascii?Q?KZzQSkE9i5QHNJeJMPU9quDyHjiTVW5pEJf+iMVh4ccr+rYiS34juquiaSRI?= =?us-ascii?Q?k/plY9U+D8yemKdaxYTKToUdQjO0ccmKp43emlsxiUtxJ0pBA3MDURQZpkUr?= =?us-ascii?Q?zVsJvfvGbr9bP2bffOUclkJz8N9Tukx01gMrLuQ6uFi5hDCRO7nNdUbIwcXf?= =?us-ascii?Q?5yNa2chTYepgi3WsuRtxdLH7VfODIbgCY8tlCN1sMHQ5s2Znv86t6LuBgGn2?= =?us-ascii?Q?jT++tyDDkj9Ijs5r64utgqRKkHZeAjxrywTnXyF2+OFp74SyrMpMskAo2PX7?= =?us-ascii?Q?H+wT68jco2g/rNFXmKX7XJokvmqE4FMmh9JDtdn2DIX/oEC4rZuFaCRUxDSA?= =?us-ascii?Q?mI6UEm0wrrMiFLuYK/2PPuW0q3slKTwFa2o0c22itroheRr30tEnFI+OdFB5?= =?us-ascii?Q?/uk8zzufAh4PHAvjPZ9/GCXgUFiPYz6km2yLd+HdGii/nyPMx2WYdX/Elxnt?= =?us-ascii?Q?RqDK3DDxUg9tdB5KkvYfNXbGiBvQJahlYyVhR8V43bswSBbsmMfiXZ2cCrE5?= =?us-ascii?Q?hR8iSFxuAJQ34lAyIpnzR7hhuTF3R2EDdCQGL7cIKktoGd3UzieS8ccwYUhg?= =?us-ascii?Q?s+ViU61VDDgz6d+iFnioE5bSVd6RfmqXalFOnn6wmfqPWTApXaK7YUnH5RWt?= =?us-ascii?Q?KAJvHRBy8mpRjOBf61atKvLsrMWSKcNRXLrv7lzbaUJgWAGLkeFDbPAzRpGX?= =?us-ascii?Q?N3JjKBhFXkMe5VHxI/8rDMs1FtcqCv+qQtrLAoR7+D75UAKWG2BhT+e28Ibe?= =?us-ascii?Q?mF6QXmbk4F8uzlZyl9fBUgHpZitsklrBO2yaTVznPOzYQacScHSDZaWGrsyw?= =?us-ascii?Q?u24DBHYrTyN/pwjUeWwV+lpRcRFgzIfjpVGXNqJnodSXgm6CSyzhu0vAUot0?= =?us-ascii?Q?AhzfDStmALzvA7X+QTxgcjN7GbDBbydYSIkQZLCenb8aVRKDaubKjv/CeeR3?= =?us-ascii?Q?v9a6tinASQho/i+Du56HppHrM+pvGar8DdbojA34V3uFzIOXFJwRyrgJpgiV?= =?us-ascii?Q?FX4hIXQIlxWXuaxuQ7KGgc4x6TmRBo1y3J9E/KB0PZzdr0Ub7Z5NTRCd8g4Y?= =?us-ascii?Q?X0/A+MV2OdpIm+qLbg0OSSMn2db9I2PdbF2Oy/z8wxZoqqC03PxGDx2cFhCI?= =?us-ascii?Q?WubOB+X7G1ZWaZjYRgVTeBSh8Ykx5GjJcQEoWdhsYIHPhTUX2/Y9rGXBVU9h?= =?us-ascii?Q?LqJpbwhlQ1SgeqPlATSZBnWkAVGvKD8FRHm3gfW1nLmPZD4W4A7yhSyRtY1z?= =?us-ascii?Q?cIb5tbX9L1fDRqNlfE5zCmaxCsxVN0VXC4i+wW3JLQW2vgDPxqeIrOmNit52?= =?us-ascii?Q?nyDxiTMajmV3rutfOjDEvMt6OBhD4mf0WGqEpyplrzKjfpzzgzTvn3Yx2mgA?= =?us-ascii?Q?Y7zjFaedA+XcMv1uEVSCCQumz6A8FaTlfEjojId8zRjyKkRvpddnI?= X-Microsoft-Exchange-Diagnostics: 1; DB6PR0802MB2485; 6:jYYmVViZhDfOH7SZJSoiMc5Mee2355Q2YUZkIujo8Z5iY4wSooEWkKV56jiIrDaBXOg3Jd50X34YqiJ3qplLpCSOE2JKDQBal5DBB6GDvFSHXzERYo8akX5Ur3oWKQiho1N8bGoUT2m6ExP6TEgCTN3SvUbzK18iuWdnTMSDFNtnwmkdP+AhHg4bHdjMCcmrldfhaV11T4sU8pPCRVH9Ow0NO6g8mROcu9NgGumgFBDwE/DhR13qPMlnYRXl7I4G2zTMxCwHryC9cDOdU30Lxc0f9DDJuLFINZoJxWBgWs3oWlfzSBnef0vyYKeSUOAyUcV9LV62jKOJgFr7bFwNVA==; 5:Mvrz5cWjeWKKQlyxRa0GAug3gFSetW8uxdi1MYqKUzTyHulngPsM8kRo8Zd9T3FJyRVZH2R8r/WToRZN6jaW9d462mlgMdzyKgqfwh6vtb2oigKHVmvb5c16DxtveeHRhQDFPAHmrINnIXESiAwgnQ==; 24:TJ2fAtdQq2a6/mEZssNpQXu54BGMxCnWuw0S93pOPmnWPrA8EH9rvRUOa3ZqQXd0wV+RiaWVD6NUzDIf/bgcWyAt+4xiPhDaMBlUvmMDtng=; 7:VjtAFQTzQnfkRtTHerttCqH5aItcJG9ZQkK7/knwoOOYC4PxSagMN3M9dxw1OIQVgjqy/czNMrmKa27+eei3PCFN5NAHjbrPifAsKGlKy88zpdnAjeW/llliC4YheV7PstkrIGBLJXSOWSK90GEPJmX+NtV6bhcz4bLZzhlZnJIiuNAJdqYKKydudwKVd8DRXdiSveLRR6JAhD5UgN1WBllvLkrBPOrUsjCEXGoD6Fo= SpamDiagnosticOutput: 1:99 SpamDiagnosticMetadata: NSPM X-OriginatorOrg: arm.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 13 Sep 2017 10:48:49.7405 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-Transport-CrossTenantHeadersStamped: DB6PR0802MB2485 The new generic expf and exp2f code don't need wrappers any more, they set errno inline, so only use the wrappers on targets that need it. (The top level wrapper code is included into sysdeps dirs where the wrapper is needed and empty w_exp*f.c where the wrapper is suppressed). A powerpc64 expf implementation includes the expf c code directly which needed some changes. 2017-09-13 Szabolcs Nagy * sysdeps/ieee754/flt-32/e_exp2f.c (__exp2f): Define without wrapper. * sysdeps/ieee754/flt-32/e_expf.c (__expf): Likewise * sysdeps/ieee754/flt-32/w_exp2f.c: New file. * sysdeps/ieee754/flt-32/w_expf.c: New file. * sysdeps/powerpc/powerpc64/fpu/multiarch/e_expf-ppc64.c: Update for the new expf code. * sysdeps/powerpc/powerpc64/fpu/multiarch/w_expf.c: New file. * sysdeps/m68k/m680x0/fpu/w_expf.c: New file. * sysdeps/i386/fpu/w_exp2f.c: New file. * sysdeps/i386/fpu/w_expf.c: New file. * sysdeps/i386/i686/fpu/multiarch/w_expf.c: New file. * sysdeps/x86_64/fpu/w_expf.c: New file. From ba8143da8b2d0a25e1c4ed42704d46a720ebc3e1 Mon Sep 17 00:00:00 2001 From: Szabolcs Nagy Date: Tue, 12 Sep 2017 12:44:18 +0100 Subject: [PATCH 4/4] no wrapper --- sysdeps/i386/fpu/w_exp2f.c | 1 + sysdeps/i386/fpu/w_expf.c | 1 + sysdeps/i386/i686/fpu/multiarch/w_expf.c | 1 + sysdeps/ieee754/flt-32/e_exp2f.c | 7 +++++-- sysdeps/ieee754/flt-32/e_expf.c | 8 ++++++-- sysdeps/ieee754/flt-32/w_exp2f.c | 1 + sysdeps/ieee754/flt-32/w_expf.c | 1 + sysdeps/m68k/m680x0/fpu/w_expf.c | 1 + sysdeps/powerpc/powerpc64/fpu/multiarch/e_expf-ppc64.c | 7 ++++++- sysdeps/powerpc/powerpc64/fpu/multiarch/w_expf.c | 1 + sysdeps/x86_64/fpu/w_expf.c | 1 + 11 files changed, 25 insertions(+), 5 deletions(-) create mode 100644 sysdeps/i386/fpu/w_exp2f.c create mode 100644 sysdeps/i386/fpu/w_expf.c create mode 100644 sysdeps/i386/i686/fpu/multiarch/w_expf.c create mode 100644 sysdeps/ieee754/flt-32/w_exp2f.c create mode 100644 sysdeps/ieee754/flt-32/w_expf.c create mode 100644 sysdeps/m68k/m680x0/fpu/w_expf.c create mode 100644 sysdeps/powerpc/powerpc64/fpu/multiarch/w_expf.c create mode 100644 sysdeps/x86_64/fpu/w_expf.c diff --git a/sysdeps/i386/fpu/w_exp2f.c b/sysdeps/i386/fpu/w_exp2f.c new file mode 100644 index 0000000000..4418f8bed5 --- /dev/null +++ b/sysdeps/i386/fpu/w_exp2f.c @@ -0,0 +1 @@ +#include diff --git a/sysdeps/i386/fpu/w_expf.c b/sysdeps/i386/fpu/w_expf.c new file mode 100644 index 0000000000..b471bccdb1 --- /dev/null +++ b/sysdeps/i386/fpu/w_expf.c @@ -0,0 +1 @@ +#include diff --git a/sysdeps/i386/i686/fpu/multiarch/w_expf.c b/sysdeps/i386/i686/fpu/multiarch/w_expf.c new file mode 100644 index 0000000000..b471bccdb1 --- /dev/null +++ b/sysdeps/i386/i686/fpu/multiarch/w_expf.c @@ -0,0 +1 @@ +#include diff --git a/sysdeps/ieee754/flt-32/e_exp2f.c b/sysdeps/ieee754/flt-32/e_exp2f.c index be53e5c699..7a3c5fdcff 100644 --- a/sysdeps/ieee754/flt-32/e_exp2f.c +++ b/sysdeps/ieee754/flt-32/e_exp2f.c @@ -18,6 +18,7 @@ #include #include +#include #include "math_config.h" /* @@ -42,7 +43,7 @@ top12 (float x) } float -__ieee754_exp2f (float x) +__exp2f (float x) { uint32_t abstop; uint64_t ki, t; @@ -85,4 +86,6 @@ __ieee754_exp2f (float x) y = y * s; return (float) y; } -strong_alias (__ieee754_exp2f, __exp2f_finite) +strong_alias (__exp2f, __ieee754_exp2f) +strong_alias (__exp2f, __exp2f_finite) +versioned_symbol (libm, __exp2f, exp2f, GLIBC_2_27); diff --git a/sysdeps/ieee754/flt-32/e_expf.c b/sysdeps/ieee754/flt-32/e_expf.c index b8244a82cf..8a38c2a0c6 100644 --- a/sysdeps/ieee754/flt-32/e_expf.c +++ b/sysdeps/ieee754/flt-32/e_expf.c @@ -18,6 +18,7 @@ #include #include +#include #include "math_config.h" /* @@ -42,7 +43,7 @@ top12 (float x) } float -__ieee754_expf (float x) +__expf (float x) { uint32_t abstop; uint64_t ki, t; @@ -99,4 +100,7 @@ __ieee754_expf (float x) y = y * s; return (float) y; } -strong_alias (__ieee754_expf, __expf_finite) +hidden_def (__expf) +strong_alias (__expf, __ieee754_expf) +strong_alias (__expf, __expf_finite) +versioned_symbol (libm, __expf, expf, GLIBC_2_27); diff --git a/sysdeps/ieee754/flt-32/w_exp2f.c b/sysdeps/ieee754/flt-32/w_exp2f.c new file mode 100644 index 0000000000..1cc8931700 --- /dev/null +++ b/sysdeps/ieee754/flt-32/w_exp2f.c @@ -0,0 +1 @@ +/* Not needed. */ diff --git a/sysdeps/ieee754/flt-32/w_expf.c b/sysdeps/ieee754/flt-32/w_expf.c new file mode 100644 index 0000000000..1cc8931700 --- /dev/null +++ b/sysdeps/ieee754/flt-32/w_expf.c @@ -0,0 +1 @@ +/* Not needed. */ diff --git a/sysdeps/m68k/m680x0/fpu/w_expf.c b/sysdeps/m68k/m680x0/fpu/w_expf.c new file mode 100644 index 0000000000..b471bccdb1 --- /dev/null +++ b/sysdeps/m68k/m680x0/fpu/w_expf.c @@ -0,0 +1 @@ +#include diff --git a/sysdeps/powerpc/powerpc64/fpu/multiarch/e_expf-ppc64.c b/sysdeps/powerpc/powerpc64/fpu/multiarch/e_expf-ppc64.c index b236290ea2..cc23f06fb1 100644 --- a/sysdeps/powerpc/powerpc64/fpu/multiarch/e_expf-ppc64.c +++ b/sysdeps/powerpc/powerpc64/fpu/multiarch/e_expf-ppc64.c @@ -16,9 +16,14 @@ License along with the GNU C Library; if not, see . */ +#include #undef strong_alias #define strong_alias(a, b) +#undef hidden_def +#define hidden_def(a) +#undef versioned_symbol +#define versioned_symbol(a, b, c, d) -#define __ieee754_expf __ieee754_expf_ppc64 +#define __expf __ieee754_expf_ppc64 #include diff --git a/sysdeps/powerpc/powerpc64/fpu/multiarch/w_expf.c b/sysdeps/powerpc/powerpc64/fpu/multiarch/w_expf.c new file mode 100644 index 0000000000..b471bccdb1 --- /dev/null +++ b/sysdeps/powerpc/powerpc64/fpu/multiarch/w_expf.c @@ -0,0 +1 @@ +#include diff --git a/sysdeps/x86_64/fpu/w_expf.c b/sysdeps/x86_64/fpu/w_expf.c new file mode 100644 index 0000000000..b471bccdb1 --- /dev/null +++ b/sysdeps/x86_64/fpu/w_expf.c @@ -0,0 +1 @@ +#include -- 2.11.0