From patchwork Thu Aug 24 09:27:16 2017 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Szabolcs Nagy X-Patchwork-Id: 22342 Received: (qmail 40697 invoked by alias); 24 Aug 2017 09:27:54 -0000 Mailing-List: contact libc-alpha-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Unsubscribe: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: libc-alpha-owner@sourceware.org Delivered-To: mailing list libc-alpha@sourceware.org Received: (qmail 33801 invoked by uid 89); 24 Aug 2017 09:27:25 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-24.6 required=5.0 tests=AWL, BAYES_00, GIT_PATCH_0, GIT_PATCH_1, GIT_PATCH_2, GIT_PATCH_3, RCVD_IN_DNSWL_NONE, SPF_HELO_PASS, SPF_PASS autolearn=ham version=3.3.2 spammy=Hx-languages-length:1343 X-HELO: EUR03-AM5-obe.outbound.protection.outlook.com Authentication-Results: spf=none (sender IP is ) smtp.mailfrom=Szabolcs.Nagy@arm.com; Message-ID: <599E9BF4.2060202@arm.com> Date: Thu, 24 Aug 2017 10:27:16 +0100 From: Szabolcs Nagy User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.8.0 MIME-Version: 1.0 To: GNU C Library CC: nd@arm.com Subject: [RFC][PATCH] fix math cflags overrides X-ClientProxiedBy: DB6PR06CA0026.eurprd06.prod.outlook.com (2603:10a6:6:1::39) To HE1PR0802MB2489.eurprd08.prod.outlook.com (2603:10a6:3:d8::23) X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 8eec6448-40bc-401a-cd6c-08d4ead25174 X-MS-Office365-Filtering-HT: Tenant X-Microsoft-Antispam: UriScan:; BCL:0; PCL:0; RULEID:(300000500095)(300135000095)(300000501095)(300135300095)(22001)(300000502095)(300135100095)(2017030254152)(48565401081)(300000503095)(300135400095)(49563074)(201703131423075)(201703031133081)(201702281549075)(300000504095)(300135200095)(300000505095)(300135600095)(300000506095)(300135500095); SRVR:HE1PR0802MB2489; X-Microsoft-Exchange-Diagnostics: 1; HE1PR0802MB2489; 3:D8EurFM314lt8mW2aFW2JJjv0VSCr8R4y/lBCVyJp7iWeAQI78ZBr+zVGZaa4+fco65i9Xaz4DdeJGKdbvCN2+O7OghbGrjlvSTsFq8bWk+AFQD0NboFnwwDtNoT9HpIKq+r29VrR2hFoDUBIMELI3MQsEN9uZAiqCQOLdwdNyJITSc/cgG4FLOOv+RE92nxsSuOjU4L9KucHbKucvZk9ozGMorNe9R//05LqaLRlUdUGE+5hDrDwFThRuChuybA; 25:k9oeSD72/CnovN4ThSHob54syQo65Msz1VRdaR22KwT9coZZUAMXsMY8FguRbvBL41pa8PZ290m4g4uwqhHTp2w+N+Q0CN3nLHPu3v+cswCRoLlSgSZgojsifEG6GcW4RquNEL09WaABAuQWF7tPBSdStiZiOo0qS/syPQTT4Y0wXl3j9xQ0z1QHFHTPO1m6ZTnwaABDSUxQzURox35n0qLKwIMfuO8e3WseU9GUw12ciTK5NTz696ASBZ89Tvd6FDEMNmYmD5AiHymJ29uV9gwXDY6Zd2yMI1W82M+QZL/5ATzJmMoEkqlcmIs8A1JOT2pLil5UTafBSzzBa+d95w==; 31:Hl7n6FqpipPWZ6L6fSLG8d+ZQjQpH4V50Q/KfIUSWmk4PmcsnhfhfDjJiuddYdSs/C0XugzoptBWUc4gdHx9/78ZbnZkihMGga1x1OYuLvHxd5A2zIAaeH2UJXgQ8QFMzJixb2mZ+yAvYQTSWwYqMbavw/QuZ9FXVbMzkUpu/h6GRT2jF/tqtd93fyBKceZNiqhTGgDWpNmLiBKmPukhqGw6rZnsATQvc0YDDCHDO04= X-MS-TrafficTypeDiagnostic: HE1PR0802MB2489: NoDisclaimer: True X-Microsoft-Exchange-Diagnostics: 1; HE1PR0802MB2489; 20:XeCfG9efdRdiHrqAL8U1JKvMjcBEH2EfKpL7TtwS1JACYzBV9fJWjaNvHtusc1k+OX6VBs1O28O0p+RN4esLvYih3N7+K6agrj1dON529MRWWoXZ2ND72P352/yKzmRRXEhPtyXzMI/q1pCgEBya6d7aVOgGKiF0CiBpYqFGD00=; 4:olmo3w2V7SrT6EJwmz0/+4W3ZFir3pwQE7+vANoJhnhEb4Guk5q6i3QwCIhasbdz7X0rCRn2kh115iv2D8fFeANekx25Q/EKSfLdsF5x5Jwpqyt6hmR0bQNr38QOi5Hw0zkTR0Mgd7KAI9eOIbKAiPEW0vjq8Yd5S9lGzGFnvp/xNsHtFKxZ/gFL+JA6IafvTPeUGF2xQmUbMcNmSuSXULgAJe5xI135piOQcfIZnzKGjYaizWdlXfRu8KNempt1buEzTUEsBULdvNa3jmukjwJaGIaywpwABfdiNlELg7I= X-Exchange-Antispam-Report-Test: UriScan:(180628864354917); X-Microsoft-Antispam-PRVS: X-Exchange-Antispam-Report-CFA-Test: BCL:0; PCL:0; RULEID:(100000700101)(100105000095)(100000701101)(100105300095)(100000702101)(100105100095)(102415395)(6040450)(601004)(2401047)(8121501046)(5005006)(10201501046)(100000703101)(100105400095)(93006095)(93001095)(3002001)(6055026)(6041248)(201703131423075)(201702281528075)(201703061421075)(201703061406153)(20161123555025)(20161123558100)(20161123560025)(20161123562025)(20161123564025)(6072148)(201708071742011)(100000704101)(100105200095)(100000705101)(100105500095); SRVR:HE1PR0802MB2489; BCL:0; PCL:0; RULEID:(100000800101)(100110000095)(100000801101)(100110300095)(100000802101)(100110100095)(100000803101)(100110400095)(100000804101)(100110200095)(100000805101)(100110500095); SRVR:HE1PR0802MB2489; X-Forefront-PRVS: 04097B7F7F X-Forefront-Antispam-Report: SFV:NSPM; SFS:(10009020)(7370300001)(4630300001)(6009001)(6049001)(39860400002)(189002)(377424004)(199003)(6486002)(83506001)(68736007)(77096006)(4001350100001)(5890100001)(270700001)(568964002)(7736002)(53936002)(110136004)(6116002)(4610100001)(4326008)(64126003)(84326002)(80316001)(305945005)(2906002)(97736004)(3846002)(59896002)(81156014)(65816999)(6666003)(54356999)(87266999)(189998001)(72206003)(50986999)(8676002)(33656002)(81166006)(86362001)(101416001)(25786009)(478600001)(7350300001)(6916009)(2476003)(21490400003)(5660300001)(65956001)(5000100001)(106356001)(65806001)(42186005)(36756003)(66066001)(105586002); DIR:OUT; SFP:1101; SCL:1; SRVR:HE1PR0802MB2489; H:[10.2.206.69]; FPR:; SPF:None; PTR:InfoNoRecords; MX:1; A:1; LANG:en; Received-SPF: None (protection.outlook.com: arm.com does not designate permitted sender hosts) X-Microsoft-Exchange-Diagnostics: =?us-ascii?Q?1; HE1PR0802MB2489; 23:qN/CuQ1yQSBOQwdAtRyktC1otDlNfv3+0aZZidw?= =?us-ascii?Q?x4hGETEyd40aDo/my0nTpxSNrL6ZFmgHIDz7c42GqDv5kVz8U4ONWnnBtDJT?= =?us-ascii?Q?HDTen6mOvv7o4fDGLBKasNoAoUB8YFATaFfpsbgrPToiIbhkoeJOgrnrWBEC?= =?us-ascii?Q?Lh73TTcXnsoFu8OABf8+8oo6C2xu/pDq/RPgLlLlf5Fbgv5/pLFIly/eO6Li?= =?us-ascii?Q?q56TycC7Wg5IarqE/HXePRcVavx75IuXj9CPsQ+kD89Bxiip7lZDtJyKal2x?= =?us-ascii?Q?2urApwbKyj5Q4+7WosYy57HQkv5+dWRIUgaYT23RXKQ12123g5nWIJqU7Tfo?= =?us-ascii?Q?Y4Pbf7Oq4hH+NKI3E/CwkmS9kvSEpr/sBbQSyf9luhhRZ1JGxB5ijFA9zTZt?= =?us-ascii?Q?fLCu7tjmVIr+XLFZwhkMj1snAEqGaUhc63KIlAAGe/zkpIEdfeaLz9j3qITo?= =?us-ascii?Q?qmBxzITmu6jH03p1/GghF8W55Q1RSBwCZf15zEwFQbm9MWtKKUL0XuZxN4Om?= =?us-ascii?Q?iyfS1I8RdOPT8jEiApu62tPs4ygsO2Aj9V24Xja/9/VO2W0x1Dt5ZBfVyrlc?= =?us-ascii?Q?jumudADHEYtTOItC0AWWqx//09QBnvb9Sw0KiuAvdMAa3B9hy02/wkoebwMw?= =?us-ascii?Q?gjr7Gb/ivQqnpishc6uRqWlpBsxem5hJ+U5eHyGlKEE9+xHwvD9obkwwU2Oj?= =?us-ascii?Q?mHJ6q02SF49+iNreCVXf6Q/T6VTY6t05LYVT/JZ7gtgrsYCDaTASgPAOuxnX?= =?us-ascii?Q?8i6MgLWIc6Gi+zD/derHx3GUsncZXiL/KDr7Z+SS9ZuUiPttkT23LLZWTrzr?= =?us-ascii?Q?URDlaNtw+S2RaUJ4ldpwEprUfrnNkPyJBB9CSJ9Lnim1vDb2awLoidZA6Xqm?= =?us-ascii?Q?8Xzhww6kkmIe8JjYuDM1fDarUC6j8pqoq4alUDTuDUHAcc3eSFUZK/ryadoK?= =?us-ascii?Q?aCneSoYCuJnP1DCNSW1QTTfZyJeNB1o6Qdys/cO+6KW9fZPIFkAf3QmHo2bz?= =?us-ascii?Q?0aMAFhqLisMxMRbHzcjaBSFgAn4if6ltgltiWMK+vhAK3ARoCyGdt8N7Yuwn?= =?us-ascii?Q?rc/h1Jornm4kUzdgS1G8bbEJAV05Cv1Xm5qLmHyTVxdY0nES1e+wgck89SSw?= =?us-ascii?Q?ZyAxAdebAqGirEbZykE7XLHI9DPKW8lO/IhG2SRGAl6sMuAApXzI3DhcZ1db?= =?us-ascii?Q?pnwWme123n9mKGqLYpWqfz+yH2jTN8SAkF2Rww+y+4+tJM5l8giopKykqfcP?= =?us-ascii?Q?eHgubbe3PSc9QSYb97KQ/vQeNd3xIvzEvRCrGfxr4DtNMhHr4zXMJKHT1nLG?= =?us-ascii?Q?lWR/YWnh0ldQL6+Wbe5m1SZss7JkJtUglYsVXwsmLHrwtUyPjaq0V8tjrad2?= =?us-ascii?Q?bRIUTairkLFPYyZtdnYrzpemOn4gW4dFQNxyx5K6H4/adW/Enj9nefCvppkk?= =?us-ascii?Q?Cy9dyUp5DsA=3D=3D?= X-Microsoft-Exchange-Diagnostics: 1; HE1PR0802MB2489; 6:pg9zDRhflwAnd4UoOiUyXf8Jq6mgSrNTosmKesWfyDHfeynj6/YUN6MC8+J8ep3Ap4hwhNnQhewCbm05Vl+VO9ZpV/UobCUUwScbSQ//++Gv7MAqFkmufnAQbrmrzei4uiw+bA4wGBDsbDu3m/4DRRn/aa76aH0G7Z1pTngZoVwtIyWsRJRG2uItSV7mghbxodv7KzT75vms2G8FL025MV1DGDeDI7Zd/8Fmex0JzAY1i4M8YrBhKLmxej69dobVuSiTnbE6a6rLuu+/LiRF15PK/l/fhjJ9VJ42QZMxeHVDmwqahU2R18gBVqfiaj7kgK11vOl5lcCg3R1qqYQ4wQ==; 5:42ON5MAIJba7A35OReOmYGwFeeMe5/W7rxxhVnrFxY9FTAccudwjiACsH3Y+3ybumUbj1pTy9xD0FIW1K5AbqxtYDy5MHGjMS/OgWJDc8FQxLQio7nfymqO+EIxJRRl1rsPZRcnOAre3gUstEOHhhg==; 24:O0C2CPD2XV8tZ59jQgdTFcGQ80CToRaI8sbg2i1U4iNA1ONzV58TPSetug7FMzOuUXCWUWWYTHj8+GGIOFpK6ujcxlut+0sRGoCSc3NOz04=; 7:YSOheWg/lOmN86QK6cNuTuwuxewWttyrKZP9uBKrdqhRk3evktj0yjaUy33iUkVnYetWkl4IVesMZvsfe0BWEuh/8izGhI+baS4xEoK2t3Xaarj2oEj9SU3s4AjEq28MHvtBlWJVmkVDtFIKzo4/OzkdizvhB2Rgqy4gU4X8AMY5cokBzZW9vMSQYrp0cxZcMA8WO5z5wcbHujHa2IBrc/AmU/0E3VKp5MIfIQFBZBk= SpamDiagnosticOutput: 1:99 SpamDiagnosticMetadata: NSPM X-OriginatorOrg: arm.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 24 Aug 2017 09:27:19.3129 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-Transport-CrossTenantHeadersStamped: HE1PR0802MB2489 The problem i see is that in the makefile logic the sysdirs var has sysdeps/aarch64/fpu before sysdeps/ieee754/dbl-64. this means source files and rules in the former override files in the later (which is good), but it also means variable definitions in makefile fragments of the later overrides the ones of the former (i.e. reverse order wrt the source override, which is not what i'd expect). as a workaround i'd just use += instead of = in the dbl-64 makefile cflags definitions so at least it does not drop earlier cflags, the cflag definition ordering is not ideal: if i have a target specific sqrt, i don't want to compile it with nofma flags. 2017-08-23 Szabolcs Nagy * sysdeps/ieee754/dbl-64/Makefile: Don't override cflags. diff --git a/sysdeps/ieee754/dbl-64/Makefile b/sysdeps/ieee754/dbl-64/Makefile index 5557c75b45..c965982fa5 100644 --- a/sysdeps/ieee754/dbl-64/Makefile +++ b/sysdeps/ieee754/dbl-64/Makefile @@ -1,6 +1,6 @@ ifeq ($(subdir),math) # branred depends on precise IEEE double rounding -CFLAGS-branred.c = $(config-cflags-nofma) -CFLAGS-e_sqrt.c = $(config-cflags-nofma) -CFLAGS-e_pow.c = $(config-cflags-nofma) +CFLAGS-branred.c += $(config-cflags-nofma) +CFLAGS-e_sqrt.c += $(config-cflags-nofma) +CFLAGS-e_pow.c += $(config-cflags-nofma) endif