diff mbox

localedef --old-style is a no-op

Message ID 575C0BBF.9070409@redhat.com
State Committed
Headers

Commit Message

Marko Myllynen June 11, 2016, 1:01 p.m. UTC 
  Hi,

On 2016-06-11 08:44, Mike Frysinger wrote:
> On 02 Jun 2016 22:16, Mike Frysinger wrote:
>> On 02 Jun 2016 22:31, Joseph Myers wrote:
>>> On Mon, 30 May 2016, Marko Myllynen wrote:
>>>> On 2016-05-27 21:16, Mike Frysinger wrote:
>>>>> On 27 May 2016 14:55, Marko Myllynen wrote:
>>>>>> The --old-style option for localedef is a no-op. Is the patch below to
>>>>>> reflect this worth the effort (considering translations) or should we
>>>>>> leave it as is? (I've already submitted a patch to man pages upstream
>>>>>> to adjust the localedef(1) man page.)
>>>>>
>>>>> this code has been dead for 16 years afaict.  i think that's more than
>>>>> enough time to let people update their scripts, so let's just drop the
>>>>> option entirely.
>>>>
>>>> Ok, how about the patch below? (Please fine-tune the ChangeLog entry if
>>>> needed.)
>>>
>>> In my view such a feature removal (even of a no-op feature) merits a NEWS 
>>> entry as well.
>>
>> np.  if no one else has concerns, i can take of merging it.
> 
> done!

Thanks for taking care of this, Mike. However, isn't the NEWS entry a
bit unclear at the moment, how about something like this instead?

2016-06-11  Marko Myllynen  <myllynen@redhat.com>

	* NEWS (2.24): Adjust --old-style removal text.

---
 NEWS | 5 +++--
 1 file changed, 3 insertions(+), 2 deletions(-)


Thanks,

Comments

Mike Frysinger June 11, 2016, 6:34 p.m. UTC | #1 
On 11 Jun 2016 16:01, Marko Myllynen wrote:
> On 2016-06-11 08:44, Mike Frysinger wrote:
> > On 02 Jun 2016 22:16, Mike Frysinger wrote:
> >> On 02 Jun 2016 22:31, Joseph Myers wrote:
> >>> On Mon, 30 May 2016, Marko Myllynen wrote:
> >>>> On 2016-05-27 21:16, Mike Frysinger wrote:
> >>>>> On 27 May 2016 14:55, Marko Myllynen wrote:
> >>>>>> The --old-style option for localedef is a no-op. Is the patch below to
> >>>>>> reflect this worth the effort (considering translations) or should we
> >>>>>> leave it as is? (I've already submitted a patch to man pages upstream
> >>>>>> to adjust the localedef(1) man page.)
> >>>>>
> >>>>> this code has been dead for 16 years afaict.  i think that's more than
> >>>>> enough time to let people update their scripts, so let's just drop the
> >>>>> option entirely.
> >>>>
> >>>> Ok, how about the patch below? (Please fine-tune the ChangeLog entry if
> >>>> needed.)
> >>>
> >>> In my view such a feature removal (even of a no-op feature) merits a NEWS 
> >>> entry as well.
> >>
> >> np.  if no one else has concerns, i can take of merging it.
> > 
> > done!
> 
> Thanks for taking care of this, Mike. However, isn't the NEWS entry a
> bit unclear at the moment, how about something like this instead?

pronouns, how do they work ? ;)

updated now, thanks
-mike
diff mbox

Patch

diff --git a/NEWS b/NEWS
index 4334578..9b5d9fe 100644
--- a/NEWS
+++ b/NEWS
@@ -36,8 +36,9 @@  Version 2.24
 * The deprecated __malloc_initialize_hook variable has been removed from the
   API.
 
-* The long unused --old-style flag has been removed.  It hasn't done anything
-  in over 16 years.  Scripts using this flag can safely drop it.
+* The long unused localedef --old-style option has been removed.  It hasn't
+  done anything in over 16 years.  Scripts using this option can safely
+  drop it.
 
 Security related changes: