From patchwork Wed Mar 16 04:54:56 2016 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: Carlos O'Donell X-Patchwork-Id: 11350 X-Patchwork-Delegate: vapier@gentoo.org Received: (qmail 71295 invoked by alias); 16 Mar 2016 04:55:03 -0000 Mailing-List: contact libc-alpha-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Unsubscribe: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: libc-alpha-owner@sourceware.org Delivered-To: mailing list libc-alpha@sourceware.org Received: (qmail 71278 invoked by uid 89); 16 Mar 2016 04:55:02 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-2.6 required=5.0 tests=AWL, BAYES_00, RCVD_IN_DNSWL_LOW autolearn=ham version=3.3.2 spammy=classified, 205, vapiergentooorg, vapier@gentoo.org X-HELO: mail-qk0-f172.google.com X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:subject:to:references:from:organization :message-id:date:user-agent:mime-version:in-reply-to :content-transfer-encoding; bh=IzqsJU6k05PYWAAKALYCDrbtSdYJ67uaLl9hkoSfbTU=; b=hp34h58bYQ4ssXMas25VY+bMFovQnzjGY0h2zMGNT7jtUa7rsV5sdhQBOqZtf/fL+W UfTvc/Yvec1wReHwUT8s7JYufUgLiuaIE49eBtFpRZRC4VZKrh1TstH+ZrdrtUBTy4xT DYucmOC4lQNrBC+3bwIsJjJ/v6GvcITl3UHD0DxLiNmcucVDDpM3DU7seXvKIZH9GdaF tTKZ/VqVMcrawxQFJ5pTQEtjrDw+o40G6v0Y7qzBtf86NOEw6qbQVaDfKwB6weenbd8C GoitfJpggMSbvKUHpLMTqEiM39YKrez7wnam8MF6IMB1LCFXKIBUyKdGtDewRhSnhjT3 F3Yg== X-Gm-Message-State: AD7BkJJgylTM9B5qtdqJOLYs1QOB0Riso9jEWxLPyfxO7Vu6uerNATxELuPpCjjxWfgrQTym X-Received: by 10.55.72.130 with SMTP id v124mr2356020qka.13.1458104098878; Tue, 15 Mar 2016 21:54:58 -0700 (PDT) Subject: Re: [PATCH] locales: an_ES: fix lang_ab value To: Mike Frysinger , libc-alpha@sourceware.org, Aurelien Jarno References: <1455943116-25940-1-git-send-email-vapier@gentoo.org> <20160229154600.GE21371@aurel32.net> From: Carlos O'Donell Message-ID: <56E8E720.9010507@redhat.com> Date: Wed, 16 Mar 2016 00:54:56 -0400 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.6.0 MIME-Version: 1.0 In-Reply-To: <20160229154600.GE21371@aurel32.net> On 02/29/2016 10:46 AM, Aurelien Jarno wrote: > On 2016-02-19 23:38, Mike Frysinger wrote: >> Aragonese is classified as "an" so set it. >> --- >> localedata/locales/an_ES | 1 + >> 1 file changed, 1 insertion(+) >> >> diff --git a/localedata/locales/an_ES b/localedata/locales/an_ES >> index cc18c6b..e6d00f3 100644 >> --- a/localedata/locales/an_ES >> +++ b/localedata/locales/an_ES >> @@ -134,6 +134,7 @@ postal_fmt "/ >> country_ab2 "" >> country_ab3 "" >> country_num 724 >> +lang_ab "" >> % E >> country_car "" >> % aragonés > > This is correct > This is not correct. You must use an abbreviation which matches exactly in case with ISO 639 names. This commit: ~~~ commit 75aa31de9fb79986e5424f80dd152f684a3a16b1 Author: Mike Frysinger Date: Fri Feb 19 23:25:03 2016 -0500 localedata: an_ES: fix lang_ab value Aragonese is classified as "an" so set it. ~~~ Causes the following failure for me in auto-sync'd Fedora Rawhide: an_ES.UTF-8...LC_ADDRESS: language abbreviation `AN' not defined Makefile:205: recipe for target 'install-an_ES.UTF-8/UTF-8' failed make[2]: *** [install-an_ES.UTF-8/UTF-8] Error 1 make[2]: Leaving directory '/home/carlos/src/glibc/localedata' Makefile:421: recipe for target 'localedata/install-locales' failed make[1]: *** [localedata/install-locales] Error 2 make[1]: Leaving directory '/home/carlos/src/glibc' Makefile:9: recipe for target 'localedata/install-locales' failed make: *** [localedata/install-locales] Error 2 I believe the fix should be to use lowercase 'an': --- That is to say that the language abbreviation must be lowercase and thus match locale/iso-639.def. Please make sure you run: `make localedata/install-locales DESTDIR=/tmp/glibc-install` as a sanity check for these kinds of changes. diff --git a/localedata/locales/an_ES b/localedata/locales/an_ES index e6d00f3..202732d 100644 --- a/localedata/locales/an_ES +++ b/localedata/locales/an_ES @@ -134,7 +134,7 @@ postal_fmt "/ country_ab2 "" country_ab3 "" country_num 724 -lang_ab "" +lang_ab "" % E country_car "" % aragonés