[COMMITTED] tile: define __NO_LONG_DOUBLE_MATH

Message ID	5655FFFD.4010306@ezchip.com
State	Committed
Headers	Mailing-List: contact libc-alpha-help@sourceware.org; run by ezmlm Precedence: bulk Sender: libc-alpha-owner@sourceware.org Subject: Re: [COMMITTED] tile: define __NO_LONG_DOUBLE_MATH To: Joseph Myers <joseph@codesourcery.com> References: <1448399819-2804-1-git-send-email-cmetcalf@ezchip.com> <alpine.DEB.2.10.1511242230080.10652@digraph.polyomino.org.uk> <56550015.7020109@ezchip.com> <alpine.DEB.2.10.1511250104490.10652@digraph.polyomino.org.uk> CC: <libc-alpha@sourceware.org> From: Chris Metcalf <cmetcalf@ezchip.com> Message-ID: <5655FFFD.4010306@ezchip.com> Date: Wed, 25 Nov 2015 13:37:49 -0500 User-Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:38.0) Gecko/20100101 Thunderbird/38.3.0 MIME-Version: 1.0 In-Reply-To: <alpine.DEB.2.10.1511250104490.10652@digraph.polyomino.org.uk> Content-Type: text/plain; charset="windows-1252"; format=flowed Content-Transfer-Encoding: 7bit Received-SPF: None (protection.outlook.com: ezchip.com does not designate permitted sender hosts) X-Microsoft-Exchange-Diagnostics: =?Windows-1252?Q?1; AMSPR02MB118; 23:84tCgwldrYwvQx2hCCH7tnYJaHheaVqFk8YCTt?= =?Windows-1252?Q?z4HGJnL877IMHMgbUeFCL+StREyjlmwjsT3A5C1UI/BB76ph//qDONcf?= =?Windows-1252?Q?8kp747jmIsTlOjObmi5CUGV9jwy9Mq9T06FDPKrMiU0ADxQdfCNnfAt+?= =?Windows-1252?Q?7JuiZVZPGUzKJdCLM9S3FijEDlURLCliQgvkm9z1YBxhrFFwm68MiwQh?= =?Windows-1252?Q?WdwpwWvACtcFsgz8O0wsf0FwFbF/C4xAbiwKJ355Tkg6LRDOjHexpQrb?= =?Windows-1252?Q?cYx7EVoe7rotCy6W1mQY+z4XS4urCwJF3qrMnQPl8vUgmwJnLGW8FFoz?= =?Windows-1252?Q?esYxbHuxYWUxvlQd4VQ8YVpFhDtWjICUpazgvBO5htIkHWOinSMG6cJ8?= =?Windows-1252?Q?AdWW7TsVsri8zpvJwjIMVrm0h7RtCsmPoxv9JHXUuFYZAZaIp/ttQvM2?= =?Windows-1252?Q?qqDpveiJA8nohdd4Z5qs71Le3MZwc9Vb/xw4chjl8SvOuLRL960pw6sP?= =?Windows-1252?Q?UoxjvL4IvsZUMK6oZA4mv9C6VFh6N/yzzwrboHSFZyo97Z1bDRdyGIlq?= =?Windows-1252?Q?5/PaQg2m+JmKF6KOMLiPvyRab+PWwy8WZzt/fSeQGctOQprGpAoXasV0?= =?Windows-1252?Q?zqyhpcAGXRVwd0qey6FJC/vCk2tR8aP8wnubRE3nvUhMTFUmfPSnN7aZ?= =?Windows-1252?Q?J+Dddi604UyrF5iJOgrrZbdJSulbT0g+jacAD0HRCU1yMmkRn99RM7vN?= =?Windows-1252?Q?uEwEQQ+ZIVFdGiIU1qYD12F8E+UTm/vAAbfQOegE9UkSvW7cM7n8fSRu?= =?Windows-1252?Q?YrsWhc/4kabBpcu89cYOkUYbEnfxU3iw0lFkEqqR0pVUm8SF3+qXAFi2?= =?Windows-1252?Q?hc/4+bESUvkZfXhmVKT/1nyu4Q4xCJE86t2qnRU4uCwFfK9HrxrzhDHL?= =?Windows-1252?Q?PEo35ile79Rygon9BKh6k6HQ/B6kE5otJXSG3MAodkY5qxONff3XMm6B?= =?Windows-1252?Q?quyAtpNaHgUpNzJhl/HSCyMCo/04eECrpPSUWCOH9fApvpGLQMSgMdob?= =?Windows-1252?Q?DZeNhunk2XX2UOXG917O1qznsEh1o1QBcVLZCiRtHOWGVSZub1wCGRPX?= =?Windows-1252?Q?ZYiWDDWsKVO0LboIm52NJGQnBERXlb40SctneZ7ZAA7Dm3d+D7chOCCI?= =?Windows-1252?Q?+XDCiWSdYwY5bPlRxGH8zXLZXNKboF3AZZxWwO2+PmYU0AJteXKPyD6G?= =?Windows-1252?Q?XV0eYXdpX/LbbUFaojWSYwxPUsgBLjh4e3/kiYfdE/YC0A25jUCf6z4Z?= =?Windows-1252?Q?EYxHJWNoQQ/mcxeej+HcCXk2d502aBrJNQBQsA8IGiRKhc2H/kmV18I/?= =?Windows-1252?Q?bp2OJyIVcPq3cwunVkDu3vXJmakmo/0rak70gLpYq9M8tN0433f0AebI?= =?Windows-1252?Q?7Haro706IEQ2PyPobGkRJ/VjJDaBgUkmO0NsqR2Nf/BItQ5Z1ogsbL3M?= =?Windows-1252?Q?qNQV3k6VlTi8tTUh0NV7LqEWlX1vMUPDCl44DTMaERB7RExuHJhwc7xd?= =?Windows-1252?Q?ONe8GhixN7tVRdQzVgLiTvXnkF3kDEgqxTNP6T0Q9w5V4ej5aLwOWau9?= =?Windows-1252?Q?m+BigbWrR+MpUDXk+NwvE8+7UstonZSWSRnEa72TsAmBZezCALa64kOR?= =?Windows-1252?Q?tBW6hUfw=3D=3D?= X-Microsoft-Exchange-Diagnostics: 1; AMSPR02MB118; 5:c9BUgBrU5j8JhpKeORZYfZEZPoWLO+qonjgNrn/Qv+UBCzKajixN00Jc2HX89wKLfLpqhAazn0X8Da2xFkNO+5cSVfIgSARJ/iGfgCnXzZw7aRIRZk+6g/011rLxy+txjWlRmFEoHtYnqzJITT+C0Q==; 24:qYUTnyYA+wDVlozWxZ38mAmIESeXLkP4B/eVgpZ1nUdOfSq6M+6DemlRRHr4zK1Hp17afZEXGgewch5wcMmjFj5Dj2Wys8hH0+XgHcEbfMA= SpamDiagnosticOutput: 1:23 SpamDiagnosticMetadata: NSPM

Message ID

5655FFFD.4010306@ezchip.com

State

Committed

Headers

Mailing-List: contact libc-alpha-help@sourceware.org; run by ezmlm
Precedence: bulk
Sender: libc-alpha-owner@sourceware.org
Subject: Re: [COMMITTED] tile: define __NO_LONG_DOUBLE_MATH
To: Joseph Myers <joseph@codesourcery.com>
References: <1448399819-2804-1-git-send-email-cmetcalf@ezchip.com>
	<alpine.DEB.2.10.1511242230080.10652@digraph.polyomino.org.uk>
	<56550015.7020109@ezchip.com>
	<alpine.DEB.2.10.1511250104490.10652@digraph.polyomino.org.uk>
CC: <libc-alpha@sourceware.org>
From: Chris Metcalf <cmetcalf@ezchip.com>
Message-ID: <5655FFFD.4010306@ezchip.com>
Date: Wed, 25 Nov 2015 13:37:49 -0500
User-Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:38.0) Gecko/20100101
	Thunderbird/38.3.0
MIME-Version: 1.0
In-Reply-To: <alpine.DEB.2.10.1511250104490.10652@digraph.polyomino.org.uk>
Content-Type: text/plain; charset="windows-1252"; format=flowed
Content-Transfer-Encoding: 7bit
Received-SPF: None (protection.outlook.com: ezchip.com does not designate
	permitted sender hosts)
SpamDiagnosticOutput: 1:23
SpamDiagnosticMetadata: NSPM
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 25 Nov 2015 18:37:50.8225
	(UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-Transport-CrossTenantHeadersStamped: AMSPR02MB118

Commit Message

Chris Metcalf Nov. 25, 2015, 6:37 p.m. UTC

  On 11/24/2015 8:09 PM, Joseph Myers wrote:
> On Tue, 24 Nov 2015, Chris Metcalf wrote:
>
>> as well, so it seemed uncontroversial.  And I only chose 2.12 on the theory
>> that they
>> should have been exported then.  I don't really care what version I export
> That's not how things work.  The version is always the version where the
> symbols were actually first exported, not where they "should" have been
> exported; you never add symbols to a past release version.  See exp2l in
> math/Versions or fallocate64 in sysdeps/unix/sysv/linux/<various 32-bit
> architectures>/Versions for examples.

Yes, good point.  See attached patch that I will plan to commit after it passes tests.

>> them as, since there's really no way for userspace to generate a
>> reference to them,
> Which is why it would be optimal not to export them at all.
>
>> what would be cleaner here and I am happy to make the change, but it does seem
>> like it should be a change for every platform without long double, not just
>> tile.
> Well, you don't remove symbols from old versions either.  Optimally the
> default should be that they aren't exported, with existing no-long-double
> platforms that had the exports defining some macro in their sysdeps files
> (e.g. math_private.h) to cause them to be exported (and ideally causing
> them to be exported as compat symbols only, given that it's not possible
> for the headers to generate references to them).

But apparently there are subtleties, given the bug I cited in my previous email that
led to __isnanl causing a link failure on hppa.  I would have thought that would be
impossible.  So I think I will not try tackling this at the moment...

Thanks!


commit 0c82839a29cb5a0d46141c1a1fab19085649034c
Author: Chris Metcalf <cmetcalf@ezchip.com>
Date:   Wed Nov 25 13:26:30 2015 -0500

     tile: Adjust version number for __finitel, __isinfl, __isnanl

     They should have been added with version 2.23, not 2.12.

Comments

Joseph Myers Nov. 25, 2015, 6:48 p.m. UTC | #1

On Wed, 25 Nov 2015, Chris Metcalf wrote:

> But apparently there are subtleties, given the bug I cited in my previous
> email that
> led to __isnanl causing a link failure on hppa.  I would have thought that
> would be
> impossible.  So I think I will not try tackling this at the moment...

If someone were to write an isnan macro call with an argument whose size 
isn't that of float or double (e.g. an integer argument), that would have 
resulted in a call to __isnanl without __NO_LONG_DOUBLE_MATH defined.  
Such code has undefined behavior - all those macros require arguments of 
real floating type - but it could explain the __isnanl call.

diff mbox

Patch

diff --git a/ChangeLog b/ChangeLog
index ceb14b7..b374a2c 100644
--- a/ChangeLog
+++ b/ChangeLog
@@ -1,3 +1,16 @@ 
+2015-11-25  Chris Metcalf  <cmetcalf@ezchip.com>
+
+       * sysdeps/unix/sysv/linux/tile/tilegx/tilegx32/libc.abilist:
+       Adjust version number for __finitel, __isinfl, and __isnanl.
+       * sysdeps/unix/sysv/linux/tile/tilegx/tilegx64/libc.abilist:
+       Likewise.
+       * sysdeps/unix/sysv/linux/tile/tilepro/libc.abilist: Likewise.
+       * sysdeps/unix/sysv/linux/tile/tilegx/tilegx32/libm.abilist:
+       Likewise.
+       * sysdeps/unix/sysv/linux/tile/tilegx/tilegx64/libm.abilist:
+       Likewise.
+       * sysdeps/unix/sysv/linux/tile/tilepro/libm.abilist: Likewise.
+
  2015-11-25  Samuel Thibault  <samuel.thibault@ens-lyon.org>

         * hurd/sigunwind.c (_hurdsig_longjmp_from_handler): Destroy reply port
diff --git a/sysdeps/unix/sysv/linux/tile/tilegx/tilegx32/libc.abilist b/sysdeps/unix/sysv/linux/tile/tilegx/tilegx32/libc.abilist
index 152adb0..d902a9c 100644
--- a/sysdeps/unix/sysv/linux/tile/tilegx/tilegx32/libc.abilist
+++ b/sysdeps/unix/sysv/linux/tile/tilegx/tilegx32/libc.abilist
@@ -182,7 +182,6 @@  GLIBC_2.12 __fgetws_chk F
  GLIBC_2.12 __fgetws_unlocked_chk F
  GLIBC_2.12 __finite F
  GLIBC_2.12 __finitef F
-GLIBC_2.12 __finitel F
  GLIBC_2.12 __flbf F
  GLIBC_2.12 __fork F
  GLIBC_2.12 __fpending F
@@ -228,11 +227,9 @@  GLIBC_2.12 __isdigit_l F
  GLIBC_2.12 __isgraph_l F
  GLIBC_2.12 __isinf F
  GLIBC_2.12 __isinff F
-GLIBC_2.12 __isinfl F
  GLIBC_2.12 __islower_l F
  GLIBC_2.12 __isnan F
  GLIBC_2.12 __isnanf F
-GLIBC_2.12 __isnanl F
  GLIBC_2.12 __isoc99_fscanf F
  GLIBC_2.12 __isoc99_fwscanf F
  GLIBC_2.12 __isoc99_scanf F
@@ -2092,6 +2089,9 @@  GLIBC_2.18 __cxa_thread_atexit_impl F
  GLIBC_2.22 GLIBC_2.22 A
  GLIBC_2.22 fmemopen F
  GLIBC_2.23 GLIBC_2.23 A
+GLIBC_2.23 __finitel F
+GLIBC_2.23 __isinfl F
+GLIBC_2.23 __isnanl F
  GLIBC_2.23 fts64_children F
  GLIBC_2.23 fts64_close F
  GLIBC_2.23 fts64_open F
diff --git a/sysdeps/unix/sysv/linux/tile/tilegx/tilegx32/libm.abilist b/sysdeps/unix/sysv/linux/tile/tilegx/tilegx32/libm.abilist
index 9ba58e2..9ef03e5 100644
--- a/sysdeps/unix/sysv/linux/tile/tilegx/tilegx32/libm.abilist
+++ b/sysdeps/unix/sysv/linux/tile/tilegx/tilegx32/libm.abilist
@@ -5,7 +5,6 @@  GLIBC_2.12 __clog10f F
  GLIBC_2.12 __clog10l F
  GLIBC_2.12 __finite F
  GLIBC_2.12 __finitef F
-GLIBC_2.12 __finitel F
  GLIBC_2.12 __fpclassify F
  GLIBC_2.12 __fpclassifyf F
  GLIBC_2.12 __signbit F
@@ -370,6 +369,7 @@  GLIBC_2.18 GLIBC_2.18 A
  GLIBC_2.18 __issignaling F
  GLIBC_2.18 __issignalingf F
  GLIBC_2.23 GLIBC_2.23 A
+GLIBC_2.23 __finitel F
  GLIBC_2.23 __signgam D 0x4
  GLIBC_2.23 lgamma F
  GLIBC_2.23 lgammaf F
diff --git a/sysdeps/unix/sysv/linux/tile/tilegx/tilegx64/libc.abilist b/sysdeps/unix/sysv/linux/tile/tilegx/tilegx64/libc.abilist
index f8377a0..eedd6a7 100644
--- a/sysdeps/unix/sysv/linux/tile/tilegx/tilegx64/libc.abilist
+++ b/sysdeps/unix/sysv/linux/tile/tilegx/tilegx64/libc.abilist
@@ -182,7 +182,6 @@  GLIBC_2.12 __fgetws_chk F
  GLIBC_2.12 __fgetws_unlocked_chk F
  GLIBC_2.12 __finite F
  GLIBC_2.12 __finitef F
-GLIBC_2.12 __finitel F
  GLIBC_2.12 __flbf F
  GLIBC_2.12 __fork F
  GLIBC_2.12 __fpending F
@@ -228,11 +227,9 @@  GLIBC_2.12 __isdigit_l F
  GLIBC_2.12 __isgraph_l F
  GLIBC_2.12 __isinf F
  GLIBC_2.12 __isinff F
-GLIBC_2.12 __isinfl F
  GLIBC_2.12 __islower_l F
  GLIBC_2.12 __isnan F
  GLIBC_2.12 __isnanf F
-GLIBC_2.12 __isnanl F
  GLIBC_2.12 __isoc99_fscanf F
  GLIBC_2.12 __isoc99_fwscanf F
  GLIBC_2.12 __isoc99_scanf F
@@ -2092,6 +2089,9 @@  GLIBC_2.18 __cxa_thread_atexit_impl F
  GLIBC_2.22 GLIBC_2.22 A
  GLIBC_2.22 fmemopen F
  GLIBC_2.23 GLIBC_2.23 A
+GLIBC_2.23 __finitel F
+GLIBC_2.23 __isinfl F
+GLIBC_2.23 __isnanl F
  GLIBC_2.23 fts64_children F
  GLIBC_2.23 fts64_close F
  GLIBC_2.23 fts64_open F
diff --git a/sysdeps/unix/sysv/linux/tile/tilegx/tilegx64/libm.abilist b/sysdeps/unix/sysv/linux/tile/tilegx/tilegx64/libm.abilist
index 9ba58e2..9ef03e5 100644
--- a/sysdeps/unix/sysv/linux/tile/tilegx/tilegx64/libm.abilist
+++ b/sysdeps/unix/sysv/linux/tile/tilegx/tilegx64/libm.abilist
@@ -5,7 +5,6 @@  GLIBC_2.12 __clog10f F
  GLIBC_2.12 __clog10l F
  GLIBC_2.12 __finite F
  GLIBC_2.12 __finitef F
-GLIBC_2.12 __finitel F
  GLIBC_2.12 __fpclassify F
  GLIBC_2.12 __fpclassifyf F
  GLIBC_2.12 __signbit F
@@ -370,6 +369,7 @@  GLIBC_2.18 GLIBC_2.18 A
  GLIBC_2.18 __issignaling F
  GLIBC_2.18 __issignalingf F
  GLIBC_2.23 GLIBC_2.23 A
+GLIBC_2.23 __finitel F
  GLIBC_2.23 __signgam D 0x4
  GLIBC_2.23 lgamma F
  GLIBC_2.23 lgammaf F
diff --git a/sysdeps/unix/sysv/linux/tile/tilepro/libc.abilist b/sysdeps/unix/sysv/linux/tile/tilepro/libc.abilist
index 152adb0..d902a9c 100644
--- a/sysdeps/unix/sysv/linux/tile/tilepro/libc.abilist
+++ b/sysdeps/unix/sysv/linux/tile/tilepro/libc.abilist
@@ -182,7 +182,6 @@  GLIBC_2.12 __fgetws_chk F
  GLIBC_2.12 __fgetws_unlocked_chk F
  GLIBC_2.12 __finite F
  GLIBC_2.12 __finitef F
-GLIBC_2.12 __finitel F
  GLIBC_2.12 __flbf F
  GLIBC_2.12 __fork F
  GLIBC_2.12 __fpending F
@@ -228,11 +227,9 @@  GLIBC_2.12 __isdigit_l F
  GLIBC_2.12 __isgraph_l F
  GLIBC_2.12 __isinf F
  GLIBC_2.12 __isinff F
-GLIBC_2.12 __isinfl F
  GLIBC_2.12 __islower_l F
  GLIBC_2.12 __isnan F
  GLIBC_2.12 __isnanf F
-GLIBC_2.12 __isnanl F
  GLIBC_2.12 __isoc99_fscanf F
  GLIBC_2.12 __isoc99_fwscanf F
  GLIBC_2.12 __isoc99_scanf F
@@ -2092,6 +2089,9 @@  GLIBC_2.18 __cxa_thread_atexit_impl F
  GLIBC_2.22 GLIBC_2.22 A
  GLIBC_2.22 fmemopen F
  GLIBC_2.23 GLIBC_2.23 A
+GLIBC_2.23 __finitel F
+GLIBC_2.23 __isinfl F
+GLIBC_2.23 __isnanl F
  GLIBC_2.23 fts64_children F
  GLIBC_2.23 fts64_close F
  GLIBC_2.23 fts64_open F
diff --git a/sysdeps/unix/sysv/linux/tile/tilepro/libm.abilist b/sysdeps/unix/sysv/linux/tile/tilepro/libm.abilist
index 9ba58e2..9ef03e5 100644
--- a/sysdeps/unix/sysv/linux/tile/tilepro/libm.abilist
+++ b/sysdeps/unix/sysv/linux/tile/tilepro/libm.abilist
@@ -5,7 +5,6 @@  GLIBC_2.12 __clog10f F
  GLIBC_2.12 __clog10l F
  GLIBC_2.12 __finite F
  GLIBC_2.12 __finitef F
-GLIBC_2.12 __finitel F
  GLIBC_2.12 __fpclassify F
  GLIBC_2.12 __fpclassifyf F
  GLIBC_2.12 __signbit F
@@ -370,6 +369,7 @@  GLIBC_2.18 GLIBC_2.18 A
  GLIBC_2.18 __issignaling F
  GLIBC_2.18 __issignalingf F
  GLIBC_2.23 GLIBC_2.23 A
+GLIBC_2.23 __finitel F
  GLIBC_2.23 __signgam D 0x4
  GLIBC_2.23 lgamma F
  GLIBC_2.23 lgammaf F