From patchwork Fri Sep 4 09:36:32 2015 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Florian Weimer X-Patchwork-Id: 8575 Received: (qmail 13442 invoked by alias); 4 Sep 2015 09:36:48 -0000 Mailing-List: contact libc-alpha-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Unsubscribe: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: libc-alpha-owner@sourceware.org Delivered-To: mailing list libc-alpha@sourceware.org Received: (qmail 13433 invoked by uid 89); 4 Sep 2015 09:36:47 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-2.2 required=5.0 tests=AWL, BAYES_00, KAM_LAZY_DOMAIN_SECURITY, RP_MATCHES_RCVD, SPF_HELO_PASS autolearn=no version=3.3.2 X-HELO: mx1.redhat.com Subject: Re: [PATCH][BZ #18778] Clear DF_1_NODELETE flag only for dlopen failed library. To: Maxim Ostapenko , "H.J. Lu" References: <54BD4F65.2090108@samsung.com> <5565C2A8.60306@samsung.com> <5565C862.1040003@samsung.com> <5566395A.3090605@samsung.com> <5567892C.4070004@samsung.com> <5568A408.2080903@samsung.com> <5592AB91.2050709@samsung.com> <5595C0F8.3060300@samsung.com> <559B829C.8080700@samsung.com> <559BFDDC.4010604@samsung.com> <55C4D58D.8010307@partner.samsung.com> <55C89171.8090307@partner.samsung.com> <55E96349.6070708@redhat.com> <55E9651C.4030701@partner.samsung.com> Cc: Andreas Schwab , Pavel Kopyl , Yury Gribov , Roland McGrath , GNU C Library , "Carlos O'Donell" , Viacheslav Garbuzov From: Florian Weimer Message-ID: <55E96620.9060109@redhat.com> Date: Fri, 4 Sep 2015 11:36:32 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.1.0 MIME-Version: 1.0 In-Reply-To: <55E9651C.4030701@partner.samsung.com> On 09/04/2015 11:32 AM, Maxim Ostapenko wrote: > On 04/09/15 12:24, Florian Weimer wrote: >> On 08/10/2015 01:56 PM, Maxim Ostapenko wrote: >> >>> This patch fixes BZ #18778 issue by moving l->l_flags_1 &= >>> ~DF_1_NODELETE out of loop through all loaded libraries and performs >>> this action only on inconsistent one. >>> >>> No regressions on x86_64-unknown-linux-gnu, testcase is attached, OK for >>> master? >> This patch deletes elf/tst-znodelete-zlib.cc. Is this intentional? >> >> > > Yeah, according to this Andreas's comment, I've deleted it. > >>> Pavel Kopyl writes: >>> elf/tst-znodelete-zlib.cc | 6 +++++ > >> That file is not used anywhere. > >> Andreas. > > Perhaps I just forgot to mention this in CL and commit message. Did you > meet some problem here? No, I just noticed the ChangeLog inconsistency. I've committed the attached patch to address that. From f834e6dc705c80550acf610d507b3e4cdf19693e Mon Sep 17 00:00:00 2001 Message-Id: From: Florian Weimer Date: Fri, 4 Sep 2015 11:35:02 +0200 Subject: [PATCH] Amend ChangeLog to reflect deletion of elf/tst-znodelete-zlib.cc To: libc-alpha@sourceware.org Commit f25238ffe0455013174438376b3ee88df496f9d1 deleted this file because it was noted during review that it was unused. --- ChangeLog | 1 + 1 file changed, 1 insertion(+) diff --git a/ChangeLog b/ChangeLog index 14407f1..ab0031d 100644 --- a/ChangeLog +++ b/ChangeLog @@ -1462,6 +1462,7 @@ out of loop through all loaded libraries. * elf/tst-nodelete2.c: New file. * elf/tst-nodelete2mod.c: Likewise. + * elf/tst-znodelete-zlib.cc: Delete. 2015-08-11 Andreas Schwab -- 2.4.3