diff mbox

[BZ,#18778] Clear DF_1_NODELETE flag only for dlopen failed library.

Message ID 55E96620.9060109@redhat.com
State Committed
Headers

Commit Message

Florian Weimer Sept. 4, 2015, 9:36 a.m. UTC 
  On 09/04/2015 11:32 AM, Maxim Ostapenko wrote:
> On 04/09/15 12:24, Florian Weimer wrote:
>> On 08/10/2015 01:56 PM, Maxim Ostapenko wrote:
>>
>>> This patch fixes BZ #18778 issue by moving l->l_flags_1 &=
>>> ~DF_1_NODELETE out of loop through all loaded libraries and performs
>>> this action only on inconsistent one.
>>>
>>> No regressions on x86_64-unknown-linux-gnu, testcase is attached, OK for
>>> master?
>> This patch deletes elf/tst-znodelete-zlib.cc.  Is this intentional?
>>
>>
> 
> Yeah, according to this Andreas's comment, I've deleted it.
> 
>>> Pavel Kopyl <p.kopyl@samsung.com> writes:
>>>   elf/tst-znodelete-zlib.cc     |    6 +++++
> 
>> That file is not used anywhere.
> 
>> Andreas.
> 
> Perhaps I just forgot to mention this in CL and commit message. Did you
> meet some problem here?

No, I just noticed the ChangeLog inconsistency.  I've committed the
attached patch to address that.

Comments

Maxim Ostapenko Sept. 4, 2015, 9:39 a.m. UTC | #1 
On 04/09/15 12:36, Florian Weimer wrote:
> On 09/04/2015 11:32 AM, Maxim Ostapenko wrote:
>> On 04/09/15 12:24, Florian Weimer wrote:
>>> On 08/10/2015 01:56 PM, Maxim Ostapenko wrote:
>>>
>>>> This patch fixes BZ #18778 issue by moving l->l_flags_1 &=
>>>> ~DF_1_NODELETE out of loop through all loaded libraries and performs
>>>> this action only on inconsistent one.
>>>>
>>>> No regressions on x86_64-unknown-linux-gnu, testcase is attached, OK for
>>>> master?
>>> This patch deletes elf/tst-znodelete-zlib.cc.  Is this intentional?
>>>
>>>
>> Yeah, according to this Andreas's comment, I've deleted it.
>>
>>>> Pavel Kopyl <p.kopyl@samsung.com> writes:
>>>>    elf/tst-znodelete-zlib.cc     |    6 +++++
>>> That file is not used anywhere.
>>> Andreas.
>> Perhaps I just forgot to mention this in CL and commit message. Did you
>> meet some problem here?
> No, I just noticed the ChangeLog inconsistency.  I've committed the
> attached patch to address that.
>

Oh, sorry for inconvenience. Thanks!
diff mbox

Patch

From f834e6dc705c80550acf610d507b3e4cdf19693e Mon Sep 17 00:00:00 2001
Message-Id: <f834e6dc705c80550acf610d507b3e4cdf19693e.1441359340.git.fweimer@redhat.com>
From: Florian Weimer <fweimer@redhat.com>
Date: Fri, 4 Sep 2015 11:35:02 +0200
Subject: [PATCH] Amend ChangeLog to reflect deletion of
 elf/tst-znodelete-zlib.cc
To: libc-alpha@sourceware.org

Commit f25238ffe0455013174438376b3ee88df496f9d1 deleted this file
because it was noted during review that it was unused.
---
 ChangeLog | 1 +
 1 file changed, 1 insertion(+)

diff --git a/ChangeLog b/ChangeLog
index 14407f1..ab0031d 100644
--- a/ChangeLog
+++ b/ChangeLog
@@ -1462,6 +1462,7 @@ 
 	out of loop through all loaded libraries.
 	* elf/tst-nodelete2.c: New file.
 	* elf/tst-nodelete2mod.c: Likewise.
+	* elf/tst-znodelete-zlib.cc: Delete.
 
 2015-08-11  Andreas Schwab  <schwab@suse.de>
 
-- 
2.4.3