From patchwork Mon May 11 11:18:03 2015 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Marko Myllynen X-Patchwork-Id: 6663 Received: (qmail 62674 invoked by alias); 11 May 2015 11:18:11 -0000 Mailing-List: contact libc-alpha-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Unsubscribe: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: libc-alpha-owner@sourceware.org Delivered-To: mailing list libc-alpha@sourceware.org Received: (qmail 62662 invoked by uid 89); 11 May 2015 11:18:10 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-2.0 required=5.0 tests=AWL, BAYES_00, SPF_HELO_PASS, SPF_PASS, T_RP_MATCHES_RCVD autolearn=ham version=3.3.2 X-HELO: mx1.redhat.com Message-ID: <55508FEB.8010903@redhat.com> Date: Mon, 11 May 2015 14:18:03 +0300 From: Marko Myllynen Reply-To: myllynen@redhat.com User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:24.0) Gecko/20100101 Thunderbird/24.6.0 MIME-Version: 1.0 To: "Carlos O'Donell" , Mjbmr , libc-alpha@sourceware.org Subject: Re: [PATCH][BZ 14172] Add South Azerbaijani (azb) locale References: <554AF03A.2010601@gmail.com> <554B2148.3090707@redhat.com> <554BF472.8050703@gmail.com> <554BFC89.1060003@gmail.com> <554C78C5.2060708@redhat.com> <554CD3B4.9050304@redhat.com> In-Reply-To: <554CD3B4.9050304@redhat.com> Hi Carlos, On 2015-05-08 18:18, Carlos O'Donell wrote: > On 05/08/2015 04:50 AM, Marko Myllynen wrote: >> >> looks pretty good to me. Again, I can't comment on the language itself >> but if it now compiles then at least the basics should be ok. > > How do we want to handle this patch? Should we just check in as a new > supported localization? I feel like the answer should be "Yes." Then > the downstream distributions can enable it if they see fit, and we can > start getting feedback from real azb users about the quality of the > locale itself. yes, agreed. > Thoughts? Do you have commit privileges to check this in? Do you want > them? It would require at least doing a quick glibc build to validate > the locale works before committing :-) Could you please commit it (I don't have privileges)? I did a quick glibc build and it was a worthwhile effort - the locale itself is now ok but I needed to adjust the Locales wiki page a bit for cases where a new language code is used and also noticed that when doing "make localedata/install-locales install_root=..." it doesn't halt on errors, that's probably why we have bo_CN and bo_IN in the tree which don't compile. Not sure is not halting on errors wanted or not but below is a quick&dirty patch to fix the compilation issues. 2015-05-11 Marko Myllynen * locales/bo_CN (LC_NAME): Fix compilation. * locales/bo_IN (LC_NAME): Likewise. --- localedata/locales/bo_CN | 2 +- localedata/locales/bo_IN | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/localedata/locales/bo_CN b/localedata/locales/bo_CN index d813c10..8c866ab 100644 --- a/localedata/locales/bo_CN +++ b/localedata/locales/bo_CN @@ -146,7 +146,7 @@ END LC_MEASUREMENT LC_NAME % FIXME -name_fmt "" +name_fmt " " % name_gen "FIXME" % name_miss "FIXME" % name_mr "FIXME" diff --git a/localedata/locales/bo_IN b/localedata/locales/bo_IN index 8ab793c..b396ee1 100644 --- a/localedata/locales/bo_IN +++ b/localedata/locales/bo_IN @@ -71,7 +71,7 @@ END LC_MEASUREMENT LC_NAME % FIXME -name_fmt "" +name_fmt " " % name_gen "FIXME" % name_miss "FIXME" % name_mr "FIXME"