From patchwork Fri Apr 24 09:11:26 2015 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Florian Weimer X-Patchwork-Id: 6418 Received: (qmail 46798 invoked by alias); 24 Apr 2015 09:11:31 -0000 Mailing-List: contact libc-alpha-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Unsubscribe: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: libc-alpha-owner@sourceware.org Delivered-To: mailing list libc-alpha@sourceware.org Received: (qmail 46779 invoked by uid 89); 24 Apr 2015 09:11:30 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-2.8 required=5.0 tests=AWL, BAYES_00, SPF_HELO_PASS, SPF_PASS, T_RP_MATCHES_RCVD autolearn=ham version=3.3.2 X-HELO: mx1.redhat.com Message-ID: <553A08BE.4040700@redhat.com> Date: Fri, 24 Apr 2015 11:11:26 +0200 From: Florian Weimer User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.6.0 MIME-Version: 1.0 To: GNU C Library Subject: [PATCH] Do not build with -Winline Per the previous discussion. From 69372f19d39ac6cf3570cbf62ae4610a26c15e41 Mon Sep 17 00:00:00 2001 From: Florian Weimer Date: Fri, 24 Apr 2015 11:10:24 +0200 Subject: [PATCH] Do not build with -Winline -Winline causes architecture- and optimization-dependent build failures due to -Werror. -Winline warns about inlining decisions based on branch hints, in effect preventing the use of inline functions in header files (because they might be called on unlikely branches, leading to a decision not to inline). The option was apparently added to the glibc build at a time when GCC did not support the always_inline attribute. With current GCC versions, inlining failure for functions declared always_inline will receive a warning under -Wattributes, which is enabled by default, so -Winline appears unnecessary. --- ChangeLog | 4 ++++ Makeconfig | 4 ++-- 2 files changed, 6 insertions(+), 2 deletions(-) diff --git a/ChangeLog b/ChangeLog index 2c01eac..ace5fb3 100644 --- a/ChangeLog +++ b/ChangeLog @@ -1,3 +1,7 @@ +2015-04-24 Florian Weimer + + * Makeconfig (+gccwarn): Remove -Winline. + 2015-04-22 Wilco Dijkstra * math/k_casinh.c (__kernel_casinh): Use __copysign. diff --git a/Makeconfig b/Makeconfig index dc7f208..77752c0 100644 --- a/Makeconfig +++ b/Makeconfig @@ -739,9 +739,9 @@ endif # Extra flags to pass to GCC. ifeq ($(all-warnings),yes) -+gccwarn := -Wall -Wwrite-strings -Winline -Wcast-qual -Wbad-function-cast -Wmissing-noreturn -Wmissing-prototypes -Wmissing-declarations -Wcomment -Wcomments -Wtrigraphs -Wsign-compare -Wfloat-equal -Wmultichar ++gccwarn := -Wall -Wwrite-strings -Wcast-qual -Wbad-function-cast -Wmissing-noreturn -Wmissing-prototypes -Wmissing-declarations -Wcomment -Wcomments -Wtrigraphs -Wsign-compare -Wfloat-equal -Wmultichar else -+gccwarn := -Wall -Wwrite-strings -Winline ++gccwarn := -Wall -Wwrite-strings endif +gccwarn += -Wundef ifeq ($(enable-werror),yes) -- 2.1.0