From patchwork Thu Mar 5 10:12:15 2015 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Szabolcs Nagy X-Patchwork-Id: 5469 Received: (qmail 102067 invoked by alias); 5 Mar 2015 10:12:21 -0000 Mailing-List: contact libc-alpha-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Unsubscribe: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: libc-alpha-owner@sourceware.org Delivered-To: mailing list libc-alpha@sourceware.org Received: (qmail 102041 invoked by uid 89); 5 Mar 2015 10:12:20 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-1.9 required=5.0 tests=AWL, BAYES_00, SPF_PASS autolearn=ham version=3.3.2 X-HELO: service87.mimecast.com Message-ID: <54F82BFF.40209@arm.com> Date: Thu, 05 Mar 2015 10:12:15 +0000 From: Szabolcs Nagy User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.5.0 MIME-Version: 1.0 To: libc-alpha@sourceware.org CC: Marcus Shawcroft Subject: [PATCH][aarch64] fix inline asm clobber list in tls-macros.h X-MC-Unique: 115030510121605901 AArch64 TLS_GD macro calls __tlsget_addr from inline asm, because the exact TLS instruction sequence matters, but cc was not on the clobber list so elf/tst-tlsmod2.so was miscompiled and thus elf/tst-tls4 and elf/tst-tls-dlinfo tests failed. It seems tls-macros.h is only used in tests. Is this patch ok? Changelog: 2015-03-05 Szabolcs Nagy * sysdeps/aarch64/tls-macros.h (TLS_GD): Add "cc" to the clobber list. diff --git a/sysdeps/aarch64/tls-macros.h b/sysdeps/aarch64/tls-macros.h index 07d02eb..8142185 100644 --- a/sysdeps/aarch64/tls-macros.h +++ b/sysdeps/aarch64/tls-macros.h @@ -29,7 +29,7 @@ : "x1", "x2", "x3", "x4", "x5", "x6", \ "x7", "x8", "x9", "x10", "x11", "x12", \ "x13", "x14", "x15", "x16", "x17", "x18", \ - "x30", "memory"); \ + "x30", "memory", "cc"); \ (int *) (__result); }) #define TLS_IE(x) \