From patchwork Tue Dec 23 15:20:01 2014
Content-Type: text/plain; charset="utf-8"
MIME-Version: 1.0
Content-Transfer-Encoding: 7bit
X-Patchwork-Submitter: Florian Weimer <fweimer@redhat.com>
X-Patchwork-Id: 4410
Received: (qmail 13475 invoked by alias); 23 Dec 2014 15:20:07 -0000
Mailing-List: contact libc-alpha-help@sourceware.org; run by ezmlm
Precedence: bulk
List-Id: <libc-alpha.sourceware.org>
List-Unsubscribe: <mailto:libc-alpha-unsubscribe-##L=##H@sourceware.org>
List-Subscribe: <mailto:libc-alpha-subscribe@sourceware.org>
List-Archive: <http://sourceware.org/ml/libc-alpha/>
List-Post: <mailto:libc-alpha@sourceware.org>
List-Help: <mailto:libc-alpha-help@sourceware.org>,
	<http://sourceware.org/ml/#faqs>
Sender: libc-alpha-owner@sourceware.org
Delivered-To: mailing list libc-alpha@sourceware.org
Received: (qmail 13463 invoked by uid 89); 23 Dec 2014 15:20:06 -0000
Authentication-Results: sourceware.org; auth=none
X-Virus-Found: No
X-Spam-SWARE-Status: No, score=-3.1 required=5.0 tests=AWL, BAYES_00,
	SPF_HELO_PASS, SPF_PASS,
	T_RP_MATCHES_RCVD autolearn=ham version=3.3.2
X-HELO: mx1.redhat.com
Message-ID: <54998821.2020102@redhat.com>
Date: Tue, 23 Dec 2014 16:20:01 +0100
From: Florian Weimer <fweimer@redhat.com>
User-Agent: Mozilla/5.0 (X11; Linux x86_64;
	rv:31.0) Gecko/20100101 Thunderbird/31.3.0
MIME-Version: 1.0
To: GNU C Library <libc-alpha@sourceware.org>
CC: Arjun Shankar <ashankar@redhat.com>
Subject: [COMITTTED] iconvdata/run-iconv-test.sh: Actually test iconv modules

Arjun Shankar noticed that this test case was not testing anything 
because iconv was invoked without the required arguments.

2014-12-23  Florian Weimer  <fweimer@redhat.com>

	* iconvdata/run-iconv-test.sh: Actually test iconv modules.

diff --git a/iconvdata/run-iconv-test.sh b/iconvdata/run-iconv-test.sh
index 5dfb69f..1d0bf52 100755
--- a/iconvdata/run-iconv-test.sh
+++ b/iconvdata/run-iconv-test.sh
@@ -189,7 +189,7 @@ printf '\016\377\377\377\377\377\377\377' > $temp1
 for from in $iconv_modules ; do
     echo $ac_n "test decoder $from $ac_c"
     PROG=`eval echo $ICONV`
-    if $PROG < $temp1 >/dev/null 2>&1 ; then
+    if $PROG -f $from -t UTF8 < $temp1 >/dev/null 2>&1 ; then
 	: # fall through
     else
 	status=$?