From patchwork Thu Dec 11 15:41:55 2014 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: Stefan Liebler X-Patchwork-Id: 4182 Received: (qmail 11661 invoked by alias); 11 Dec 2014 15:42:16 -0000 Mailing-List: contact libc-alpha-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Unsubscribe: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: libc-alpha-owner@sourceware.org Delivered-To: mailing list libc-alpha@sourceware.org Received: (qmail 11648 invoked by uid 89); 11 Dec 2014 15:42:15 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-2.5 required=5.0 tests=AWL, BAYES_00, RCVD_IN_DNSWL_LOW, SPF_HELO_PASS, SPF_PASS, T_RP_MATCHES_RCVD autolearn=ham version=3.3.2 X-HELO: plane.gmane.org To: libc-alpha@sourceware.org From: Stefan Liebler Subject: [PATCH] Get rid of warning inlining failed in call to maybe_swap_uint32 Date: Thu, 11 Dec 2014 16:41:55 +0100 Lines: 49 Message-ID: <5489BB43.5070003@linux.vnet.ibm.com> Mime-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.2.0 Hi, this patch disables warning/error: In file included from programs/locarchive.c:49:0: programs/locarchive.c: In function ‘add_locale’: programs/locfile.h:85:1: warning: inlining failed in call to ‘maybe_swap_uint32’: call is unlikely and code size would grow [-Winline] programs/locarchive.c:981:12: warning: called from here [-Winline] The function maybe_swap_uint32 isn´t marked as inline anymore, which avoids the inlining warning. The unused attribute was added due to the inclusion of locfile.h in linereader.c, which does not use maybe_swap_uint32 function. Tested on s390. Ok to commit? Bye Stefan --- 2014-12-11 Stefan Liebler locale/programs/locfile.h (maybe_swap_uint32): Remove inline and add unused attribute. diff --git a/locale/programs/locfile.h b/locale/programs/locfile.h index b579a46..dd00c0d 100644 --- a/locale/programs/locfile.h +++ b/locale/programs/locfile.h @@ -81,7 +81,8 @@ set_big_endian (bool big_endian) /* Munge VALUE so that, when stored, it has the correct byte order for the output files. */ -static inline uint32_t +static uint32_t +__attribute__ ((unused)) maybe_swap_uint32 (uint32_t value) { return swap_endianness_p ? bswap_32 (value) : value;