From patchwork Wed Dec 10 18:29:55 2014 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Adhemerval Zanella Netto X-Patchwork-Id: 4152 X-Patchwork-Delegate: azanella@linux.vnet.ibm.com Received: (qmail 6725 invoked by alias); 10 Dec 2014 18:30:08 -0000 Mailing-List: contact libc-alpha-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Unsubscribe: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: libc-alpha-owner@sourceware.org Delivered-To: mailing list libc-alpha@sourceware.org Received: (qmail 6685 invoked by uid 89); 10 Dec 2014 18:30:07 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-2.1 required=5.0 tests=AWL, BAYES_00, T_RP_MATCHES_RCVD autolearn=ham version=3.3.2 X-HELO: e24smtp05.br.ibm.com Message-ID: <54889123.2030608@linux.vnet.ibm.com> Date: Wed, 10 Dec 2014 16:29:55 -0200 From: Adhemerval Zanella User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:24.0) Gecko/20100101 Thunderbird/24.5.0 MIME-Version: 1.0 To: libc-alpha@sourceware.org Subject: Re: -Werror now enabled by default References: In-Reply-To: X-TM-AS-MML: disable X-Content-Scanned: Fidelis XPS MAILER x-cbid: 14121018-0033-0000-0000-0000013F338E On 10-12-2014 14:24, Joseph Myers wrote: > On Wed, 10 Dec 2014, Andreas Schwab wrote: > >> In other words, you are forcing everyone to use --disable-werror now. > That's the opposite of what I said. By "warning suppression" I mean use > of the DIAG_* macros, not --disable-werror. > Something like that: I still trying to figure out why the test for MAXLGM is necessary (it seems redundant to me, since for overflow it will be generate by the log call itself). Anyway, I know this is not the perfect solution, but I would like to make powerpc builds cleanly without resorting in --disable-werror. diff --git a/sysdeps/ieee754/ldbl-128/e_lgammal_r.c b/sysdeps/ieee754/ldbl-128/e_lgammal_r.c index 1961355..641cfd6 100644 --- a/sysdeps/ieee754/ldbl-128/e_lgammal_r.c +++ b/sysdeps/ieee754/ldbl-128/e_lgammal_r.c @@ -70,12 +70,16 @@ #include #include +#include +DIAG_PUSH_NEEDS_COMMENT; +DIAG_IGNORE_NEEDS_COMMENT (4.6, "-Woverflow"); static const long double PIL = 3.1415926535897932384626433832795028841972E0L; static const long double MAXLGM = 1.0485738685148938358098967157129705071571E4928L; static const long double one = 1.0L; static const long double zero = 0.0L; static const long double huge = 1.0e4000L; +DIAG_POP_NEEDS_COMMENT; /* log gamma(x) = ( x - 0.5 ) * log(x) - x + LS2PI + 1/x P(1/x^2) 1/x <= 0.0741 (x >= 13.495...)