From patchwork Wed Jul 2 06:57:00 2014 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Carlos O'Donell X-Patchwork-Id: 1846 Received: (qmail 6020 invoked by alias); 2 Jul 2014 06:57:10 -0000 Mailing-List: contact libc-alpha-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Unsubscribe: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: libc-alpha-owner@sourceware.org Delivered-To: mailing list libc-alpha@sourceware.org Received: (qmail 5957 invoked by uid 89); 2 Jul 2014 06:57:07 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-1.3 required=5.0 tests=AWL, BAYES_50, SPF_HELO_PASS, SPF_PASS, T_RP_MATCHES_RCVD autolearn=ham version=3.3.2 X-HELO: mx1.redhat.com Message-ID: <53B3AD3C.6020602@redhat.com> Date: Wed, 02 Jul 2014 02:57:00 -0400 From: "Carlos O'Donell" User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:24.0) Gecko/20100101 Thunderbird/24.5.0 MIME-Version: 1.0 To: GNU C Library Subject: Re: [COMMITTED] hppa: Add ABI baselines. References: <53B37F88.4060308@redhat.com> In-Reply-To: <53B37F88.4060308@redhat.com> On 07/01/2014 11:42 PM, Carlos O'Donell wrote: > Secondly, aio_cancel and aio_cancel64 previously had a compat symbol > at version @GLIBC_2.1 with a new symbol at @@GLIBC_2.3[1]. During the > Linuxthreads to NPTL transition the file aio_cancel.c was lost for hppa > and that resulted in just @@GLIBC_2.1 versions of these symbols being > exported. The @@GLIBC_2.1 version works correctly and uses the right > value of ECANCELLED. Therefore if I were to fix this today it might > break correctly working applications using aio_cancel*@GLIBC_2.1 by > causing those to use the old aio_cancel that used the older value > of ECANCELLED. Thus the best option is to accept that the ABI changed > and ignore older applications in favour of newer applications. The > best thing to do is cleanup the version files (included in the patch). This is the final commit that fixes the librt ABI checking. I cleaned up the Versions file but failed to merge in this commit which removed the GLIBC_2.3 entries we no longer use. This commit fixes that. A `make check-abi` run for hppa has no errors. 2014-07-01 Carlos O'Donell * sysdeps/unix/sysv/linux/hppa/librt.abilist: Remove GLIBC_2.3 entries. --- Cheers, Carlos. diff --git a/sysdeps/unix/sysv/linux/hppa/librt.abilist b/sysdeps/unix/sysv/linux/hppa/librt.abilist index b2a5f2d..af7df27 100644 --- a/sysdeps/unix/sysv/linux/hppa/librt.abilist +++ b/sysdeps/unix/sysv/linux/hppa/librt.abilist @@ -31,10 +31,6 @@ GLIBC_2.2 timer_getoverrun F timer_gettime F timer_settime F -GLIBC_2.3 - GLIBC_2.3 A - aio_cancel F - aio_cancel64 F GLIBC_2.3.4 GLIBC_2.3.4 A mq_close F