From patchwork Wed May 28 15:15:24 2014 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Marko Myllynen X-Patchwork-Id: 1183 Received: (qmail 1005 invoked by alias); 28 May 2014 15:15:35 -0000 Mailing-List: contact libc-alpha-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Unsubscribe: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: libc-alpha-owner@sourceware.org Delivered-To: mailing list libc-alpha@sourceware.org Received: (qmail 969 invoked by uid 89); 28 May 2014 15:15:32 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-2.6 required=5.0 tests=AWL, BAYES_00, RP_MATCHES_RCVD, SPF_HELO_PASS, SPF_PASS autolearn=ham version=3.3.2 X-Spam-User: qpsmtpd, 2 recipients X-HELO: mx1.redhat.com Message-ID: <5385FD8C.2060400@redhat.com> Date: Wed, 28 May 2014 18:15:24 +0300 From: Marko Myllynen Reply-To: myllynen@redhat.com User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:24.0) Gecko/20100101 Thunderbird/24.4.0 MIME-Version: 1.0 To: mtk.manpages@gmail.com CC: Petr Baudis , GNU C Library , linux-man , libc-locales@sourceware.org Subject: Re: [PATCH] locale.5: document glibc conventions regarding days and week References: <5382D64A.9020404@redhat.com> <5385F087.2060602@redhat.com> <5385F92F.5040301@redhat.com> In-Reply-To: Hi, On 2014-05-28 18:03, Michael Kerrisk (man-pages) wrote: > On Wed, May 28, 2014 at 4:56 PM, Marko Myllynen wrote: >> On 2014-05-28 17:30, Michael Kerrisk (man-pages) wrote: >>> On Wed, May 28, 2014 at 4:19 PM, Marko Myllynen wrote: >>>> On 2014-05-28 14:54, Michael Kerrisk (man-pages) wrote: >>>>> >>>>> Looking at this patch more closely, there's a piece that seems to be broken. >>>>> >>>>> That sentence is garbled. Some words are missing, I think. Can you clarify? >>>> >>>> it was clumsy indeed, and also repetitive, I don't think it's needed at all >>>> as the previous paragraph already explains the same thing. >>>> >>>> Please see an updated and rebased patch below. >>> >>> Best just to tell me what needs to be dropped from the preceding >>> patch, since I've already merged and edited in a private branch. >> >> best to drop the sentence that was garbled. I'll double check it once it >> appears in a public branch. > > Done. And now the changes are published in Git. thanks, looks good, I'd add this tiny change to be explicit rather than implicit. From 4d8d8552aaf67f56278d1d8b90c88e531bfd111e Mon Sep 17 00:00:00 2001 From: Marko Myllynen Date: Wed, 28 May 2014 18:11:55 +0300 Subject: [PATCH] locale.5: minor NOTES clarification --- man5/locale.5 | 16 ++++++++++++---- 1 files changed, 12 insertions(+), 4 deletions(-) diff --git a/man5/locale.5 b/man5/locale.5 index d762858..572833d 100644 --- a/man5/locale.5 +++ b/man5/locale.5 @@ -1079,10 +1079,12 @@ Usual default path for locale definition files. POSIX.2, ISO/IEC TR 14652. .SH NOTES The collective GNU C library community wisdom regarding +.IR abday , .IR day , .IR week , +.IR first_weekday , and -.I first_weekday +.I first_workday states at https://sourceware.org/glibc/wiki/Locales the following: @@ -1090,13 +1092,17 @@ the following: The value of the second .I week list item specifies the base of the +.I abday +and .I day -list. +lists. .IP * .I first_weekday specifies the offset of the first day-of-week in the +.I abday +and .I day -list. +lists. .IP * For compatibility reasons, all glibc locales should set the value of the second @@ -1104,8 +1110,10 @@ second list item to .B 19971130 (Sunday) and base the +.I abday +and .I day -list appropriately, and set +lists appropriately, and set .I first_weekday to .B 1