From patchwork Fri May 9 12:13:06 2014 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Adhemerval Zanella Netto X-Patchwork-Id: 856 Return-Path: X-Original-To: siddhesh@wilcox.dreamhost.com Delivered-To: siddhesh@wilcox.dreamhost.com Received: from homiemail-mx23.g.dreamhost.com (mx2.sub5.homie.mail.dreamhost.com [208.113.200.128]) by wilcox.dreamhost.com (Postfix) with ESMTP id B93EE360098 for ; Fri, 9 May 2014 05:13:22 -0700 (PDT) Received: by homiemail-mx23.g.dreamhost.com (Postfix, from userid 14307373) id 656B8637F61B6; Fri, 9 May 2014 05:13:22 -0700 (PDT) X-Original-To: glibc@patchwork.siddhesh.in Delivered-To: x14307373@homiemail-mx23.g.dreamhost.com Received: from sourceware.org (server1.sourceware.org [209.132.180.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by homiemail-mx23.g.dreamhost.com (Postfix) with ESMTPS id 38E5C6380082E for ; Fri, 9 May 2014 05:13:22 -0700 (PDT) DomainKey-Signature: a=rsa-sha1; c=nofws; d=sourceware.org; h=list-id :list-unsubscribe:list-subscribe:list-archive:list-post :list-help:sender:message-id:date:from:mime-version:to:subject :content-type:content-transfer-encoding; q=dns; s=default; b=lww sjKBZoN1zo6t45Ekga0OstfiMXgSgp9SF1DKnCfVgFhesCH3GWtjB/HWGAgbZcMW aou4XpfTRXYQkljo1C0V83rdJ1YeLp0RSQNL0/Ktyzchj/eLDsue4LZKlD9B9DTH W5u+1TvebgzLkWFZbyuTkwPWk7sYRvATTUvZ/0Yg= DKIM-Signature: v=1; a=rsa-sha1; c=relaxed; d=sourceware.org; h=list-id :list-unsubscribe:list-subscribe:list-archive:list-post :list-help:sender:message-id:date:from:mime-version:to:subject :content-type:content-transfer-encoding; s=default; bh=XiG6OMrQc Yjd7/eYej8Jt8aXksM=; b=WHEjcJxE65Z/CAtMG2imdN/7R7KVg0L0lZL4zM2U+ MOGTRqaRKdPomBu4NYr/DhXA8G21AzIg/5b0LLKAGZzWP5chCMoYqy5QTFn21/tS +vHIPYOlGTo1oEokyhfwH51CYyHM4J8e2U40yDByp1A94Fiz77XLwmXP2jHfyiND GM= Received: (qmail 22355 invoked by alias); 9 May 2014 12:13:19 -0000 Mailing-List: contact libc-alpha-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Unsubscribe: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: libc-alpha-owner@sourceware.org Delivered-To: mailing list libc-alpha@sourceware.org Received: (qmail 22342 invoked by uid 89); 9 May 2014 12:13:18 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-2.4 required=5.0 tests=AWL, BAYES_00, RP_MATCHES_RCVD autolearn=ham version=3.3.2 X-HELO: e24smtp04.br.ibm.com Message-ID: <536CC652.9040607@linux.vnet.ibm.com> Date: Fri, 09 May 2014 09:13:06 -0300 From: Adhemerval Zanella User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:24.0) Gecko/20100101 Thunderbird/24.5.0 MIME-Version: 1.0 To: "GNU C. Library" Subject: [PATCH] Fix tst-tls9-static build X-TM-AS-MML: disable X-Content-Scanned: Fidelis XPS MAILER x-cbid: 14050912-1820-0000-0000-000000858622 X-DH-Original-To: glibc@patchwork.siddhesh.in Hi all, This patch fixes the tst-tlsmod[5/6].so build in system that uses -Wl,--as-needed as default in linker option. Without this option the testing shared library that does not have libc.so in DT_NEEDED and the tst-tls9-static fails in architecture that use the ./sysdeps/unix/sysv/linux//dl-static.c trick. Checked on powerpc64/powerpc64le. Ok to install? PS: Based on this I am reviewing the dl-static trick, since it seems it not really required on powerpc and I think based on newer kernel requirements that it might be true to other archs that use the same trick (aarch64, tile, ia64, m64k, and mips). --- * elf/Makefile (tst-tlsmod5.so): Add $(no-as-needed). (tst-tlsmod6.so): Likewise. --- diff --git a/elf/Makefile b/elf/Makefile index 3d675d7..084abca 100644 --- a/elf/Makefile +++ b/elf/Makefile @@ -521,8 +521,8 @@ LDFLAGS-tst-initordera2.so = $(no-as-needed) LDFLAGS-tst-initordera3.so = $(no-as-needed) LDFLAGS-tst-initordera4.so = $(no-as-needed) LDFLAGS-tst-initorderb2.so = $(no-as-needed) -LDFLAGS-tst-tlsmod5.so = -nostdlib -LDFLAGS-tst-tlsmod6.so = -nostdlib +LDFLAGS-tst-tlsmod5.so = -nostdlib $(no-as-needed) +LDFLAGS-tst-tlsmod6.so = -nostdlib $(no-as-needed) testobj1.so-no-z-defs = yes testobj3.so-no-z-defs = yes