From patchwork Fri Mar 21 18:31:53 2014 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Adhemerval Zanella Netto X-Patchwork-Id: 215 Return-Path: X-Original-To: siddhesh@wilcox.dreamhost.com Delivered-To: siddhesh@wilcox.dreamhost.com Received: from homiemail-mx20.g.dreamhost.com (caibbdcaaahc.dreamhost.com [208.113.200.72]) by wilcox.dreamhost.com (Postfix) with ESMTP id 8DD7836016D for ; Fri, 21 Mar 2014 11:32:06 -0700 (PDT) Received: by homiemail-mx20.g.dreamhost.com (Postfix, from userid 14307373) id 43C1440D61933; Fri, 21 Mar 2014 11:32:06 -0700 (PDT) X-Original-To: glibc@patchwork.siddhesh.in Delivered-To: x14307373@homiemail-mx20.g.dreamhost.com Received: from sourceware.org (server1.sourceware.org [209.132.180.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by homiemail-mx20.g.dreamhost.com (Postfix) with ESMTPS id 1D56040F88D3E for ; Fri, 21 Mar 2014 11:32:06 -0700 (PDT) DomainKey-Signature: a=rsa-sha1; c=nofws; d=sourceware.org; h=list-id :list-unsubscribe:list-subscribe:list-archive:list-post :list-help:sender:message-id:date:from:mime-version:to:subject :references:in-reply-to:content-type:content-transfer-encoding; q=dns; s=default; b=fSI8K0WbVy9J2xhmN2PXtQHGHKv9wa4JiaLncm7JFnv A6V6Y4/0HTrp8jyFms3euEP719ekG7GaKAQxaFMfa2q2nHvLYLRN6SEuSkPULBSq 8f9cba279eoE/Cz2VvHH7QRAo+rh4M5AGXeTUfPwkdWBfqXJKXMNHpJwHO/WiyvA = DKIM-Signature: v=1; a=rsa-sha1; c=relaxed; d=sourceware.org; h=list-id :list-unsubscribe:list-subscribe:list-archive:list-post :list-help:sender:message-id:date:from:mime-version:to:subject :references:in-reply-to:content-type:content-transfer-encoding; s=default; bh=7+WY3nXlLOHqFUUKrkpAOqqTjd4=; b=s5ZgYWs9/FfrbwBsj /CdfgLBCwOWz+/ynDDxI+08/vMKpCMzoagn6mkCpmZ2zD/rFAdrFM3sobVcmBA4F OKmMQLlsh2Ued6Zsagmfhv2gm98EhPiPY25DU2ZTDrO9h5eb6V42mH+duzPettOo zolV7LCG3AhTk7bfoJWbCc3zmY= Received: (qmail 3339 invoked by alias); 21 Mar 2014 18:32:04 -0000 Mailing-List: contact libc-alpha-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Unsubscribe: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: libc-alpha-owner@sourceware.org Delivered-To: mailing list libc-alpha@sourceware.org Received: (qmail 3322 invoked by uid 89); 21 Mar 2014 18:32:03 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-2.2 required=5.0 tests=AWL, BAYES_00, T_RP_MATCHES_RCVD autolearn=ham version=3.3.2 X-HELO: e24smtp03.br.ibm.com Message-ID: <532C8599.5010002@linux.vnet.ibm.com> Date: Fri, 21 Mar 2014 15:31:53 -0300 From: Adhemerval Zanella User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:24.0) Gecko/20100101 Thunderbird/24.3.0 MIME-Version: 1.0 To: libc-alpha@sourceware.org Subject: Re: [PATCH] Remove PRI_MACROS_BROKEN define usage References: <532B3168.2030108@linux.vnet.ibm.com> <532B3750.2030102@linux.vnet.ibm.com> <532B3F64.6030005@linux.vnet.ibm.com> <532B893B.5010709@linux.vnet.ibm.com> In-Reply-To: X-TM-AS-MML: disable X-Content-Scanned: Fidelis XPS MAILER x-cbid: 14032118-9564-0000-0000-00000066CBCE X-DH-Original-To: glibc@patchwork.siddhesh.in On 20-03-2014 21:43, Joseph S. Myers wrote: > On Thu, 20 Mar 2014, Adhemerval Zanella wrote: > >>> Any change brought from gettext would best be committed on its own >>> (ideally with the original author of that change in gettext being >>> credited). >>> >> The changes I have incorporated on the patch is just change the old K&R >> function prototype to ISO C, remove and superfluous ';' and change a >> free call to remove an unnecessary cast. For these straightforward patches >> do we really need to track the ones how made then and commit a set of >> patches? > You could probably just say "Change merged from gettext." or similar > without detailed attribution - but a change coming from gettext should > still be committed separately from a change not coming from gettext. > Fair enough, he it is the patch to correct just the PRI_MACROS_BROKEN. I will send a sync one later. --- * intl/loadmsgcat.c (PRI_MACROS_BROKEN): Define it to 0 for _LIBC. --- diff --git a/intl/loadmsgcat.c b/intl/loadmsgcat.c index b96a997..3b9ceec 100644 --- a/intl/loadmsgcat.c +++ b/intl/loadmsgcat.c @@ -62,6 +62,7 @@ char *alloca (); #ifdef _LIBC # include # include +# define PRI_MACROS_BROKEN 0 #endif #if (defined HAVE_MMAP && defined HAVE_MUNMAP && !defined DISALLOW_MMAP) \