diff mbox series

[2/3] support: Provide a way to clear the RA bit in DNS server responses

Message ID 4d0f3a89d11cfdf2aa406019180b8a18c3b7fd7e.1599829382.git.fweimer@redhat.com
State Committed
Headers
Series [1/3] support: Provide a way to reorder responses within the DNS test server |

Commit Message

Florian Weimer Sept. 11, 2020, 1:03 p.m. UTC 
  ---
 support/resolv_test.c | 4 +++-
 support/resolv_test.h | 4 ++++
 2 files changed, 7 insertions(+), 1 deletion(-)

Comments

Siddhesh Poyarekar Oct. 13, 2020, 6:13 p.m. UTC | #1 
On 9/11/20 6:33 PM, Florian Weimer via Libc-alpha wrote:
> ---
>  support/resolv_test.c | 4 +++-
>  support/resolv_test.h | 4 ++++
>  2 files changed, 7 insertions(+), 1 deletion(-)
> 

This is fine.

Thanks,
Siddhesh
diff mbox series

Patch

diff --git a/support/resolv_test.c b/support/resolv_test.c
index e343c4b516..9878a040a3 100644
--- a/support/resolv_test.c
+++ b/support/resolv_test.c
@@ -181,7 +181,9 @@  resolv_response_init (struct resolv_response_builder *b,
   b->buffer[2] |= b->query_buffer[2] & 0x01; /* Copy the RD bit.  */
   if (flags.tc)
     b->buffer[2] |= 0x02;
-  b->buffer[3] = 0x80 | flags.rcode; /* Always set RA.  */
+  b->buffer[3] = flags.rcode;
+  if (!flags.clear_ra)
+    b->buffer[3] |= 0x80;
   if (flags.ad)
     b->buffer[3] |= 0x20;
 
diff --git a/support/resolv_test.h b/support/resolv_test.h
index c46de32ff4..31a5c1c3e7 100644
--- a/support/resolv_test.h
+++ b/support/resolv_test.h
@@ -148,6 +148,10 @@  struct resolv_response_flags
   /* If true, the AD (authenticated data) flag will be set.  */
   bool ad;
 
+  /* If true, do not set the RA (recursion available) flag in the
+     response.  */
+  bool clear_ra;
+
   /* Initial section count values.  Can be used to artificially
      increase the counts, for malformed packet testing.*/
   unsigned short qdcount;