From patchwork Fri Mar 19 13:26:32 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Szabolcs Nagy X-Patchwork-Id: 42682 Return-Path: X-Original-To: patchwork@sourceware.org Delivered-To: patchwork@sourceware.org Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id C48FB386F430; Fri, 19 Mar 2021 13:26:53 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org C48FB386F430 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=sourceware.org; s=default; t=1616160413; bh=uOWR/7/lMokzniipYY1T3NTfqc/1o0a3PTkV8lfTbpg=; h=To:Subject:Date:In-Reply-To:References:List-Id:List-Unsubscribe: List-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To: From; b=aHKaKCqQG8g+mDjLZ/KRlJMVQEKwY5oKXRsC8lfJbKaeDUrCkgwFN6ti8GB614tbe TZGZtorM3FKM6b9xfdxA99OOWmDOzimsBmtuMXB+JkrO1mIcMzTOAFN+/Knf20e5qU HZM+aMvGVoAMkBdD8Z129k9a8KYBdN3o2ZH623N8= X-Original-To: libc-alpha@sourceware.org Delivered-To: libc-alpha@sourceware.org Received: from EUR01-DB5-obe.outbound.protection.outlook.com (mail-eopbgr150073.outbound.protection.outlook.com [40.107.15.73]) by sourceware.org (Postfix) with ESMTPS id 442D03857C7F for ; Fri, 19 Mar 2021 13:26:50 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.3.2 sourceware.org 442D03857C7F Received: from AM5PR1001CA0049.EURPRD10.PROD.OUTLOOK.COM (2603:10a6:206:15::26) by PAXPR08MB6944.eurprd08.prod.outlook.com (2603:10a6:102:135::11) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3955.18; Fri, 19 Mar 2021 13:26:48 +0000 Received: from AM5EUR03FT039.eop-EUR03.prod.protection.outlook.com (2603:10a6:206:15:cafe::5b) by AM5PR1001CA0049.outlook.office365.com (2603:10a6:206:15::26) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3955.18 via Frontend Transport; Fri, 19 Mar 2021 13:26:47 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 63.35.35.123) smtp.mailfrom=arm.com; sourceware.org; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com;sourceware.org; dmarc=pass action=none header.from=arm.com; Received-SPF: Pass (protection.outlook.com: domain of arm.com designates 63.35.35.123 as permitted sender) receiver=protection.outlook.com; client-ip=63.35.35.123; helo=64aa7808-outbound-1.mta.getcheckrecipient.com; Received: from 64aa7808-outbound-1.mta.getcheckrecipient.com (63.35.35.123) by AM5EUR03FT039.mail.protection.outlook.com (10.152.17.185) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3955.18 via Frontend Transport; Fri, 19 Mar 2021 13:26:47 +0000 Received: ("Tessian outbound 04b74cf98e3c:v87"); Fri, 19 Mar 2021 13:26:47 +0000 X-CheckRecipientChecked: true X-CR-MTA-CID: 6b506989c3a0c412 X-CR-MTA-TID: 64aa7808 Received: from dd80ca25d5f0.1 by 64aa7808-outbound-1.mta.getcheckrecipient.com id 4DE95C3F-DC0B-4516-B229-9B4A0F99DE0F.1; Fri, 19 Mar 2021 13:26:39 +0000 Received: from EUR02-AM5-obe.outbound.protection.outlook.com by 64aa7808-outbound-1.mta.getcheckrecipient.com with ESMTPS id dd80ca25d5f0.1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384); Fri, 19 Mar 2021 13:26:39 +0000 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=HRqQA8ZC5kAB1F7AnXSp6rRd3GteI7Px/0ruZgx7WAv8tpgn+ThZ3bzN6YPQy6146mDRpt9n9gedAup197Z3Ab5e8VrrGzTwlNQSpkJIfzmeh9S3ZNtgtym172XK5l7zImTG8b/6e+VEMkobhqjH2HLogxHS063opEMuKUUbQQkfl3KymhHe9cX6wTzfQ+nG3vaZBh++i0CLr9twE2U4avYYHIAP0L+Zq31QSA3xXi5oyrStbVo7LJNWVRMXyr2E6rJlkUlf9rbg+ODt7nWY6Lj+VFeaOLux9JMW0VmEt25weJ+oL9TQwdfsjnfGR/JNwIfavzWidI3WDCcFs0AkDQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=uOWR/7/lMokzniipYY1T3NTfqc/1o0a3PTkV8lfTbpg=; b=UtMYj2OvxjgPJuAATQM4R+3bw7pqEhjyLOn7JiymmiPOH4+NvJwOnkIiIX7+xFgnkMqnP+TzM2hM6GmbWVb8P9ZMzHpK/QxDLwOW6B9MhO/8emujWv8r7LaQlGKMPspQEiFCY5y/208dPxOBRsLgmiW2VNratf3+DFlhzEOoYvZt/aOIdE1rGLABJLiyzLDt/Uz+llEGqxbpUJFSoeeJvcJzm21WZCkF9XIljXnTQfTvQwCb5yUFouaRnf9YVRiAP03ouLysnWXISwhHgTCQvctFpDG1GN9er6Onmq6GmTov0gz48ClGNRNea8mS7R3n0eUwRF7auU5PLcpKNg8mWg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=arm.com; dmarc=pass action=none header.from=arm.com; dkim=pass header.d=arm.com; arc=none Authentication-Results-Original: sourceware.org; dkim=none (message not signed) header.d=none;sourceware.org; dmarc=none action=none header.from=arm.com; Received: from PA4PR08MB6320.eurprd08.prod.outlook.com (2603:10a6:102:e5::9) by PA4PR08MB5966.eurprd08.prod.outlook.com (2603:10a6:102:ee::22) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3955.18; Fri, 19 Mar 2021 13:26:38 +0000 Received: from PA4PR08MB6320.eurprd08.prod.outlook.com ([fe80::60f0:3773:69b8:e336]) by PA4PR08MB6320.eurprd08.prod.outlook.com ([fe80::60f0:3773:69b8:e336%2]) with mapi id 15.20.3955.018; Fri, 19 Mar 2021 13:26:38 +0000 To: libc-alpha@sourceware.org, DJ Delorie Subject: [PATCH 2/6] malloc: Use different tag after mremap Date: Fri, 19 Mar 2021 13:26:32 +0000 Message-Id: <4aadefff0647fd8a4ade4377bdfab60989c37b7f.1616155129.git.szabolcs.nagy@arm.com> X-Mailer: git-send-email 2.17.1 In-Reply-To: References: X-Originating-IP: [217.140.106.49] X-ClientProxiedBy: LO4P123CA0340.GBRP123.PROD.OUTLOOK.COM (2603:10a6:600:18c::21) To PA4PR08MB6320.eurprd08.prod.outlook.com (2603:10a6:102:e5::9) MIME-Version: 1.0 X-MS-Exchange-MessageSentRepresentingType: 1 Received: from localhost.localdomain (217.140.106.49) by LO4P123CA0340.GBRP123.PROD.OUTLOOK.COM (2603:10a6:600:18c::21) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3933.32 via Frontend Transport; Fri, 19 Mar 2021 13:26:38 +0000 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-HT: Tenant X-MS-Office365-Filtering-Correlation-Id: c15dcd30-86fb-44c4-ada4-08d8eadaa5a9 X-MS-TrafficTypeDiagnostic: PA4PR08MB5966:|PAXPR08MB6944: X-Microsoft-Antispam-PRVS: x-checkrecipientrouted: true NoDisclaimer: true X-MS-Oob-TLC-OOBClassifiers: OLM:7691;OLM:7691; X-MS-Exchange-SenderADCheck: 1 X-Microsoft-Antispam-Untrusted: BCL:0; X-Microsoft-Antispam-Message-Info-Original: lVgm0IIxbxQlE/y9+NHJfD+IzL42rkWdHL3YK1R7sopgZhzU028tZMhw/Tk6WP1qe0Kz8yrljeM0s4amgfZryrTUW2ki0JxrZmXx5Z8aXqjubC9rtGcSTIUzu3yzFii9EdIs5NH/7+nUQ+fYdtXPVV16zAQ7prTgbQEzg1yxcEVQoc6IVl6WJuxm4m+6dPGuRjLZna+ep0WulAceK/luhUihWxQ9iB52dQwzvhvFRE0J8Nkb87STVdRF5gN7dAq/ew/jSKA//K8XstDtulit7AKFro2ig1h0KfQ5EYDiMXj0xh5B1Vf1eNsc8sWUFDgp6qvJho2VcQqKfh5x2sHx16cvTp8pdVVZ4AMhgxsLeMAtK3N2RLcPINMM2F8Yzq00B9EJnBk87X8nS9rhF71u93jz5TnJx6ww8V8lsXgc675AEsfZX8i2tPJWtCw0Ef8QBr8xqqrbv7O/CzeC8hgEkdMlxZLIqEUdawTONunpqpRPt6BxxkMIZ9bhYmqi+WiCSduRTrrl1qRRvaFhvdvYP8lLGdPCsfGpS5Uimm+qgOFP1qg1FzQW2aossH2ZPauLIfaVPgpm0z9oFolMhr6mBVxZYSSw7BbkcBxI6sjNSRbgIEEf4qqpRf8Ar3UzGqSOJtfqU/Icfv+xdrsTFoLBSwoOjd2Rdp0KX8aI9DXRahkFwBDPoKECmm8vRgDFxcNF X-Forefront-Antispam-Report-Untrusted: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:PA4PR08MB6320.eurprd08.prod.outlook.com; PTR:; CAT:NONE; SFS:(4636009)(396003)(39860400002)(136003)(376002)(366004)(346002)(2616005)(6916009)(26005)(316002)(36756003)(8936002)(6512007)(44832011)(5660300002)(8676002)(66556008)(66476007)(186003)(2906002)(6666004)(6506007)(66946007)(69590400012)(16526019)(86362001)(6486002)(83380400001)(52116002)(4744005)(478600001)(38100700001)(956004); DIR:OUT; SFP:1101; X-MS-Exchange-AntiSpam-MessageData: 7czkhQOhqaaLS0gr0bxSa/0ViyC7yjpcQ10CWvd9e5HPWYX8gYi0JAMnd0OPx8uVlPaCOSwAUp6tE3stbKxsIJv7V51sAehlYSeJzgi8QU4ret9o6iipkMt+ebwpOA1wu6XztyDNXCEncgcEzExGKPIeJnAk5l8RvHJXFi9ahlJllhy/Mwv0okVI3CrK7ThTBUplgKWX0XEaNQob4p7tSb870Yu48c7ZahE9zcwz2VeHmiZ6EHmrMAELuxNPYVR+aMNhXwxxUlOruziiSuTjOYyF7s/mxIYhOCAJ7WKdhElHlo1zUwRWpMB9YFh7PcfPHmNRMFzbtW8m4NeIXRVSt31aMlVaThWrplVfpKVxFKdd1KNjj3gZJ12g/jGy50ak5xK9TDsdeiLDGwSXRH9QFPGSCG7R3tu+HuGwfRuBT132glZXoCdPDc+nZDhWTHPYpsLT6LhCCqMFddmYeM/jyfIZXqG96vBVNybxjj8BxX17kDiJzr0fGfStsaQOzkP780JoZON9KmcniO/FbWl8YezhZGeiecL0lkOuomFx5/lNxwHcKBCV5iyZ/Nf7d2Jt2zO9yqVTiFDmtB87AQxfrPty9wwLDyJW/HxuDTqb5u7TdCo0La9/vJrnVdJkwdMBoOZ2dQqQ2J7e76SO+EJ+CiZrASsrsr82W0haOBZiR+NftftMHQrAgAiXRh3saiAs7U8UmdBYCpdHN8BA2+EBNQv2L1ClNGcjqebwJ2GFgOO44Abn9grS3sH59qWN2cI4M5SvRk/IXD8cH/nW/ifBmcoHKVHbgqbCmOgxiHF23QJ+6qzv61goAvRlzsCWSU+VG9m89FlRgr0pKsHMJDIkc6IEYUTOR1yER2qAi1vmVWWs8WQmU0H95pvfEvMbaaT4SBjSM6rWuNeZr0Kf5k66ZR6UYK/wwF3Y61YPsk8TZahvvi46yZq+MxBr7AUsbV8gDnWICoQ/EZFRljyK7ekUDw8r//GdX+74XTNJTpNAl2wDY8ti7q1JNBPkmtkxCk2wLDzKoN1EGKVaeXkhIi+gXU/7Upq9acmKig4icLrsBskI4BCW7+JgZ/42Gw/yvVl1UzuBfgWptZa6NuP0eXvPnZdltnthtr+xZeUNgv9uGW+ico4M6To4/hQ5KU7tSqARYP0yFnAWUk/Lkj8Na659PIK76jLvYixeKNi4D6bZyM+GS2vj5Gfi4tEq6NQfEvTKqiN1yx7p3vZ++FIh0tKCSpUsZqLkefEjb5xd4APxp7YMOz2gd6mh17w2zuUwJC3F+PU8iDKzY39r4M1ZBzTNTQbC5RF+NUJpyhFXwKPFqqzeCEI9AZEPxNqvEet6OmMH X-MS-Exchange-Transport-CrossTenantHeadersStamped: PA4PR08MB5966 Original-Authentication-Results: sourceware.org; dkim=none (message not signed) header.d=none; sourceware.org; dmarc=none action=none header.from=arm.com; X-EOPAttributedMessage: 0 X-MS-Exchange-Transport-CrossTenantHeadersStripped: AM5EUR03FT039.eop-EUR03.prod.protection.outlook.com X-MS-Office365-Filtering-Correlation-Id-Prvs: a79a3614-586f-47ea-c77e-08d8eadaa041 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: ly4Lzaf9RnfZKRgvggy6N9SMtUY6nGH3etjaArnoheavDvFSC9Dh0TuEsMhEyrDZ9w7U0OOPnyjHfJ5tAK9ZV5AHqhddNAqPUN+acOURfY6FUKrAewLFSas7QuJUXaY//xxlq8awt+rOOehFID5TRc5WdpgBL98mCFZflpy4izbT3Ttb6c3sXWyiYf+TOgBMpovaRbDOPZfnX9SXTD+MLJ77grumr5neKuFQ+pL0XTDvn2pRlK3ODwztpKKrWR5ZpZyA29E7D4nAhiXwFPp8zwtD5l8BzIvuVaXpzrPfAe8VVB6P5M9MlbZ8Y6AUY4OOF4XCA5THly6KW3a5t6wSOngj7ctd1gD0lxaJ1HTuJoqfgP+6+SyiwH5IIkRH73mC3ZiJ8qaLb6x0Zspa1LYaMALm3dBpTB+n12tnK2mJekxpulAm5fMsi67vo2GZKnsnUba5yp7J5SJyq7AZg/Z/dJxKiH2Xg76b+z2GrKlQcLP8nacWaLJyGppFmoy9UPoppKySQSYcOhRcquyvC4CdnVWtbCyVqTS1y1y5POy5Hyt5C2+DOIMNDVPAI+Qt5Shad8JoQ4zB9qdBmpqggzlnUibdZj8UvRItr7Vmibmm66p710khjUIDGsUWe3UdKbvcdzIuYaC77WMod4NQpzzvZfdXo5WTvp7eRs2EQSoZ5wBFark9oqQ2b6GHSTCW8mhs X-Forefront-Antispam-Report: CIP:63.35.35.123; CTRY:IE; LANG:en; SCL:1; SRV:; IPV:CAL; SFV:NSPM; H:64aa7808-outbound-1.mta.getcheckrecipient.com; PTR:ec2-63-35-35-123.eu-west-1.compute.amazonaws.com; CAT:NONE; SFS:(4636009)(396003)(136003)(346002)(376002)(39860400002)(36840700001)(46966006)(47076005)(8936002)(16526019)(6862004)(316002)(2616005)(5660300002)(956004)(86362001)(44832011)(6512007)(336012)(186003)(36860700001)(69590400012)(70586007)(6486002)(356005)(70206006)(82740400003)(2906002)(4744005)(83380400001)(6666004)(6506007)(8676002)(36756003)(82310400003)(26005)(81166007)(478600001); DIR:OUT; SFP:1101; X-OriginatorOrg: arm.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 19 Mar 2021 13:26:47.5476 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: c15dcd30-86fb-44c4-ada4-08d8eadaa5a9 X-MS-Exchange-CrossTenant-Id: f34e5979-57d9-4aaa-ad4d-b122a662184d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=f34e5979-57d9-4aaa-ad4d-b122a662184d; Ip=[63.35.35.123]; Helo=[64aa7808-outbound-1.mta.getcheckrecipient.com] X-MS-Exchange-CrossTenant-AuthSource: AM5EUR03FT039.eop-EUR03.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: PAXPR08MB6944 X-Spam-Status: No, score=-14.2 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, GIT_PATCH_0, MSGID_FROM_MTA_HEADER, RCVD_IN_DNSWL_LOW, RCVD_IN_MSPIKE_H2, SPF_HELO_PASS, SPF_PASS, TXREP, UNPARSEABLE_RELAY autolearn=ham autolearn_force=no version=3.4.2 X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on server2.sourceware.org X-BeenThere: libc-alpha@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Libc-alpha mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-Patchwork-Original-From: Szabolcs Nagy via Libc-alpha From: Szabolcs Nagy Reply-To: Szabolcs Nagy Errors-To: libc-alpha-bounces@sourceware.org Sender: "Libc-alpha" The comment explained why different tag is used after mremap, but for that correctly tagged pointer should be passed to tag_new_usable. Use chunk2mem to get the tag. --- malloc/malloc.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/malloc/malloc.c b/malloc/malloc.c index 03eb0f40fa..34884808e2 100644 --- a/malloc/malloc.c +++ b/malloc/malloc.c @@ -3411,7 +3411,7 @@ __libc_realloc (void *oldmem, size_t bytes) newp = mremap_chunk (oldp, nb); if (newp) { - void *newmem = chunk2rawmem (newp); + void *newmem = chunk2mem (newp); /* Give the new block a different tag. This helps to ensure that stale handles to the previous mapping are not reused. There's a performance hit for both us and the