From patchwork Wed Sep 28 11:31:24 2016 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Zack Weinberg X-Patchwork-Id: 16107 Received: (qmail 59914 invoked by alias); 28 Sep 2016 11:31:38 -0000 Mailing-List: contact libc-alpha-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Unsubscribe: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: libc-alpha-owner@sourceware.org Delivered-To: mailing list libc-alpha@sourceware.org Received: (qmail 59842 invoked by uid 89); 28 Sep 2016 11:31:38 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-1.9 required=5.0 tests=AWL, BAYES_00, FREEMAIL_FROM, RCVD_IN_DNSWL_NONE, SPF_PASS, URIBL_RED autolearn=ham version=3.3.2 spammy=D*panix.com, *x, rpcsvc X-HELO: mail-qk0-f195.google.com X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:subject:to:references:cc:from:message-id:date :user-agent:mime-version:in-reply-to:content-transfer-encoding; bh=y3daHqGgmvQaVNccwQAmhNO28dkeRNuWCmeaDNZ5OIs=; b=l3mp/H9lwPz+7ycCKs2Bd6yPDdmDd3Q9rdgcHvAdcuE39hJJQio1ADu/RRLKRTN0IT yPKOoZ1SDwQdjv8pOixdiOCk+7MXtRFOv76fPtYYTannM/L7T2BFRcQH1ODBoWQOqo3t oLZ5c6L9QC3fa3fjaTm5Z6GBIXwmc7yeQMjhsbnmaGj7nQNj+LHqKE545tHi7QTLXhui kHyl4FUzZDgiQIgflOGvNT9OXyK9tpNoRNrFge2nWGWhBxJuX0ybkFJCQR4Yt2hgN/FN JcxTIRv3doFBrD+x+4Sz8t3mTjcPXn7dLzWAp/OALiPIeZ46N3m5t06UlNSf3iUX6/r/ xJFQ== X-Gm-Message-State: AA6/9Rl6qQ8k0/Wy/JMtB31hOuhQvw5nAJ4nAIzF6FlE7Ixnzjg6MmV+zoYE7xh0yg3Z/Q== X-Received: by 10.55.41.153 with SMTP id p25mr8102917qkp.221.1475062286375; Wed, 28 Sep 2016 04:31:26 -0700 (PDT) Subject: Re: [PATCH 6/6] Installed header hygiene (BZ#20366): Test of installed headers. To: Joseph Myers References: <20160922133054.22210-1-zackw@panix.com> <20160922133054.22210-2-zackw@panix.com> <20160922133054.22210-3-zackw@panix.com> <20160922133054.22210-4-zackw@panix.com> <20160922133054.22210-5-zackw@panix.com> <20160922133054.22210-6-zackw@panix.com> <20160922133054.22210-7-zackw@panix.com> <20160922133054.22210-8-zackw@panix.com> <20160922133054.22210-9-zackw@panix.com> <20160922133054.22210-10-zackw@panix.com> <20160922133054.22210-11-zackw@panix.com> <20160922133054.22210-12-zackw@panix.com> <20160922133054.22210-13-zackw@panix.com> <20160922133054.22210-14-zackw@panix.com> <0fcc4287-2793-9a32-4673-d19ee1414c45@panix.com> Cc: GNU C Library , Carlos O'Donell From: Zack Weinberg Message-ID: <4643e5d8-2cf8-f45c-6452-96f33273f62b@panix.com> Date: Wed, 28 Sep 2016 07:31:24 -0400 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Icedove/45.2.0 MIME-Version: 1.0 In-Reply-To: On 09/23/2016 10:01 PM, Zack Weinberg wrote: > On Fri, Sep 23, 2016 at 5:51 PM, Joseph Myers wrote: >> I'm seeing the new tests fail in misc/ for 32-bit x86, because of: >> >> ../sysdeps/unix/sysv/linux/x86/sys/elf.h:24:3: error: #warning "This header is obsolete; use instead." [-Werror=cpp] >> # warning "This header is obsolete; use instead." >> ^ >> cc1: all warnings being treated as errors > > I can't conveniently do anything with anything other than x86-64 at > the moment, but there's already a special case for sys/elf.h in > check-installed-headers.sh -- would you mind seeing if you can > generalize it? Possibly passing $(target_alias) down from the > Makefile rather than what it does now. I have just pushed a patch that should correct this problem. It turns out that all architectures' versions of sys/elf.h have either an obsoletion warning or a flat-out #error, so the existing code can be generalized easily. zw (no) ;; diff --git a/ChangeLog b/ChangeLog index 0484809..88ea4b1 100644 --- a/ChangeLog +++ b/ChangeLog @@ -1,5 +1,8 @@ 2016-09-28 Zack Weinberg + * scripts/check-installed-headers.sh: Generalize treatment of + sys/elf.h to all target architectures. + * sysdeps/unix/sysv/linux/s390/sys/ucontext.h: Restore accidentally- deleted typedef ucontext_t. diff --git a/scripts/check-installed-headers.sh b/scripts/check-installed-headers.sh index 7fbc725..87d6142 100644 --- a/scripts/check-installed-headers.sh +++ b/scripts/check-installed-headers.sh @@ -77,9 +77,14 @@ for header in "$@"; do (bits/* | regexp.h | rpcsvc/*.x) continue;; - # sys/elf.h and sys/vm86.h are "unsupported on x86-64" and - # #error out on that target. - (sys/elf.h | sys/vm86.h) + # All extant versions of sys/elf.h contain nothing more than an + # exhortation (either a #warning or an #error) to use sys/procfs.h + # instead, plus an inclusion of that header. + (sys/elf.h) + continue;; + + # sys/vm86.h is "unsupported on x86-64" and errors out on that target. + (sys/vm86.h) case "$is_x86_64" in (yes) continue;;