[v2,3/8] nptl: Introduce THREAD_GETMEM_VOLATILE
Checks
Context |
Check |
Description |
dj/TryBot-apply_patch |
success
|
Patch applied to master at the time it was sent
|
Commit Message
This will be needed for rseq TCB access.
---
v2: New patch.
sysdeps/i386/nptl/tcb-access.h | 2 ++
sysdeps/nptl/tcb-access.h | 2 ++
sysdeps/x86_64/nptl/tcb-access.h | 2 ++
3 files changed, 6 insertions(+)
Comments
The 12/07/2021 14:00, Florian Weimer via Libc-alpha wrote:
> This will be needed for rseq TCB access.
I think volatile access is the right thing to do.
(we could change the type of cpu_id to be volatile but
then accesses outside of rseq registration would be
unnecessarily volatile)
Reviewed-by: Szabolcs Nagy <szabolcs.nagy@arm.com>
@@ -41,6 +41,8 @@
} \
__value; })
+/* THREAD_GETMEM already forces a read. */
+#define THREAD_GETMEM_VOLATILE(descr, member) THREAD_GETMEM (descr, member)
/* Same as THREAD_GETMEM, but the member offset can be non-constant. */
#define THREAD_GETMEM_NC(descr, member, idx) \
@@ -22,6 +22,8 @@
#define THREAD_GETMEM(descr, member) \
descr->member
+#define THREAD_GETMEM_VOLATILE(descr, member) \
+ (*(volatile __typeof (descr->member) *)&descr->member)
#define THREAD_GETMEM_NC(descr, member, idx) \
descr->member[idx]
#define THREAD_SETMEM(descr, member, value) \
@@ -39,6 +39,8 @@
} \
__value; })
+/* THREAD_GETMEM already forces a read. */
+#define THREAD_GETMEM_VOLATILE(descr, member) THREAD_GETMEM (descr, member)
/* Same as THREAD_GETMEM, but the member offset can be non-constant. */
# define THREAD_GETMEM_NC(descr, member, idx) \