Message ID | 2b21e47e43bdfb90c035b76e8a2f245e991a1718.1563321715.git.alistair.francis@wdc.com |
---|---|
State | New, archived |
Headers |
Received: (qmail 18328 invoked by alias); 17 Jul 2019 00:12:06 -0000 Mailing-List: contact libc-alpha-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: <libc-alpha.sourceware.org> List-Unsubscribe: <mailto:libc-alpha-unsubscribe-##L=##H@sourceware.org> List-Subscribe: <mailto:libc-alpha-subscribe@sourceware.org> List-Archive: <http://sourceware.org/ml/libc-alpha/> List-Post: <mailto:libc-alpha@sourceware.org> List-Help: <mailto:libc-alpha-help@sourceware.org>, <http://sourceware.org/ml/#faqs> Sender: libc-alpha-owner@sourceware.org Delivered-To: mailing list libc-alpha@sourceware.org Received: (qmail 18270 invoked by uid 89); 17 Jul 2019 00:12:06 -0000 Authentication-Results: sourceware.org; auth=none X-Spam-SWARE-Status: No, score=-26.7 required=5.0 tests=AWL, BAYES_00, GIT_PATCH_0, GIT_PATCH_1, GIT_PATCH_2, GIT_PATCH_3 autolearn=ham version=3.3.1 spammy=HContent-Transfer-Encoding:8bit X-HELO: esa4.hgst.iphmx.com DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=wdc.com; i=@wdc.com; q=dns/txt; s=dkim.wdc.com; t=1563322325; x=1594858325; h=from:to:cc:subject:date:message-id:in-reply-to: references:mime-version:content-transfer-encoding; bh=i+B3lI3a7gYjsZ4OWUfC+Q58cEyAVEkifAEkj1YvwGw=; b=KLIMmDr3KTh3+OLwl+x1tkX2jPvknJqV+rUa7lHJ485VPeaIovmwQQiv nT89N5mnF4thd1AKkhlHmXt5PSaSi45+9pzF68xS34N5IhwiWlUVW7nsE t2/y5vAxBXViyc09o0whU/IJpaj3ptlLxpY/q1/hWHmj//ZppK10+ewwQ KxAvlTfgFA95NLkT2GYGzShounaMtegOYQFBwiu6//O7UrM0PgJcqZAkL uLum0rvHYHtGTgksTwXi6x/hwAkvDAwq0eF5IrtA2rs5GdhR+U1TCqxs4 xZ6VdAjQRzbZojG8EKutU3TZwqTSWe2FfoZ0zRpgqVLVb0wq3jInUR1LM A==; IronPort-SDR: 2I2wYh2x+/8sX7xZG4jwSSECZlfVjnqmBwA5Xxv9Lec0BZKcWK4CcaGp5IbMaymYRHgffxSt/L 0BeMkbxYs0Mlv2Izea4CSzA+vwczEbIy4L+QAR+OWQ88z2s+Z0ObpYS/Pfstl/kSDOxmRqByDC LlVamN0UUltobhVptR6LhCSAhMvKxz9Dcd0A20Q4vrvzUq8nukQ6ct2eeGNOpC3a/SJal8rdoK B6JYXje6Wf1BF5SysUx0ZFKOJl7QRP+InqI4985rRRtDsi4/8wFDhvpwunXH/wcLC9anAcrJZc EDM= IronPort-SDR: wQpuCQLl+2BUd8MujciPUQQjgpruVY8AGsoxEAWcZG/XkaoUZV3TDey7r8u+RYBRvV4qi9A5y8 Suwcns2sLtYCx1INuYJKdeympcRLjDOFKVEImEBwxgE6Vbj0LXVXOJU0Vm3GfPm9wlmYi8cfd3 Tp65MiiiWvlz3ss06OQV5qwKc64iA89adATU2urR/lXuzCHqnOuJFIoXLF9slXDh89aNOML4rc XrGM3dLQj9gwi9IjIA9ptjLDfNyRpZl6/h3GUN8GYaFS3ZG2ryiAq8aQTJnlhHoNdQjXtUB7VZ 1ZxLvKci1HHddtPH16wKPGgN IronPort-SDR: Pm8mOtFvbS5h2QIb1Hkhv3E+Db8fkmnuT/4H20UsvyxyGmn6UvtB4451WiLw7cSue1ThHWN+Tx LZFgXh6V3XcQmSrR/I5fTOvlFvlGwwtcc5BM/np1f1tAMndD3JqwihBpBa/HTFRr1CiXtH/KKY wtEPeNAUU+d0PTnK01VAblVSEkvTiK1GNZDDt9NRqxQYZLakpJgTFiehq+ItWrZu7ImN8t8sxx ZctxTFE3sAEUZH1bHp7uSvdT8XEztZhlxWRYbznPJ11NmCdPkGRo4cGuqonxT6Mu7O3L+X1GXY 9Gk= From: Alistair Francis <alistair.francis@wdc.com> To: libc-alpha@sourceware.org Cc: arnd@arndb.de, adhemerval.zanella@linaro.org, fweimer@redhat.com, palmer@sifive.com, macro@wdc.com, zongbox@gmail.com, alistair.francis@wdc.com, alistair23@gmail.com Subject: [RFC v3 12/23] RISC-V: define __vdso_clock_gettime as __vdso_clock_gettime64 for 32-bit Date: Tue, 16 Jul 2019 17:09:12 -0700 Message-Id: <2b21e47e43bdfb90c035b76e8a2f245e991a1718.1563321715.git.alistair.francis@wdc.com> In-Reply-To: <cover.1563321715.git.alistair.francis@wdc.com> References: <cover.1563321715.git.alistair.francis@wdc.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit |
Commit Message
Alistair Francis
July 17, 2019, 12:09 a.m. UTC
Signed-off-by: Alistair Francis <alistair.francis@wdc.com>
---
sysdeps/unix/sysv/linux/riscv/sysdep.h | 4 ++++
1 file changed, 4 insertions(+)
Comments
On Wed, Jul 17, 2019 at 2:12 AM Alistair Francis <alistair.francis@wdc.com> wrote: > > Signed-off-by: Alistair Francis <alistair.francis@wdc.com> > --- > sysdeps/unix/sysv/linux/riscv/sysdep.h | 4 ++++ > 1 file changed, 4 insertions(+) > > diff --git a/sysdeps/unix/sysv/linux/riscv/sysdep.h b/sysdeps/unix/sysv/linux/riscv/sysdep.h > index e66e9f032a..ea47b9b82c 100644 > --- a/sysdeps/unix/sysv/linux/riscv/sysdep.h > +++ b/sysdeps/unix/sysv/linux/riscv/sysdep.h > @@ -171,6 +171,10 @@ > # ifndef __vdso_clock_getres > # define __vdso_clock_getres __vdso_clock_getres_time64 > # endif > + > +# ifndef __vdso_clock_gettime > +# define __vdso_clock_gettime __vdso_clock_gettime64 > +# endif > #endif /* __riscv_xlen == 32 */ I had not noticed this when commenting on the other patches. What is the purpose of doing this? As mentioned, I don't think we should have __vdso_clock_getres_time64() at all (no caller cares about this being fast). The "#define__vdso_clock_gettime __vdso_clock_gettime64" should be harmless but leads to confusion because other architectures that have both cannot do this. Arnd
On Wed, Jul 17, 2019 at 1:16 AM Arnd Bergmann <arnd@arndb.de> wrote: > > On Wed, Jul 17, 2019 at 2:12 AM Alistair Francis > <alistair.francis@wdc.com> wrote: > > > > Signed-off-by: Alistair Francis <alistair.francis@wdc.com> > > --- > > sysdeps/unix/sysv/linux/riscv/sysdep.h | 4 ++++ > > 1 file changed, 4 insertions(+) > > > > diff --git a/sysdeps/unix/sysv/linux/riscv/sysdep.h b/sysdeps/unix/sysv/linux/riscv/sysdep.h > > index e66e9f032a..ea47b9b82c 100644 > > --- a/sysdeps/unix/sysv/linux/riscv/sysdep.h > > +++ b/sysdeps/unix/sysv/linux/riscv/sysdep.h > > @@ -171,6 +171,10 @@ > > # ifndef __vdso_clock_getres > > # define __vdso_clock_getres __vdso_clock_getres_time64 > > # endif > > + > > +# ifndef __vdso_clock_gettime > > +# define __vdso_clock_gettime __vdso_clock_gettime64 > > +# endif > > #endif /* __riscv_xlen == 32 */ > > > I had not noticed this when commenting on the other patches. What is > the purpose of doing this? > > As mentioned, I don't think we should have __vdso_clock_getres_time64() > at all (no caller cares about this being fast). > The "#define__vdso_clock_gettime __vdso_clock_gettime64" should > be harmless but leads to confusion because other architectures that > have both cannot do this. These were required to avoid build failures, but I think I have a better solution and have removed these patches. Alistair > > Arnd
diff --git a/sysdeps/unix/sysv/linux/riscv/sysdep.h b/sysdeps/unix/sysv/linux/riscv/sysdep.h index e66e9f032a..ea47b9b82c 100644 --- a/sysdeps/unix/sysv/linux/riscv/sysdep.h +++ b/sysdeps/unix/sysv/linux/riscv/sysdep.h @@ -171,6 +171,10 @@ # ifndef __vdso_clock_getres # define __vdso_clock_getres __vdso_clock_getres_time64 # endif + +# ifndef __vdso_clock_gettime +# define __vdso_clock_gettime __vdso_clock_gettime64 +# endif #endif /* __riscv_xlen == 32 */ #undef SYS_ify