From patchwork Fri Jul 2 18:49:06 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Florian Weimer X-Patchwork-Id: 44116 X-Patchwork-Delegate: carlos@redhat.com Return-Path: X-Original-To: patchwork@sourceware.org Delivered-To: patchwork@sourceware.org Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id 0B8023983C23 for ; Fri, 2 Jul 2021 19:04:27 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 0B8023983C23 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=sourceware.org; s=default; t=1625252667; bh=jKWrQi7PRWZiKnXth+d0pz4Vy669Ikxdgyy6uvjBgqk=; h=To:Subject:In-Reply-To:References:Date:List-Id:List-Unsubscribe: List-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To: From; b=BODODvBTHlYrsfSu98gbyHPc6rczF7GQNWsIoKcJTz52e2UuX7yyGKIMOXn8sC/Rr qZImq8jtEt1I5aBk+iWQxDMe66YoK497x3q7jSLLaX1zeRvfQR5evm5o8Zuo1R2Tgf 4d25aV4q8Ko/qP9n9m8J8W672TZA5dPUi8WylskE= X-Original-To: libc-alpha@sourceware.org Delivered-To: libc-alpha@sourceware.org Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [216.205.24.124]) by sourceware.org (Postfix) with ESMTP id 8F859398400B for ; Fri, 2 Jul 2021 18:49:11 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 8F859398400B Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-59-A0eO2ux-PmCbgon4ycPFCg-1; Fri, 02 Jul 2021 14:49:10 -0400 X-MC-Unique: A0eO2ux-PmCbgon4ycPFCg-1 Received: from smtp.corp.redhat.com (int-mx01.intmail.prod.int.phx2.redhat.com [10.5.11.11]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 1C264106B7D6 for ; Fri, 2 Jul 2021 18:49:09 +0000 (UTC) Received: from oldenburg.str.redhat.com (ovpn-115-5.ams2.redhat.com [10.36.115.5]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 42DC5604CD for ; Fri, 2 Jul 2021 18:49:08 +0000 (UTC) To: libc-alpha@sourceware.org Subject: [PATCH 18/30] resolv: Move __res_get_nsaddr to its own file and into libc In-Reply-To: References: X-From-Line: 2acfb307497c6238f6deb58eeb6d038ed3724600 Mon Sep 17 00:00:00 2001 Message-Id: <2acfb307497c6238f6deb58eeb6d038ed3724600.1625251245.git.fweimer@redhat.com> Date: Fri, 02 Jul 2021 20:49:06 +0200 User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.2 (gnu/linux) MIME-Version: 1.0 X-Scanned-By: MIMEDefang 2.79 on 10.5.11.11 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com X-Spam-Status: No, score=-12.7 required=5.0 tests=BAYES_00, DKIMWL_WL_HIGH, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, GIT_PATCH_0, KAM_SHORT, RCVD_IN_DNSWL_LOW, RCVD_IN_MSPIKE_H4, RCVD_IN_MSPIKE_WL, SPF_HELO_NONE, SPF_NONE, TXREP autolearn=ham autolearn_force=no version=3.4.4 X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on server2.sourceware.org X-BeenThere: libc-alpha@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Libc-alpha mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-Patchwork-Original-From: Florian Weimer via Libc-alpha From: Florian Weimer Reply-To: Florian Weimer Errors-To: libc-alpha-bounces+patchwork=sourceware.org@sourceware.org Sender: "Libc-alpha" Eliminate the use of the EXT macro from it because it does not add clarity. The function was added to res_send.c in 2015, and the copyright year reflects that. --- resolv/Makefile | 1 + resolv/Versions | 1 + resolv/res_get_nsaddr.c | 39 +++++++++++++++++++++++++++++++++++++++ resolv/res_send.c | 25 ++++--------------------- resolv/resolv-internal.h | 6 ++++++ 5 files changed, 51 insertions(+), 21 deletions(-) create mode 100644 resolv/res_get_nsaddr.c diff --git a/resolv/Makefile b/resolv/Makefile index 7e142b9a14..6eed73de87 100644 --- a/resolv/Makefile +++ b/resolv/Makefile @@ -46,6 +46,7 @@ routines := \ res-close \ res-name-checking \ res-state \ + res_get_nsaddr \ res_hconf \ res_init \ res_libc \ diff --git a/resolv/Versions b/resolv/Versions index 3e3b89a0b2..fc14cdb701 100644 --- a/resolv/Versions +++ b/resolv/Versions @@ -81,6 +81,7 @@ libc { __ns_name_skip; __ns_name_uncompress; __ns_name_unpack; + __res_get_nsaddr; __res_iclose; __resolv_context_get; __resolv_context_get_override; diff --git a/resolv/res_get_nsaddr.c b/resolv/res_get_nsaddr.c new file mode 100644 index 0000000000..593597bdd7 --- /dev/null +++ b/resolv/res_get_nsaddr.c @@ -0,0 +1,39 @@ +/* Name server address at specified index in res_state. + Copyright (C) 2015-2021 Free Software Foundation, Inc. + This file is part of the GNU C Library. + + The GNU C Library is free software; you can redistribute it and/or + modify it under the terms of the GNU Lesser General Public + License as published by the Free Software Foundation; either + version 2.1 of the License, or (at your option) any later version. + + The GNU C Library is distributed in the hope that it will be useful, + but WITHOUT ANY WARRANTY; without even the implied warranty of + MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the GNU + Lesser General Public License for more details. + + You should have received a copy of the GNU Lesser General Public + License along with the GNU C Library; if not, see + . */ + +#include +#include +#include + +struct sockaddr * +__res_get_nsaddr (res_state statp, unsigned int n) +{ + assert (n < statp->nscount); + + if (statp->nsaddr_list[n].sin_family == 0 + && statp->_u._ext.nsaddrs[n] != NULL) + /* statp->_u._ext.nsaddrs[n] holds an address that is larger than + struct sockaddr, and user code did not update + statp->nsaddr_list[n]. */ + return (struct sockaddr *) statp->_u._ext.nsaddrs[n]; + else + /* User code updated statp->nsaddr_list[n], or statp->nsaddr_list[n] + has the same content as statp->_u._ext.nsaddrs[n]. */ + return (struct sockaddr *) (void *) &statp->nsaddr_list[n]; +} +libc_hidden_def (__res_get_nsaddr) diff --git a/resolv/res_send.c b/resolv/res_send.c index b6139c7d62..78f564ee85 100644 --- a/resolv/res_send.c +++ b/resolv/res_send.c @@ -180,7 +180,6 @@ evNowTime(struct timespec *res) { /* Forward. */ -static struct sockaddr *get_nsaddr (res_state, unsigned int); static int send_vc(res_state, const u_char *, int, const u_char *, int, u_char **, int *, int *, int, u_char **, @@ -215,7 +214,7 @@ res_ourserver_p(const res_state statp, const struct sockaddr_in6 *inp) for (ns = 0; ns < statp->nscount; ns++) { const struct sockaddr_in *srv = - (struct sockaddr_in *) get_nsaddr (statp, ns); + (struct sockaddr_in *) __res_get_nsaddr (statp, ns); if ((srv->sin_family == AF_INET) && (srv->sin_port == port) && @@ -226,7 +225,7 @@ res_ourserver_p(const res_state statp, const struct sockaddr_in6 *inp) } else if (inp->sin6_family == AF_INET6) { for (ns = 0; ns < statp->nscount; ns++) { const struct sockaddr_in6 *srv - = (struct sockaddr_in6 *) get_nsaddr (statp, ns); + = (struct sockaddr_in6 *) __res_get_nsaddr (statp, ns); if ((srv->sin6_family == AF_INET6) && (srv->sin6_port == inp->sin6_port) && !(memcmp(&srv->sin6_addr, &in6addr_any, @@ -608,22 +607,6 @@ res_send (const unsigned char *buf, int buflen, unsigned char *ans, int anssiz) /* Private */ -static struct sockaddr * -get_nsaddr (res_state statp, unsigned int n) -{ - assert (n < statp->nscount); - - if (statp->nsaddr_list[n].sin_family == 0 && EXT(statp).nsaddrs[n] != NULL) - /* EXT(statp).nsaddrs[n] holds an address that is larger than - struct sockaddr, and user code did not update - statp->nsaddr_list[n]. */ - return (struct sockaddr *) EXT(statp).nsaddrs[n]; - else - /* User code updated statp->nsaddr_list[n], or statp->nsaddr_list[n] - has the same content as EXT(statp).nsaddrs[n]. */ - return (struct sockaddr *) (void *) &statp->nsaddr_list[n]; -} - /* Close the resolver structure, assign zero to *RESPLEN2 if RESPLEN2 is not NULL, and return zero. */ static int @@ -717,7 +700,7 @@ send_vc(res_state statp, const HEADER *hp = (HEADER *) buf; const HEADER *hp2 = (HEADER *) buf2; HEADER *anhp = (HEADER *) *ansp; - struct sockaddr *nsap = get_nsaddr (statp, ns); + struct sockaddr *nsap = __res_get_nsaddr (statp, ns); int truncating, connreset, n; /* On some architectures compiler might emit a warning indicating 'resplen' may be used uninitialized. However if buf2 == NULL @@ -948,7 +931,7 @@ static int reopen (res_state statp, int *terrno, int ns) { if (EXT(statp).nssocks[ns] == -1) { - struct sockaddr *nsap = get_nsaddr (statp, ns); + struct sockaddr *nsap = __res_get_nsaddr (statp, ns); socklen_t slen; /* only try IPv6 if IPv6 NS and if not failed before */ diff --git a/resolv/resolv-internal.h b/resolv/resolv-internal.h index e1e8aa3ef3..c18b1d0472 100644 --- a/resolv/resolv-internal.h +++ b/resolv/resolv-internal.h @@ -103,4 +103,10 @@ void __res_thread_freeres (void) attribute_hidden; success, -1 on failure. */ int __res_enable_icmp (int family, int fd) attribute_hidden; + +/* Returns the name server address for the indicated index. */ +struct sockaddr *__res_get_nsaddr (res_state statp, unsigned int n); +libc_hidden_proto (__res_get_nsaddr) + + #endif /* _RESOLV_INTERNAL_H */