diff mbox series

[6/9] test-installation: skip empty static libraries

Message ID 20260919100444.2316950-7-xry111@xry111.site (mailing list archive)
State Superseded
Delegated to: Adhemerval Zanella Netto
Headers
Series Make test-installation.pl work |

Checks

Context Check Description
redhat-pt-bot/TryBot-apply_patch success Patch applied to master at the time it was sent
linaro-tcwg-bot/tcwg_glibc_build--master-aarch64 success Build passed
linaro-tcwg-bot/tcwg_glibc_build--master-arm success Build passed
linaro-tcwg-bot/tcwg_glibc_check--master-aarch64 success Test passed
linaro-tcwg-bot/tcwg_glibc_check--master-arm success Test passed

Commit Message

Xi Ruoyao Sept. 19, 2026, 10:04 a.m. UTC 
  The functionalites of them are merged into libc at glibc 2.34.  Using -l
to refer them is a no-op.

Signed-off-by: Xi Ruoyao <xry111@xry111.site>
---
 scripts/test-installation.pl | 2 ++
 1 file changed, 2 insertions(+)

Comments

Adhemerval Zanella Sept. 24, 2026, 4:40 p.m. UTC | #1 
On 19/09/26 07:04, Xi Ruoyao wrote:
> The functionalites of them are merged into libc at glibc 2.34.  Using -l
> to refer them is a no-op.

s/functionalites/functionality/.  Maybe something like: "Their
functionality was merged into libc in glibc 2.34, so -l for them only
links an empty static archive."

> 
> Signed-off-by: Xi Ruoyao <xry111@xry111.site>
> ---
>  scripts/test-installation.pl | 2 ++
>  1 file changed, 2 insertions(+)
> 
> diff --git a/scripts/test-installation.pl b/scripts/test-installation.pl
> index 6ac4da216f..df786ab030 100755
> --- a/scripts/test-installation.pl
> +++ b/scripts/test-installation.pl
> @@ -124,6 +124,8 @@ while (<SOVERSIONS>) {
>        "gcc_s",
>        # are dummy SONAMEs for compatibility, unavailable for -l
>        "nss_dns", "nss_files",
> +      # are empty static libraries, unavailable for ldd to find
> +      "dl", "rt", "pthread", "util",
>      );
>      next if (grep { $_ eq $name } @skip);
>      # libmvec if it wasn't built

libanl belongs in this list too.  It was also merged into libc in 2.34,
and resolv/Makefile builds it the same way as the other four (shared-only
compat objects, an empty libanl.a, and no libanl.so link).  So I would add
"anl" here and drop 9/9 ("anl", "dl", "pthread", "rt", "util").

With that, LGTM.

Reviewed-by: Adhemerval Zanella  <adhemerval.zanella@linaro.org>
diff mbox series

Patch

diff --git a/scripts/test-installation.pl b/scripts/test-installation.pl
index 6ac4da216f..df786ab030 100755
--- a/scripts/test-installation.pl
+++ b/scripts/test-installation.pl
@@ -124,6 +124,8 @@  while (<SOVERSIONS>) {
       "gcc_s",
       # are dummy SONAMEs for compatibility, unavailable for -l
       "nss_dns", "nss_files",
+      # are empty static libraries, unavailable for ldd to find
+      "dl", "rt", "pthread", "util",
     );
     next if (grep { $_ eq $name } @skip);
     # libmvec if it wasn't built