diff mbox series

string: Use extended timeout for test-mempcpy

Message ID 20260803155421.3087729-1-linmag7@gmail.com (mailing list archive)
State Changes Requested
Headers
Series string: Use extended timeout for test-mempcpy |

Checks

Context Check Description
redhat-pt-bot/TryBot-apply_patch success Patch applied to master at the time it was sent
linaro-tcwg-bot/tcwg_glibc_build--master-aarch64 success Build passed
linaro-tcwg-bot/tcwg_glibc_build--master-arm success Build passed
redhat-pt-bot/TryBot-32bit success Build for i686
linaro-tcwg-bot/tcwg_glibc_check--master-aarch64 success Test passed
linaro-tcwg-bot/tcwg_glibc_check--master-arm success Test passed

Commit Message

Magnus Lindholm Aug. 3, 2026, 3:53 p.m. UTC 
  The shared memcpy tests use an eight-minute timeout because they can
take significantly longer than other string tests.

test-mempcpy provides its own test setup and includes test-string.h
before the shared memcpy test functions are included. It therefore
receives the four-minute default timeout instead of the extended
timeout used by test-memcpy.

Define the same eight-minute timeout explicitly for test-mempcpy.

This prevents the test from being terminated while it is still making
progress on slower systems.

Signed-off-by: Magnus Lindholm <linmag7@gmail.com>
---
 string/test-mempcpy.c | 1 +
 1 file changed, 1 insertion(+)

Comments

Adhemerval Zanella Aug. 3, 2026, 4:02 p.m. UTC | #1 
On 03/08/26 12:53, Magnus Lindholm wrote:
> The shared memcpy tests use an eight-minute timeout because they can
> take significantly longer than other string tests.

I think it would be better to start split this test, or at least move out
the porting that takes a lot of time.  Having a test that takes that large
amount of time can be be unfeasible to run on small cores and does not help
on regression tests in general.

> 
> test-mempcpy provides its own test setup and includes test-string.h
> before the shared memcpy test functions are included. It therefore
> receives the four-minute default timeout instead of the extended
> timeout used by test-memcpy.
> 
> Define the same eight-minute timeout explicitly for test-mempcpy.
> 
> This prevents the test from being terminated while it is still making
> progress on slower systems.
> 
> Signed-off-by: Magnus Lindholm <linmag7@gmail.com>
> ---
>  string/test-mempcpy.c | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/string/test-mempcpy.c b/string/test-mempcpy.c
> index cc7f9d447c..cc2ec23173 100644
> --- a/string/test-mempcpy.c
> +++ b/string/test-mempcpy.c
> @@ -18,6 +18,7 @@
>  
>  #define MEMCPY_RESULT(dst, len) (dst) + (len)
>  #define MIN_PAGE_SIZE 131072
> +#define TIMEOUT (8 * 60)
>  #define TEST_MAIN
>  #define TEST_NAME "mempcpy"
>  #include "test-string.h"
diff mbox series

Patch

diff --git a/string/test-mempcpy.c b/string/test-mempcpy.c
index cc7f9d447c..cc2ec23173 100644
--- a/string/test-mempcpy.c
+++ b/string/test-mempcpy.c
@@ -18,6 +18,7 @@ 
 
 #define MEMCPY_RESULT(dst, len) (dst) + (len)
 #define MIN_PAGE_SIZE 131072
+#define TIMEOUT (8 * 60)
 #define TEST_MAIN
 #define TEST_NAME "mempcpy"
 #include "test-string.h"