diff mbox series

math: Fix powerpc64le -Os build after 6b7067460f

Message ID 20251223173109.2172381-1-adhemerval.zanella@linaro.org (mailing list archive)
State Committed
Commit e56b3faf8d73e0aa0c73ee55e1648a26b156a93f
Headers
Series math: Fix powerpc64le -Os build after 6b7067460f |

Checks

Context Check Description
redhat-pt-bot/TryBot-apply_patch success Patch applied to master at the time it was sent
redhat-pt-bot/TryBot-32bit success Build for i686

Commit Message

Adhemerval Zanella Dec. 23, 2025, 5:31 p.m. UTC 
  The __USE_EXTERN_INLINES is gated __OPTIMIZE_SIZE__, so also gated
the alias required using the same logic.
---
 sysdeps/ieee754/float128/s_fabsf128.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Comments

Carlos O'Donell Jan. 5, 2026, 2:18 p.m. UTC | #1 
On 12/23/25 12:31 PM, Adhemerval Zanella wrote:
> The __USE_EXTERN_INLINES is gated __OPTIMIZE_SIZE__, so also gated
> the alias required using the same logic.

This prevents ppc64le -Os builds with clang, but that's fine, since
it isn't the default and would require more work.

This fixes the gcc case.

I don't think we need a bug number in this case.

Reviewed-by: Carlos O'Donell <carlos@redhat.com>

> ---
>   sysdeps/ieee754/float128/s_fabsf128.c | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/sysdeps/ieee754/float128/s_fabsf128.c b/sysdeps/ieee754/float128/s_fabsf128.c
> index 9d64f15040..1e0ce65804 100644
> --- a/sysdeps/ieee754/float128/s_fabsf128.c
> +++ b/sysdeps/ieee754/float128/s_fabsf128.c
> @@ -1,5 +1,5 @@
>   #include <float128_private.h>
> -#ifndef __USE_EXTERN_INLINES
> +#if !defined __USE_EXTERN_INLINES && !defined(__OPTIMIZE_SIZE__)
>   # undef libm_alias_float128_r
>   # define libm_alias_float128_r(from, to, r)			\
>     static_weak_alias (from ## f128 ## r, to ## f128 ## r);	\
Andreas K. Huettel Jan. 7, 2026, 5:56 p.m. UTC | #2 
Am Montag, 5. Januar 2026, 15:18:59 Mitteleuropäische Normalzeit schrieb Carlos O'Donell:
> On 12/23/25 12:31 PM, Adhemerval Zanella wrote:
> > The __USE_EXTERN_INLINES is gated __OPTIMIZE_SIZE__, so also gated
> > the alias required using the same logic.
> 
> This prevents ppc64le -Os builds with clang, but that's fine, since
> it isn't the default and would require more work.
> 
> This fixes the gcc case.
> 
> I don't think we need a bug number in this case.

Please push.

> 
> Reviewed-by: Carlos O'Donell <carlos@redhat.com>
> 
> > ---
> >   sysdeps/ieee754/float128/s_fabsf128.c | 2 +-
> >   1 file changed, 1 insertion(+), 1 deletion(-)
> > 
> > diff --git a/sysdeps/ieee754/float128/s_fabsf128.c b/sysdeps/ieee754/float128/s_fabsf128.c
> > index 9d64f15040..1e0ce65804 100644
> > --- a/sysdeps/ieee754/float128/s_fabsf128.c
> > +++ b/sysdeps/ieee754/float128/s_fabsf128.c
> > @@ -1,5 +1,5 @@
> >   #include <float128_private.h>
> > -#ifndef __USE_EXTERN_INLINES
> > +#if !defined __USE_EXTERN_INLINES && !defined(__OPTIMIZE_SIZE__)
> >   # undef libm_alias_float128_r
> >   # define libm_alias_float128_r(from, to, r)			\
> >     static_weak_alias (from ## f128 ## r, to ## f128 ## r);	\
> 
> 
>
diff mbox series

Patch

diff --git a/sysdeps/ieee754/float128/s_fabsf128.c b/sysdeps/ieee754/float128/s_fabsf128.c
index 9d64f15040..1e0ce65804 100644
--- a/sysdeps/ieee754/float128/s_fabsf128.c
+++ b/sysdeps/ieee754/float128/s_fabsf128.c
@@ -1,5 +1,5 @@ 
 #include <float128_private.h>
-#ifndef __USE_EXTERN_INLINES
+#if !defined __USE_EXTERN_INLINES && !defined(__OPTIMIZE_SIZE__)
 # undef libm_alias_float128_r
 # define libm_alias_float128_r(from, to, r)			\
   static_weak_alias (from ## f128 ## r, to ## f128 ## r);	\