diff mbox series

[v2,3/4] support: Always run ldconfig in containered tests

Message ID 20250208160937.3955501-3-dilfridge@gentoo.org (mailing list archive)
State Accepted
Delegated to: Adhemerval Zanella Netto
Headers
Series [v2,1/4] Makeconfig: Add libgcc directory to rtld-prefix search path |

Checks

Context Check Description
redhat-pt-bot/TryBot-apply_patch success Patch applied to master at the time it was sent
linaro-tcwg-bot/tcwg_glibc_build--master-arm success Build passed
linaro-tcwg-bot/tcwg_glibc_check--master-arm success Test passed
linaro-tcwg-bot/tcwg_glibc_build--master-aarch64 success Build passed
linaro-tcwg-bot/tcwg_glibc_check--master-aarch64 success Test passed

Commit Message

Andreas K. Huettel Feb. 8, 2025, 4:09 p.m. UTC 
  This is required so the generated ld.so.conf files take effect.

Signed-off-by: Andreas K. Hüttel <dilfridge@gentoo.org>
---
 support/test-container.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Comments

Adhemerval Zanella Netto Feb. 25, 2025, 6:46 p.m. UTC | #1 
On 08/02/25 13:09, Andreas K. Hüttel wrote:
> This is required so the generated ld.so.conf files take effect.
> 
> Signed-off-by: Andreas K. Hüttel <dilfridge@gentoo.org>

LGTM, thanks.

Reviewed-by: Adhemerval Zanella  <adhemerval.zanella@linaro.org>

> ---
>  support/test-container.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/support/test-container.c b/support/test-container.c
> index 79d3189e2f..10ff6a601b 100644
> --- a/support/test-container.c
> +++ b/support/test-container.c
> @@ -740,7 +740,7 @@ main (int argc, char **argv)
>    char *command_basename;
>    char *so_base;
>    int do_postclean = 0;
> -  bool do_ldconfig = false;
> +  bool do_ldconfig = true;
>    char *change_cwd = NULL;
>  
>    int pipes[2];
diff mbox series

Patch

diff --git a/support/test-container.c b/support/test-container.c
index 79d3189e2f..10ff6a601b 100644
--- a/support/test-container.c
+++ b/support/test-container.c
@@ -740,7 +740,7 @@  main (int argc, char **argv)
   char *command_basename;
   char *so_base;
   int do_postclean = 0;
-  bool do_ldconfig = false;
+  bool do_ldconfig = true;
   char *change_cwd = NULL;
 
   int pipes[2];