From patchwork Thu Jan 23 13:42:58 2025 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Aleksandar Rakic X-Patchwork-Id: 105297 Return-Path: X-Original-To: patchwork@sourceware.org Delivered-To: patchwork@sourceware.org Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id A9B3C385840F for ; Thu, 23 Jan 2025 13:46:53 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org A9B3C385840F Authentication-Results: sourceware.org; dkim=pass (2048-bit key, unprotected) header.d=gmail.com header.i=@gmail.com header.a=rsa-sha256 header.s=20230601 header.b=GxGm72gL X-Original-To: libc-alpha@sourceware.org Delivered-To: libc-alpha@sourceware.org Received: from mail-wm1-x336.google.com (mail-wm1-x336.google.com [IPv6:2a00:1450:4864:20::336]) by sourceware.org (Postfix) with ESMTPS id D37B43858C48 for ; Thu, 23 Jan 2025 13:43:30 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org D37B43858C48 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=gmail.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org D37B43858C48 Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=2a00:1450:4864:20::336 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1737639811; cv=none; b=PI5W6rxxPkvAn58V+e4BcK3vsOHqD1wKytliG0ph7Cy/bLtp+5lsaz69dZ5Y7NCFseLfyX1jBXMzANlV8/6OrdbMPKk2s/VkbVBsKZEaSeMMxEVB0O/2juushl9fhgP5/rD5pKTw2jjyChTXqpbw0JP1HMhTApqU7O23pieL18E= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1737639811; c=relaxed/simple; bh=mJuqW9skyLrvL8d9kSlbP1lC5OO0x5yyg97BQkIo+zk=; h=DKIM-Signature:From:To:Subject:Date:Message-Id:MIME-Version; b=ppNG7yQaV9iUuyvBZyMH7osxoeX+PBOylFXmr2rrTyRPzzhc9+CmKr19mnTjloOYVUWI6Vez9YkvT+sq7jKabWjotOZgtLiQbtTUUcKZ+op4kYmXi1tiKCxF47zMYudYE1yuxhi//WVHxDJ6glA1iL0zOEbfXWUpCHWpicBK1cc= ARC-Authentication-Results: i=1; server2.sourceware.org DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org D37B43858C48 Received: by mail-wm1-x336.google.com with SMTP id 5b1f17b1804b1-436381876e2so750645e9.1 for ; Thu, 23 Jan 2025 05:43:30 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1737639809; x=1738244609; darn=sourceware.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=u2mQRBx/+ZiwjVwjobQZDD4AkdhP/OtxQUSJe70PGR4=; b=GxGm72gLltn/38/bQTbPel3BrY/blnFQ7Hd+ASWf3OzkK803uFA8AYDddgWpH0Devj YMo5azB95QbL3istIQXcNCxF8pIbgbkoRr4HhthAz6epxd21/URt2zjDAaK0S8XbCEbM G/WbeZy09kI7L2a2MEWPWMK0sNmboDnknYH8phqQpHukm/xdqDOMV75hipIBnaurZ7To ccy1pH02NrwND7WoRcwerwWJWkKFx1Au+l7Rde1sJinXY8XhkGVtAcmRv4oLuS1qhhSe JB3j0lyeTO/Ta80x52INFZQ4gv79ZIQFQJZ7OVHJCfzy3KM4akA3WankGO74bFvT/VtI 0ARg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1737639809; x=1738244609; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=u2mQRBx/+ZiwjVwjobQZDD4AkdhP/OtxQUSJe70PGR4=; b=Wizf9CsTBwZEIQlBYRWXiuoe/+NDm/gFipQngQ212W7GMIc8xdYBKJV5PJFG/XCBzf Ywc69RSN/7B0zOHPMggEDFRxW4Q5wMdW0x1O1jfiKWp2UfYLRLHZkuiABhNl7IwZezhG Zq8iQNbdf45K+uxL8byPH25rB3VjjHqDGOOT6dL/RpvrCSk1+TqLQeYYnU1v3JbwQurE 0n61fS/v0cOCe+nqBd9BnYHLta5Y5ChfRjJtgXFgo8rF+0eMnsfNMlEH2H82LXN6OBVD vjTuudNNVXoZCGulGLj348OOi6cpPBrfbW0K7HBfXAS6m9OiqKl/OBEVuoXaF/buH4Rb xiaw== X-Gm-Message-State: AOJu0Yx4jYXuw8YQHjelPEO9kMODzAUOg9OazWVHnh+0akY07I23kHXP OxBcc/Eg4rbb0t/PpKC+pnPP3lHJoUF/z9iA++DmJjXbTc97k2wdqII3lg== X-Gm-Gg: ASbGnctbVU0s9hJQpkWTNv7eW9Ma8Fp+KRV3asAE53NYp67YTb5frzIyCVe7iKc7IwM Igk6LsejlKBejimVftZHWpg6Rc3TnGImdcPYfyw6fAPFs62HQUFXYFAEhpVAQcbcBmIudkgRLWX wK+UA0zbE120jpt1UVas+3RSGwCwxOtpOotDoFdUrM6kRjnjIcBAigYM2CN7NApXHbWdZ9xCSG3 Uo+x8lD3tdgQXMVVXc/UYuRQgp3szBIYrZsfSKmPpLHHLuNzZIqY9usbBfUb8WlDiU9fTFp44o6 NWX+5a9T/lDdLiXDRfjBPQe0RSC2yBVUCky1pdk= X-Google-Smtp-Source: AGHT+IFsvj8yvsUQj8Gp5X73JtikbaY7/Poi+lDVEERwgjv2z6cMGqofPMWRP6Ys3FuP0jt3UBAfWQ== X-Received: by 2002:a05:600c:3b0d:b0:42c:aeee:80a with SMTP id 5b1f17b1804b1-438b17d5b09mr31197895e9.7.1737639808992; Thu, 23 Jan 2025 05:43:28 -0800 (PST) Received: from L-H2N0CV05D839062.. ([79.175.87.218]) by smtp.googlemail.com with ESMTPSA id 5b1f17b1804b1-438b318c1a2sm64597575e9.7.2025.01.23.05.43.28 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 23 Jan 2025 05:43:28 -0800 (PST) From: Aleksandar Rakic X-Google-Original-From: Aleksandar Rakic To: libc-alpha@sourceware.org Cc: aleksandar.rakic@htecgroup.com, djordje.todorovic@htecgroup.com, cfu@mips.com, Matthew Fortune , Faraz Shahbazker Subject: [PATCH 02/11] Fix rtld link_map initialization issues Date: Thu, 23 Jan 2025 14:42:58 +0100 Message-Id: <20250123134308.1785777-4-aleksandar.rakic@htecgroup.com> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20250123134308.1785777-1-aleksandar.rakic@htecgroup.com> References: <20250123134308.1785777-1-aleksandar.rakic@htecgroup.com> MIME-Version: 1.0 X-Spam-Status: No, score=-7.9 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, FREEMAIL_ENVFROM_END_DIGIT, FREEMAIL_FROM, GIT_PATCH_0, RCVD_IN_BARRACUDACENTRAL, RCVD_IN_DNSWL_NONE, SPF_HELO_NONE, SPF_PASS, TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org X-BeenThere: libc-alpha@sourceware.org X-Mailman-Version: 2.1.30 Precedence: list List-Id: Libc-alpha mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: libc-alpha-bounces~patchwork=sourceware.org@sourceware.org Import patch fixing rtld link_map initialization issues from: https://sourceware.org/ml/libc-alpha/2015-03/msg00704.html Author: Sandra Loosemore Cherry-picked 1507c7be47ef07d4b264168ab031d8c2ed4678f2 from https://github.com/MIPS/glibc Signed-off-by: Matthew Fortune Signed-off-by: Faraz Shahbazker Signed-off-by: Aleksandar Rakic --- elf/rtld.c | 14 ++++++++------ 1 file changed, 8 insertions(+), 6 deletions(-) diff --git a/elf/rtld.c b/elf/rtld.c index 1e2e9ad5a8..252f4d6666 100644 --- a/elf/rtld.c +++ b/elf/rtld.c @@ -522,7 +522,7 @@ _dl_start (void *arg) rtld_timer_start (&info.start_time); #endif - /* Partly clean the `bootstrap_map' structure up. Don't use + /* Zero-initialize the `bootstrap_map' structure. Don't use `memset' since it might not be built in or inlined and we cannot make function calls at this point. Use '__builtin_memset' if we know it is available. We do not have to clear the memory if we @@ -530,12 +530,14 @@ _dl_start (void *arg) are initialized to zero by default. */ #ifndef DONT_USE_BOOTSTRAP_MAP # ifdef HAVE_BUILTIN_MEMSET - __builtin_memset (bootstrap_map.l_info, '\0', sizeof (bootstrap_map.l_info)); + __builtin_memset (&bootstrap_map, '\0', sizeof (struct link_map)); # else - for (size_t cnt = 0; - cnt < sizeof (bootstrap_map.l_info) / sizeof (bootstrap_map.l_info[0]); - ++cnt) - bootstrap_map.l_info[cnt] = 0; + { + char *p = (char *) &bootstrap_map; + char *pend = p + sizeof (struct link_map); + while (p < pend) + *(p++) = '\0'; + } # endif #endif