Message ID | 20250123134308.1785777-13-aleksandar.rakic@htecgroup.com (mailing list archive) |
---|---|
State | New |
Headers |
Return-Path: <libc-alpha-bounces~patchwork=sourceware.org@sourceware.org> X-Original-To: patchwork@sourceware.org Delivered-To: patchwork@sourceware.org Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id 9CAB93858C66 for <patchwork@sourceware.org>; Thu, 23 Jan 2025 13:56:19 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 9CAB93858C66 Authentication-Results: sourceware.org; dkim=pass (2048-bit key, unprotected) header.d=gmail.com header.i=@gmail.com header.a=rsa-sha256 header.s=20230601 header.b=OM06UG/2 X-Original-To: libc-alpha@sourceware.org Delivered-To: libc-alpha@sourceware.org Received: from mail-wm1-x334.google.com (mail-wm1-x334.google.com [IPv6:2a00:1450:4864:20::334]) by sourceware.org (Postfix) with ESMTPS id 049C53858427 for <libc-alpha@sourceware.org>; Thu, 23 Jan 2025 13:43:43 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 049C53858427 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=gmail.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org 049C53858427 Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=2a00:1450:4864:20::334 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1737639823; cv=none; b=M/bs05Tqp8LLRR9PENvIUW9a6vRJCbcjWij5V0M55d73KXlBnr9GWnT+yL8zIBYi7t22GNyzxPfK8HwNb5IT8ifQkrwTFGV35mgA+2S7/W7MDs7JWBhrVwvXSZDHhh/x/Ki4vFT+VM6/E3HVCeK4jICwq5U8GVYSQH7104MssZE= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1737639823; c=relaxed/simple; bh=/v494ncOGJf/uO4Npjv/Jr972paWxbuvQbXKKd/3Yn8=; h=DKIM-Signature:From:To:Subject:Date:Message-Id:MIME-Version; b=R435ALwIgKhkl2j7ZGY6/f8w1v430HTFft3m2lUTMKTVekCBnpJLXn8eKaG/z1kPeE6EUsZ1L7THAjw5kjyD6mWDMkMqVsQla4IMI5nwh9mJDttLnatRdUPysbBrH/WiuikW7rU5kXTjquUqOthg/1WGSsqhAa7/LBf47VeUb6w= ARC-Authentication-Results: i=1; server2.sourceware.org DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 049C53858427 Received: by mail-wm1-x334.google.com with SMTP id 5b1f17b1804b1-436246b1f9bso1021915e9.1 for <libc-alpha@sourceware.org>; Thu, 23 Jan 2025 05:43:42 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1737639821; x=1738244621; darn=sourceware.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=c6ZqDPe4B6tYvQNgZjAm4EqetEF1Azza79AjlEA/kNg=; b=OM06UG/2XScaeoDoTsXceLGqWTQUw10fw2JrNPjGO7bB8Z2QQxrfbuq9L65CukqVw9 G00dyhh47H1eNBEXMuK1L2xl3rNPyNPH925Ty4v7BlaonnqCST7QuUKHEd2IfZjUht3x XvuuclXMW2RDF83Q3nhgzoiuZnCZLyMeR2RxFS5ioS2S3ZCv9iJLpb9WVtdJbK9huTSn Y5cTLf7ML2tfj1u9bN/qwGrSgmuUQij+K4HclF+BmMm3LzEEXDybuAtE5gnQLWhSyg6S JzU3LAg2iYsio5l1DqxVRWnsmsN7JC/F1TKLcd0fzhPu6mK/G8FlC7fk5oIYnvCaTFOk BykQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1737639821; x=1738244621; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=c6ZqDPe4B6tYvQNgZjAm4EqetEF1Azza79AjlEA/kNg=; b=opSdQdZzxThCe8p+a1NcRdad42phDOG4JUF7Dp0bG/PtsYsGHik34npuUwU6HLUiDu W0xfo787elJQSLTYS9/C+m4yaIiG03ZevY8EMQOVNzO+S/rBkVaTlxxKm/z1CX+nMiQ8 QnXlEl/KEgg8O5+M782/WViMisaYzwI5Y3Szjc+ZqMuDth8DQhWylfaL+vx6r9ERaStZ eWQ0EBuvG/bB6qSsTWYWdMKy4WJBUZkl/8YzbbQlCGVo4HNanv5M9KkVUpF7R+S2qQFm Q1OF42b4xSdKGwYoC8QtPbFbevHSa7DVIC35TsRbJmAgiy7Vh+D77WDfrlRXTWninZ3S H+8A== X-Gm-Message-State: AOJu0Yw/YJP7GNW3cZuC+sa2RsTOYvjVvNR+Nyl84vB8iUMKal9wu9ZR Ifmdt9xlsjH9hdgMAP6p9F7nqEKRU3D7gVmKPJxI7rxz/nN5d13dpluRoQ== X-Gm-Gg: ASbGncvFGBlIn3ahzXUpqsYIzhyQimzI9B/c/VqJVgGOL7q7x350L8lYJxvHLvttAbQ oQwytFMaTg1AjuRCqVkVh71IJ4QU4BNBY0n3mbjglxG34nkfJeXt8uGRjA8qvn7+Jcq6n3Z9nTO 3yUN7Y7By4Mns/I7HNvbhGjiaC3H10C6Kspbk/+P0fc9Oa4DuGH2gB8VVabM89jcy8pGtra3TL8 cgH0GVasw3btxh25LD5GVb4hPDJ6MuTOwXDDbp40biJEoiB1e/aUNJelKCy7y57we+KOP13kD5i wjLVayY7a3kYUAsppPem9NZ5exEI X-Google-Smtp-Source: AGHT+IGSaMPkmv1ZgRnZkaPbAZ8WfxUrEsQ0c8CT85XkpV3Ufqgf8jtL40bwvBZAQnNAQcgngOIh6Q== X-Received: by 2002:a05:600c:cc8:b0:42c:aeee:e603 with SMTP id 5b1f17b1804b1-4389db13a7fmr91612895e9.7.1737639821260; Thu, 23 Jan 2025 05:43:41 -0800 (PST) Received: from L-H2N0CV05D839062.. ([79.175.87.218]) by smtp.googlemail.com with ESMTPSA id 5b1f17b1804b1-438b318c1a2sm64597575e9.7.2025.01.23.05.43.40 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 23 Jan 2025 05:43:40 -0800 (PST) From: Aleksandar Rakic <rakicaleksandar1999@gmail.com> X-Google-Original-From: Aleksandar Rakic <aleksandar.rakic@htecgroup.com> To: libc-alpha@sourceware.org Cc: aleksandar.rakic@htecgroup.com, djordje.todorovic@htecgroup.com, cfu@mips.com, Dragan Mladjenovic <dragan.mladjenovic@syrmia.com> Subject: [PATCH 11/11] Prevent turning memset into self-recursion Date: Thu, 23 Jan 2025 14:43:07 +0100 Message-Id: <20250123134308.1785777-13-aleksandar.rakic@htecgroup.com> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20250123134308.1785777-1-aleksandar.rakic@htecgroup.com> References: <20250123134308.1785777-1-aleksandar.rakic@htecgroup.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Spam-Status: No, score=-9.0 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, FREEMAIL_ENVFROM_END_DIGIT, FREEMAIL_FROM, GIT_PATCH_0, RCVD_IN_BARRACUDACENTRAL, RCVD_IN_DNSWL_NONE, SPF_HELO_NONE, SPF_PASS, TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org X-BeenThere: libc-alpha@sourceware.org X-Mailman-Version: 2.1.30 Precedence: list List-Id: Libc-alpha mailing list <libc-alpha.sourceware.org> List-Unsubscribe: <https://sourceware.org/mailman/options/libc-alpha>, <mailto:libc-alpha-request@sourceware.org?subject=unsubscribe> List-Archive: <https://sourceware.org/pipermail/libc-alpha/> List-Post: <mailto:libc-alpha@sourceware.org> List-Help: <mailto:libc-alpha-request@sourceware.org?subject=help> List-Subscribe: <https://sourceware.org/mailman/listinfo/libc-alpha>, <mailto:libc-alpha-request@sourceware.org?subject=subscribe> Errors-To: libc-alpha-bounces~patchwork=sourceware.org@sourceware.org |
Series |
Improve Mips target
|
|
Checks
Context | Check | Description |
---|---|---|
redhat-pt-bot/TryBot-apply_patch | success | Patch applied to master at the time it was sent |
linaro-tcwg-bot/tcwg_glibc_build--master-arm | fail | Patch failed to apply |
linaro-tcwg-bot/tcwg_glibc_build--master-aarch64 | fail | Patch failed to apply |
redhat-pt-bot/TryBot-32bit | fail | Patch series failed to apply |
Commit Message
Aleksandar Rakic
Jan. 23, 2025, 1:43 p.m. UTC
Prevent GCC 11 from turning memset into self-recursion. GCC11 transforms byte-by-byte set loop pattern in memset.c into a memset call, causing runtime failures. Apply -fno-builtin for both the memset.c and memcpy.c to prevent similar bugs in future. Cherry-picked 31906b3556bc18cfdb7a3d84a669d95486450704 from https://github.com/MIPS/glibc Signed-off-by: Dragan Mladjenovic <dragan.mladjenovic@syrmia.com> Signed-off-by: Aleksandar Rakic <aleksandar.rakic@htecgroup.com> --- sysdeps/mips/Makefile | 3 +++ 1 file changed, 3 insertions(+)
Comments
On Thu, 23 Jan 2025, Aleksandar Rakic wrote: > Prevent GCC 11 from turning memset into self-recursion. > GCC11 transforms byte-by-byte set loop pattern in memset.c into > a memset call, causing runtime failures. Apply -fno-builtin for > both the memset.c and memcpy.c to prevent similar bugs in future. We use inhibit_loop_to_libcall to provide __attribute__ ((__optimize__ ("-fno-tree-loop-distribute-patterns"))) in such cases.
diff --git a/sysdeps/mips/Makefile b/sysdeps/mips/Makefile index 17ddc2a97c..4464d73902 100644 --- a/sysdeps/mips/Makefile +++ b/sysdeps/mips/Makefile @@ -24,6 +24,9 @@ ASFLAGS-.o += $(pie-default) ASFLAGS-.op += $(pie-default) ASFLAGS += -O2 +CFLAGS-memset.c += -fno-builtin +CFLAGS-memcpy.c += -fno-builtin + ifeq ($(subdir),elf) # These tests fail on all mips configurations (BZ 29404)