From patchwork Fri Jan 10 18:12:13 2025 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Adhemerval Zanella Netto X-Patchwork-Id: 104521 Return-Path: X-Original-To: patchwork@sourceware.org Delivered-To: patchwork@sourceware.org Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id 7DBA93857B84 for ; Fri, 10 Jan 2025 18:17:14 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 7DBA93857B84 Authentication-Results: sourceware.org; dkim=pass (2048-bit key, unprotected) header.d=linaro.org header.i=@linaro.org header.a=rsa-sha256 header.s=google header.b=Zdu/R3pW X-Original-To: libc-alpha@sourceware.org Delivered-To: libc-alpha@sourceware.org Received: from mail-vk1-xa34.google.com (mail-vk1-xa34.google.com [IPv6:2607:f8b0:4864:20::a34]) by sourceware.org (Postfix) with ESMTPS id 0BCD23858CD9 for ; Fri, 10 Jan 2025 18:15:22 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 0BCD23858CD9 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=linaro.org ARC-Filter: OpenARC Filter v1.0.0 sourceware.org 0BCD23858CD9 Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=2607:f8b0:4864:20::a34 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1736532922; cv=none; b=Sc+ZdFFOJ6fLNnA0lGgd0W2heGalpt7aTz66ZY677NxzW8aQ2bnIa02FkHMOQqt4gyNEb60RGghDHSiCkkyJrcM7TLnP6p2Ndm7NKjJupsSI0uZuWUa/b+UhUXsk57KObNj+Vm3TicHAiQc5yklZbAozTD8QWKitUl5hyAlyEYI= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1736532922; c=relaxed/simple; bh=N9LeVp+z32K4quAHKWPeuUpmSImw06bIY0asYrDTaA4=; h=DKIM-Signature:From:To:Subject:Date:Message-ID:MIME-Version; b=aUfgcz1qHroMCcT66eQiyqUUT6TQ00ePlM3FUslUWAlKMrjCsdA69Ss/CqyRFA79w1n/UWBhIWcPO2mBLIVZzT3UPEPuelQm8nNNBmMa6nVe7Aa6Y1Cf/Si7YBMi65nknfPt91Js6kWFnBe1HlDvUGQhaayDdWrjuR8BLnAuC8g= ARC-Authentication-Results: i=1; server2.sourceware.org DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 0BCD23858CD9 Received: by mail-vk1-xa34.google.com with SMTP id 71dfb90a1353d-51640f7bbd3so855427e0c.2 for ; Fri, 10 Jan 2025 10:15:22 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1736532921; x=1737137721; darn=sourceware.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=4HDh5thW83Ip18sHqW3EDn+UqnXebLtL8s45M0CkvRY=; b=Zdu/R3pWWDRc+yGPK6iWoatGDSfGEEPAWGqScGhtvumGIdEa5zuWVe989/1PqLjTry a9lwKDEvP2KRF1ZI7Kf5i6jLclnt2VF2ffT/X2J0r3grYnNyjs2EK3ni+QtMJz0Pc3Qm pSJX378vQ03hMosg3zDK9rw5AOvfY/nlKZubVrpymT7aCs5yizK1r8ECw5tC3mlMf1YO OA7U8FM7RjXD4ElGnYjaqtlHYX+Q3j0tFYX0Qm+xwuMrQ8cwiezvkSlaMXBuWK9Hcko+ G8tckprHh7x/fKYNM/NECyAfHcPHfT8HxC+M9hPrCY7HL+oY4uGanyBICTtJRhoqakDn VEtA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1736532921; x=1737137721; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=4HDh5thW83Ip18sHqW3EDn+UqnXebLtL8s45M0CkvRY=; b=Sr//8wACsR9H8FhfvjgeLLk2cic9y8mPLGzyK8NkZ4KllSsrXrIF1E2fGd68S5sciY KvM/FGOWIkCjfI5W+DNM9LvyPQyeJkJhwKFikxnNkyplj4jzng78aaVToFJWNZzJcBQr 7yora4Sbx+edd7osQREixs301P+NMVMrCdfetWT1lIKBEncDIbhyh4yC7VINBVNJd38c pAwcNq+ujS6OF0iQv53oRFpCR3NHNb4MbjJOG0Zh1CHEOmYbtMhlKg7WeqpkMXBS8ii6 J/UU2xe34v6cLjrfJVGmzwpZ60D4PRuMeAms//r95kzypo+Pam9pbyhDQOZJJPgwJMCC 1W2A== X-Gm-Message-State: AOJu0YyAU54Xu9EBXr47Hsx14ExlBZ1j07A5bOopByxtbq9nj+6btQPC l5yJuE4JOZMgUCH65s/jwwjlcp/X75Gkml6Wb4JP4UQ1DicqggoKssCALkPTOnqqPYYApTZ8jd3 N X-Gm-Gg: ASbGncv/WZSQ/kBkZif6qMV5TThrKPrCUXAaZkIAFMjudxkYJRDPe3qe1KURWZ7iOzd Zc7W7+kbLUUxanr3SL2FMVKlymqzQvVhwnxkFhNmqIp709PczKVXxOLKJlpw+JFHv86QQEaxLk5 /uLUDZ54Uqw7ePgbFnJ0CPh4zTH7fjHTfepr9vKXakPXNrSmaJFqRop/R3qgj4TzXSQZ2SEPKMH zT4RZ9RmT1qVUBxR5/UcqTVgLPc41vLaWSN0sq195KFJoG4BirhgPqrm8U69KOYoX4sDw== X-Google-Smtp-Source: AGHT+IF2MdZjp397/MNFqlpkXh4Dg+glATo9Gn0IUdKZNbBVgKBsSOiK3P2EY0Q6yN2Hm2RFKI0tRQ== X-Received: by 2002:a05:6122:318a:b0:50c:4707:df0 with SMTP id 71dfb90a1353d-51c6c464f01mr11244687e0c.5.1736532920918; Fri, 10 Jan 2025 10:15:20 -0800 (PST) Received: from ubuntu-vm.. ([191.23.120.207]) by smtp.gmail.com with ESMTPSA id 71dfb90a1353d-51c7fb9d621sm2469139e0c.1.2025.01.10.10.15.19 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 10 Jan 2025 10:15:20 -0800 (PST) From: Adhemerval Zanella To: libc-alpha@sourceware.org Cc: Sam James , "H . J . Lu" Subject: [PATCH v2 3/4] elf: Suppress unused function clang for __ifunc_resolver Date: Fri, 10 Jan 2025 15:12:13 -0300 Message-ID: <20250110181508.350378-4-adhemerval.zanella@linaro.org> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20250110181508.350378-1-adhemerval.zanella@linaro.org> References: <20250110181508.350378-1-adhemerval.zanella@linaro.org> MIME-Version: 1.0 X-Spam-Status: No, score=-12.3 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, GIT_PATCH_0, RCVD_IN_DNSWL_NONE, SPF_HELO_NONE, SPF_PASS, TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org X-BeenThere: libc-alpha@sourceware.org X-Mailman-Version: 2.1.30 Precedence: list List-Id: Libc-alpha mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: libc-alpha-bounces~patchwork=sourceware.org@sourceware.org The __ifunc_resolver macro expands to: extern __typeof (__redirect_name) name __attribute__ ((ifunc ("iname_ifunc"))); static __typeof (__redirect_name) *name_ifunc (void) { [...] }; And although NAME_IFUNC is and alias for NAME, clang-18 still emits an 'unused function 'name_ifunc' [-Werror,-Wunused-function]' warning. --- elf/ifuncmain9.c | 4 ++++ elf/tst-ifunc-fault-lazy.c | 4 ++++ 2 files changed, 8 insertions(+) diff --git a/elf/ifuncmain9.c b/elf/ifuncmain9.c index b2c9547db3..64539b4a86 100644 --- a/elf/ifuncmain9.c +++ b/elf/ifuncmain9.c @@ -22,6 +22,7 @@ #include #include +#include #if __GNUC_PREREQ (5, 5) /* Do not use the test framework, so that the process setup is not @@ -41,6 +42,8 @@ implementation (void) return random_constant; } +DIAG_PUSH_NEEDS_COMMENT_CLANG; +DIAG_IGNORE_NEEDS_COMMENT_CLANG (13, "-Wunused-function"); static __typeof__ (implementation) * inhibit_stack_protector resolver (void) @@ -50,6 +53,7 @@ resolver (void) } static int magic (void) __attribute__ ((ifunc ("resolver"))); +DIAG_POP_NEEDS_COMMENT_CLANG; int main (void) diff --git a/elf/tst-ifunc-fault-lazy.c b/elf/tst-ifunc-fault-lazy.c index c86edde06c..072d2c6a7b 100644 --- a/elf/tst-ifunc-fault-lazy.c +++ b/elf/tst-ifunc-fault-lazy.c @@ -21,6 +21,7 @@ relocations. */ #include +#include #ifdef HAVE_GCC_IFUNC @@ -34,6 +35,8 @@ implementation (void) *p = 0; } +DIAG_PUSH_NEEDS_COMMENT_CLANG; +DIAG_IGNORE_NEEDS_COMMENT_CLANG (13, "-Wunused-function"); static __typeof__ (implementation) * resolver (void) { @@ -42,6 +45,7 @@ resolver (void) *p = 0; return implementation; } +DIAG_POP_NEEDS_COMMENT_CLANG; static void magic (void) __attribute__ ((ifunc ("resolver")));