Message ID | 20250103154141.47731-20-yury.khrustalev@arm.com (mailing list archive) |
---|---|
State | Superseded |
Headers |
Return-Path: <libc-alpha-bounces~patchwork=sourceware.org@sourceware.org> X-Original-To: patchwork@sourceware.org Delivered-To: patchwork@sourceware.org Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id 881A13858428 for <patchwork@sourceware.org>; Fri, 3 Jan 2025 15:51:56 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 881A13858428 X-Original-To: libc-alpha@sourceware.org Delivered-To: libc-alpha@sourceware.org Received: from foss.arm.com (foss.arm.com [217.140.110.172]) by sourceware.org (Postfix) with ESMTP id 0C5043858414 for <libc-alpha@sourceware.org>; Fri, 3 Jan 2025 15:43:38 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 0C5043858414 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=arm.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=arm.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org 0C5043858414 Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=217.140.110.172 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1735919018; cv=none; b=mQOA+W93WadKpmwcltwGpF7xszqP163Qr/DMbqeyH3dUQPg8M9jPslr5DTbl5pKi4S4DTZu6ReiO0Qr9yrY67uU6yG0OnSh4POQolB9hbM4+JSULPFoEmglYrv/OoJQmvt3OtmOY9bckSKoM6iFOUGDjk/pWlyc1iavojk7Oq7o= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1735919018; c=relaxed/simple; bh=olEFHpFdpRGWawLpspEC+zpmVbOcqHl0ynn6np8pdcE=; h=From:To:Subject:Date:Message-Id:MIME-Version; b=Jd0n7C1pwueC8QFRLeUbSKNcWCoVN8CNY6Qh2uEhMugJp+poyaq6IMG/BU1zaO9cyuZTKVbWyvgBdDooB337WI8t8GuAR3aI7sf07M/f1hlrHbcIakCRLX9p1vw/T7Gjk7Ji5//wsUcphB7L+8RmXBiZFiV3ETaIoUPGr5aLl9E= ARC-Authentication-Results: i=1; server2.sourceware.org DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 0C5043858414 Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 0E3D11480; Fri, 3 Jan 2025 07:44:06 -0800 (PST) Received: from udebian.localdomain (unknown [10.57.3.206]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id E4BBE3F6A8; Fri, 3 Jan 2025 07:43:36 -0800 (PST) From: Yury Khrustalev <yury.khrustalev@arm.com> To: libc-alpha@sourceware.org Cc: fweimer@redhat.com, adhemerval.zanella@linaro.org, codonell@redhat.com, nsz@gcc.gnu.org, schwab@suse.de, wilco.dijkstra@arm.com Subject: [PATCH v7 19/23] aarch64: Ignore GCS property of ld.so Date: Fri, 3 Jan 2025 15:41:37 +0000 Message-Id: <20250103154141.47731-20-yury.khrustalev@arm.com> X-Mailer: git-send-email 2.39.5 In-Reply-To: <20250103154141.47731-1-yury.khrustalev@arm.com> References: <20250103154141.47731-1-yury.khrustalev@arm.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Spam-Status: No, score=-13.3 required=5.0 tests=BAYES_00, GIT_PATCH_0, KAM_DMARC_NONE, KAM_DMARC_STATUS, KAM_LAZY_DOMAIN_SECURITY, SPF_HELO_NONE, SPF_NONE, TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org X-BeenThere: libc-alpha@sourceware.org X-Mailman-Version: 2.1.30 Precedence: list List-Id: Libc-alpha mailing list <libc-alpha.sourceware.org> List-Unsubscribe: <https://sourceware.org/mailman/options/libc-alpha>, <mailto:libc-alpha-request@sourceware.org?subject=unsubscribe> List-Archive: <https://sourceware.org/pipermail/libc-alpha/> List-Post: <mailto:libc-alpha@sourceware.org> List-Help: <mailto:libc-alpha-request@sourceware.org?subject=help> List-Subscribe: <https://sourceware.org/mailman/listinfo/libc-alpha>, <mailto:libc-alpha-request@sourceware.org?subject=subscribe> Errors-To: libc-alpha-bounces~patchwork=sourceware.org@sourceware.org |
Series |
aarch64: Add support for Guarded Control Stack extension
|
|
Checks
Context | Check | Description |
---|---|---|
redhat-pt-bot/TryBot-apply_patch | success | Patch applied to master at the time it was sent |
Commit Message
Yury Khrustalev
Jan. 3, 2025, 3:41 p.m. UTC
From: Szabolcs Nagy <szabolcs.nagy@arm.com> check_gcs is called for each dependency of a DSO, but the GNU property of the ld.so is not processed so ldso->l_mach.gcs may not be correct. Just assume ld.so is GCS compatible independently of the ELF marking. Reviewed-by: Wilco Dijkstra <Wilco.Dijkstra@arm.com> --- sysdeps/aarch64/dl-gcs.c | 5 +++++ 1 file changed, 5 insertions(+)
diff --git a/sysdeps/aarch64/dl-gcs.c b/sysdeps/aarch64/dl-gcs.c index dc62908d13..c4751ec3e8 100644 --- a/sysdeps/aarch64/dl-gcs.c +++ b/sysdeps/aarch64/dl-gcs.c @@ -40,6 +40,11 @@ unsupported (void) static void check_gcs (struct link_map *l, const char *program) { +#ifdef SHARED + /* Ignore GCS marking on ld.so: its properties are not processed. */ + if (is_rtld_link_map (l->l_real)) + return; +#endif bool for_dlopen = program == NULL; if (!l->l_mach.gcs) {