diff mbox series

nptl: Add <thread_pointer.h> for or1k

Message ID 20241101192339.123141-5-mjeanson@efficios.com
State New
Headers
Series nptl: Add <thread_pointer.h> for or1k |

Checks

Context Check Description
redhat-pt-bot/TryBot-apply_patch success Patch applied to master at the time it was sent
linaro-tcwg-bot/tcwg_glibc_build--master-arm success Build passed
linaro-tcwg-bot/tcwg_glibc_build--master-aarch64 success Build passed
redhat-pt-bot/TryBot-32bit success Build for i686
linaro-tcwg-bot/tcwg_glibc_check--master-aarch64 success Test passed
linaro-tcwg-bot/tcwg_glibc_check--master-arm success Test passed

Commit Message

Michael Jeanson Nov. 1, 2024, 7:23 p.m. UTC 
  This will be required by the rseq extensible ABI implementation on all
Linux architectures exposing the '__rseq_size' and '__rseq_offset'
symbols to set the initial value of the 'cpu_id' field which can be used
by applications to test if rseq is available and registered. As long as
the symbols are exposed it is valid for an application to perform this
test even if rseq is not yet implemented in libc for this architecture.

Compile tested with build-many-glibcs.py but I don't have access to any
hardware to run the tests.

Signed-off-by: Michael Jeanson <mjeanson@efficios.com>
---
Cc: Florian Weimer <fweimer@redhat.com>
Cc: Stafford Horne <shorne@gmail.com>
---
 sysdeps/or1k/nptl/thread_pointer.h | 30 ++++++++++++++++++++++++++++++
 1 file changed, 30 insertions(+)
 create mode 100644 sysdeps/or1k/nptl/thread_pointer.h

Comments

Stafford Horne Nov. 11, 2024, 9:59 p.m. UTC | #1 
On Fri, Nov 01, 2024 at 03:23:24PM -0400, Michael Jeanson wrote:
> This will be required by the rseq extensible ABI implementation on all
> Linux architectures exposing the '__rseq_size' and '__rseq_offset'
> symbols to set the initial value of the 'cpu_id' field which can be used
> by applications to test if rseq is available and registered. As long as
> the symbols are exposed it is valid for an application to perform this
> test even if rseq is not yet implemented in libc for this architecture.
> 
> Compile tested with build-many-glibcs.py but I don't have access to any
> hardware to run the tests.

Hello,

Thanks for this.  I am away on a long business trip so not having much time to
work on this right now.  I will be back next week and Ill get some time to sit
down and test this.

I will push the commit if all looks and works fine.  At the moment OpenRISC
doesn't have support for rseq, I started adding support for it a while ago but
didn't finish as the in kernel testing suite was taking too long to get setup.
Now that there is support in glibc it should be much easier to test the linux
support.

So, thanks a lot for this.

-Stafford

> Signed-off-by: Michael Jeanson <mjeanson@efficios.com>
> ---
> Cc: Florian Weimer <fweimer@redhat.com>
> Cc: Stafford Horne <shorne@gmail.com>
> ---
>  sysdeps/or1k/nptl/thread_pointer.h | 30 ++++++++++++++++++++++++++++++
>  1 file changed, 30 insertions(+)
>  create mode 100644 sysdeps/or1k/nptl/thread_pointer.h
> 
> diff --git a/sysdeps/or1k/nptl/thread_pointer.h b/sysdeps/or1k/nptl/thread_pointer.h
> new file mode 100644
> index 0000000000..1012794c48
> --- /dev/null
> +++ b/sysdeps/or1k/nptl/thread_pointer.h
> @@ -0,0 +1,30 @@
> +/* __thread_pointer definition.  or1k version.
> +   Copyright (C) 2021-2024 Free Software Foundation, Inc.
> +   This file is part of the GNU C Library.
> +
> +   The GNU C Library is free software; you can redistribute it and/or
> +   modify it under the terms of the GNU Lesser General Public
> +   License as published by the Free Software Foundation; either
> +   version 2.1 of the License, or (at your option) any later version.
> +
> +   The GNU C Library is distributed in the hope that it will be useful,
> +   but WITHOUT ANY WARRANTY; without even the implied warranty of
> +   MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the GNU
> +   Lesser General Public License for more details.
> +
> +   You should have received a copy of the GNU Lesser General Public
> +   License along with the GNU C Library.  If not, see
> +   <https://www.gnu.org/licenses/>.  */
> +
> +#ifndef _SYS_THREAD_POINTER_H
> +#define _SYS_THREAD_POINTER_H
> +
> +static inline void *
> +__thread_pointer (void)
> +{
> +  void *__thread_register;
> +  __asm__ ("l.or %0, r10, r0" : "=r" (__thread_register));
> +  return __thread_register;
> +}
> +
> +#endif /* _SYS_THREAD_POINTER_H */
> -- 
> 2.43.0
>
diff mbox series

Patch

diff --git a/sysdeps/or1k/nptl/thread_pointer.h b/sysdeps/or1k/nptl/thread_pointer.h
new file mode 100644
index 0000000000..1012794c48
--- /dev/null
+++ b/sysdeps/or1k/nptl/thread_pointer.h
@@ -0,0 +1,30 @@ 
+/* __thread_pointer definition.  or1k version.
+   Copyright (C) 2021-2024 Free Software Foundation, Inc.
+   This file is part of the GNU C Library.
+
+   The GNU C Library is free software; you can redistribute it and/or
+   modify it under the terms of the GNU Lesser General Public
+   License as published by the Free Software Foundation; either
+   version 2.1 of the License, or (at your option) any later version.
+
+   The GNU C Library is distributed in the hope that it will be useful,
+   but WITHOUT ANY WARRANTY; without even the implied warranty of
+   MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the GNU
+   Lesser General Public License for more details.
+
+   You should have received a copy of the GNU Lesser General Public
+   License along with the GNU C Library.  If not, see
+   <https://www.gnu.org/licenses/>.  */
+
+#ifndef _SYS_THREAD_POINTER_H
+#define _SYS_THREAD_POINTER_H
+
+static inline void *
+__thread_pointer (void)
+{
+  void *__thread_register;
+  __asm__ ("l.or %0, r10, r0" : "=r" (__thread_register));
+  return __thread_register;
+}
+
+#endif /* _SYS_THREAD_POINTER_H */