sysdeps/x86_64/dl-machine.h: Add space for ease of retrieval

Message ID 20240527014759.6586-1-yw987194828@gmail.com
State Changes Requested
Headers
Series sysdeps/x86_64/dl-machine.h: Add space for ease of retrieval |

Checks

Context Check Description
redhat-pt-bot/TryBot-apply_patch success Patch applied to master at the time it was sent
redhat-pt-bot/TryBot-32bit success Build for i686
linaro-tcwg-bot/tcwg_glibc_build--master-arm success Testing passed
linaro-tcwg-bot/tcwg_glibc_check--master-arm success Testing passed
linaro-tcwg-bot/tcwg_glibc_build--master-aarch64 success Testing passed
linaro-tcwg-bot/tcwg_glibc_check--master-aarch64 success Testing passed

Commit Message

Xin Wang May 27, 2024, 1:47 a.m. UTC
  A space is added before the left bracket of the ia64 elf_machine_rela
function, in order to harmonize with the rest of the implementation of
the function and to make it easier to retrieve the function.

Signed-off-by: Xin Wang <yw987194828@gmail.com>
---
 sysdeps/x86_64/dl-machine.h | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
  

Comments

Florian Weimer May 27, 2024, 1:08 p.m. UTC | #1
* Xin Wang:

> A space is added before the left bracket of the ia64 elf_machine_rela
> function, in order to harmonize with the rest of the implementation of
> the function and to make it easier to retrieve the function.
>
> Signed-off-by: Xin Wang <yw987194828@gmail.com>
---
>  sysdeps/x86_64/dl-machine.h | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/sysdeps/x86_64/dl-machine.h b/sysdeps/x86_64/dl-machine.h
> index ff5d45f7cb..1088267691 100644
> --- a/sysdeps/x86_64/dl-machine.h
> +++ b/sysdeps/x86_64/dl-machine.h
> @@ -245,7 +245,7 @@ elf_machine_plt_value (struct link_map *map, const ElfW(Rela) *reloc,
>     MAP is the object containing the reloc.  */
>  
>  static inline void __attribute__((always_inline))
> -elf_machine_rela(struct link_map *map, struct r_scope_elem *scope[],
> +elf_machine_rela (struct link_map *map, struct r_scope_elem *scope[],
>  		 const ElfW(Rela) *reloc, const ElfW(Sym) *sym,
>  		 const struct r_found_version *version,
>  		 void *const reloc_addr_arg, int skip_ifunc) {

Please re-indent the following lines as well.

Thanks,
Florian
  
Andreas Schwab May 27, 2024, 1:15 p.m. UTC | #2
On Mai 27 2024, Florian Weimer wrote:

> * Xin Wang:
>
>> A space is added before the left bracket of the ia64 elf_machine_rela
>> function, in order to harmonize with the rest of the implementation of
>> the function and to make it easier to retrieve the function.
>>
>> Signed-off-by: Xin Wang <yw987194828@gmail.com>
> ---
>>  sysdeps/x86_64/dl-machine.h | 2 +-
>>  1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/sysdeps/x86_64/dl-machine.h b/sysdeps/x86_64/dl-machine.h
>> index ff5d45f7cb..1088267691 100644
>> --- a/sysdeps/x86_64/dl-machine.h
>> +++ b/sysdeps/x86_64/dl-machine.h
>> @@ -245,7 +245,7 @@ elf_machine_plt_value (struct link_map *map, const ElfW(Rela) *reloc,
>>     MAP is the object containing the reloc.  */
>>  
>>  static inline void __attribute__((always_inline))
>> -elf_machine_rela(struct link_map *map, struct r_scope_elem *scope[],
>> +elf_machine_rela (struct link_map *map, struct r_scope_elem *scope[],
>>  		 const ElfW(Rela) *reloc, const ElfW(Sym) *sym,
>>  		 const struct r_found_version *version,
>>  		 void *const reloc_addr_arg, int skip_ifunc) {
>
> Please re-indent the following lines as well.

Including the misplaced brace.
  
Xi Ruoyao May 27, 2024, 1:18 p.m. UTC | #3
On Mon, 2024-05-27 at 15:15 +0200, Andreas Schwab wrote:
> On Mai 27 2024, Florian Weimer wrote:
> 
> > * Xin Wang:
> > 
> > > A space is added before the left bracket of the ia64 elf_machine_rela

Please reword the commit message: ia64 is not supported by Glibc (as at
now) and it's completely different from x86_64.

> > > function, in order to harmonize with the rest of the implementation of
> > > the function and to make it easier to retrieve the function.
> > > 
> > > Signed-off-by: Xin Wang <yw987194828@gmail.com>
> > ---
> > >  sysdeps/x86_64/dl-machine.h | 2 +-
> > >  1 file changed, 1 insertion(+), 1 deletion(-)
> > > 
> > > diff --git a/sysdeps/x86_64/dl-machine.h b/sysdeps/x86_64/dl-machine.h
> > > index ff5d45f7cb..1088267691 100644
> > > --- a/sysdeps/x86_64/dl-machine.h
> > > +++ b/sysdeps/x86_64/dl-machine.h
> > > @@ -245,7 +245,7 @@ elf_machine_plt_value (struct link_map *map, const ElfW(Rela) *reloc,
> > >     MAP is the object containing the reloc.  */
> > >  
> > >  static inline void __attribute__((always_inline))
> > > -elf_machine_rela(struct link_map *map, struct r_scope_elem *scope[],
> > > +elf_machine_rela (struct link_map *map, struct r_scope_elem *scope[],
> > >  		 const ElfW(Rela) *reloc, const ElfW(Sym) *sym,
> > >  		 const struct r_found_version *version,
> > >  		 void *const reloc_addr_arg, int skip_ifunc) {
> > 
> > Please re-indent the following lines as well.
> 
> Including the misplaced brace.
>
  

Patch

diff --git a/sysdeps/x86_64/dl-machine.h b/sysdeps/x86_64/dl-machine.h
index ff5d45f7cb..1088267691 100644
--- a/sysdeps/x86_64/dl-machine.h
+++ b/sysdeps/x86_64/dl-machine.h
@@ -245,7 +245,7 @@  elf_machine_plt_value (struct link_map *map, const ElfW(Rela) *reloc,
    MAP is the object containing the reloc.  */
 
 static inline void __attribute__((always_inline))
-elf_machine_rela(struct link_map *map, struct r_scope_elem *scope[],
+elf_machine_rela (struct link_map *map, struct r_scope_elem *scope[],
 		 const ElfW(Rela) *reloc, const ElfW(Sym) *sym,
 		 const struct r_found_version *version,
 		 void *const reloc_addr_arg, int skip_ifunc) {