[v3] support: Fix typo in xgetsockname error message

Message ID 20240517153152.2034375-1-avinal.xlvii@gmail.com
State Committed
Commit 54c1efdac55b756a4e2ea95590bcc3ba396a6568
Headers
Series [v3] support: Fix typo in xgetsockname error message |

Checks

Context Check Description
redhat-pt-bot/TryBot-apply_patch success Patch applied to master at the time it was sent
redhat-pt-bot/TryBot-32bit success Build for i686
linaro-tcwg-bot/tcwg_glibc_build--master-aarch64 success Testing passed
linaro-tcwg-bot/tcwg_glibc_check--master-aarch64 success Testing passed
linaro-tcwg-bot/tcwg_glibc_build--master-arm success Testing passed
linaro-tcwg-bot/tcwg_glibc_check--master-arm success Testing passed

Commit Message

Avinal Kumar May 17, 2024, 3:28 p.m. UTC
  The error message in xgetsockname was incorrectly referring to a
different function.  This commit fixes that.

Suggested-by: Arjun Shankar <arjun@redhat.com>
Signed-off-by: Avinal Kumar <avinal.xlvii@gmail.com>
---
Changes to v2:
* Added copyright statement

Changes to v1:
* Updated correct DCO signoff.

I misunderstood the first time what was meant by updating copyright
statement. I have fixed that now. 
---
 support/xgetsockname.c | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)
  

Comments

Carlos O'Donell June 5, 2024, 1:58 p.m. UTC | #1
On 5/17/24 11:28 AM, Avinal Kumar wrote:
> The error message in xgetsockname was incorrectly referring to a
> different function.  This commit fixes that.
> 
> Suggested-by: Arjun Shankar <arjun@redhat.com>
> Signed-off-by: Avinal Kumar <avinal.xlvii@gmail.com>

Perfect. LGTM.

I'll push this for you. Thank you again for contributing!

Reviewed-by: Carlos O'Donell <carlos@redhat.com>

> ---
> Changes to v2:
> * Added copyright statement
> 
> Changes to v1:
> * Updated correct DCO signoff.
> 
> I misunderstood the first time what was meant by updating copyright
> statement. I have fixed that now. 
> ---
>  support/xgetsockname.c | 3 ++-
>  1 file changed, 2 insertions(+), 1 deletion(-)
> 
> diff --git a/support/xgetsockname.c b/support/xgetsockname.c
> index fd1a42ea1e..7848046d23 100644
> --- a/support/xgetsockname.c
> +++ b/support/xgetsockname.c
> @@ -1,5 +1,6 @@
>  /* getsockname with error checking.
>     Copyright (C) 2016-2024 Free Software Foundation, Inc.
> +   Copyright The GNU Toolchain Authors.
>     This file is part of the GNU C Library.
>  
>     The GNU C Library is free software; you can redistribute it and/or
> @@ -26,5 +27,5 @@ void
>  xgetsockname (int fd, struct sockaddr *sa, socklen_t *plen)
>  {
>    if (getsockname (fd, sa, plen) != 0)
> -    FAIL_EXIT1 ("setsockopt (%d): %m", fd);
> +    FAIL_EXIT1 ("getsockname (%d): %m", fd);
>  }
  

Patch

diff --git a/support/xgetsockname.c b/support/xgetsockname.c
index fd1a42ea1e..7848046d23 100644
--- a/support/xgetsockname.c
+++ b/support/xgetsockname.c
@@ -1,5 +1,6 @@ 
 /* getsockname with error checking.
    Copyright (C) 2016-2024 Free Software Foundation, Inc.
+   Copyright The GNU Toolchain Authors.
    This file is part of the GNU C Library.
 
    The GNU C Library is free software; you can redistribute it and/or
@@ -26,5 +27,5 @@  void
 xgetsockname (int fd, struct sockaddr *sa, socklen_t *plen)
 {
   if (getsockname (fd, sa, plen) != 0)
-    FAIL_EXIT1 ("setsockopt (%d): %m", fd);
+    FAIL_EXIT1 ("getsockname (%d): %m", fd);
 }