diff mbox series

[v2,3/3] build-many-glibcs.py: Add openrisc hard float glibc variant

Message ID 20240429054735.2467433-4-shorne@gmail.com
State Committed
Commit ea73eb5f581ef5931fd67005aa0c526ba43366c9
Delegated to: Adhemerval Zanella Netto
Headers
Series OpenRISC glibc hard float support |

Checks

Context Check Description
redhat-pt-bot/TryBot-apply_patch success Patch applied to master at the time it was sent
redhat-pt-bot/TryBot-32bit success Build for i686
linaro-tcwg-bot/tcwg_glibc_build--master-arm success Testing passed
linaro-tcwg-bot/tcwg_glibc_build--master-aarch64 success Testing passed
linaro-tcwg-bot/tcwg_glibc_check--master-arm success Testing passed
linaro-tcwg-bot/tcwg_glibc_check--master-aarch64 success Testing passed

Commit Message

Stafford Horne April 29, 2024, 5:47 a.m. UTC 
  This adds the OpenRISC hard float glibc variant to the build many
script.  We update the compiler for glibc to support hard-float
multilibs to allow us to use a single generic compiler for all glibc
variants, this requires updating the compiler name.

Tested and all builds are passing.
---
Since v1:
 - No change

 scripts/build-many-glibcs.py | 5 +++--
 1 file changed, 3 insertions(+), 2 deletions(-)

Comments

Adhemerval Zanella Netto May 2, 2024, 6:46 p.m. UTC | #1 
On 29/04/24 02:47, Stafford Horne wrote:
> This adds the OpenRISC hard float glibc variant to the build many
> script.  We update the compiler for glibc to support hard-float
> multilibs to allow us to use a single generic compiler for all glibc
> variants, this requires updating the compiler name.
> 
> Tested and all builds are passing.

LGTM, thanks.

Reviewed-by: Adhemerval Zanella  <adhemerval.zanella@linaro.org>

> ---
> Since v1:
>  - No change
> 
>  scripts/build-many-glibcs.py | 5 +++--
>  1 file changed, 3 insertions(+), 2 deletions(-)
> 
> diff --git a/scripts/build-many-glibcs.py b/scripts/build-many-glibcs.py
> index 35dac538e5..38eb9f2dd2 100755
> --- a/scripts/build-many-glibcs.py
> +++ b/scripts/build-many-glibcs.py
> @@ -362,8 +362,9 @@ class Context(object):
>                          gcc_cfg=['--enable-obsolete'])
>          self.add_config(arch='or1k',
>                          os_name='linux-gnu',
> -                        variant='soft',
> -                        gcc_cfg=['--with-multilib-list=mcmov'])
> +                        gcc_cfg=['--with-multilib-list=mcmov,mhard-float'],
> +                        glibcs=[{'variant': 'soft'},
> +                                {'variant': 'hard', 'ccopts': '-mhard-float'}])
>          self.add_config(arch='powerpc',
>                          os_name='linux-gnu',
>                          gcc_cfg=['--disable-multilib', '--enable-secureplt'],
diff mbox series

Patch

diff --git a/scripts/build-many-glibcs.py b/scripts/build-many-glibcs.py
index 35dac538e5..38eb9f2dd2 100755
--- a/scripts/build-many-glibcs.py
+++ b/scripts/build-many-glibcs.py
@@ -362,8 +362,9 @@  class Context(object):
                         gcc_cfg=['--enable-obsolete'])
         self.add_config(arch='or1k',
                         os_name='linux-gnu',
-                        variant='soft',
-                        gcc_cfg=['--with-multilib-list=mcmov'])
+                        gcc_cfg=['--with-multilib-list=mcmov,mhard-float'],
+                        glibcs=[{'variant': 'soft'},
+                                {'variant': 'hard', 'ccopts': '-mhard-float'}])
         self.add_config(arch='powerpc',
                         os_name='linux-gnu',
                         gcc_cfg=['--disable-multilib', '--enable-secureplt'],