From patchwork Fri Feb 16 15:17:10 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: "H.J. Lu" X-Patchwork-Id: 85885 Return-Path: X-Original-To: patchwork@sourceware.org Delivered-To: patchwork@sourceware.org Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id 12AA43857C62 for ; Fri, 16 Feb 2024 15:17:47 +0000 (GMT) X-Original-To: libc-alpha@sourceware.org Delivered-To: libc-alpha@sourceware.org Received: from mail-pj1-x102e.google.com (mail-pj1-x102e.google.com [IPv6:2607:f8b0:4864:20::102e]) by sourceware.org (Postfix) with ESMTPS id 3E524385800B for ; Fri, 16 Feb 2024 15:17:14 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 3E524385800B Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=gmail.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org 3E524385800B Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=2607:f8b0:4864:20::102e ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1708096637; cv=none; b=mE5qYd38kOWy9e/uUjLqKK0o8P6SR/Lmm9b1HR7fhaN5PkEDM5g2TSYidJxTgH4vePrOYIlYdclELVPasY+YUMEtztvzJnDoiszkyKvBfuLfxICSFQhNjV6aeUlpm2bNp6CMgV39f0D7Zi19vmDKM+dtx9rHlwFV4o/DvIMn/Nk= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1708096637; c=relaxed/simple; bh=AmaP4NBSXAjWXAYjyDLvotKTsvmbnDa8aVZcFGCSD0g=; h=DKIM-Signature:From:To:Subject:Date:Message-ID:MIME-Version; b=JoDP1jzrcnWaD/8EobC7Z7YDvcjAmo4TnDgZkjz4unNH8wkhELhzTmRST1ZQSOUnZO1oRkhKsntYxGhlnm9+ZPy70kB+9bijDv4JdyqvTtiyaQxOnhCeR+wfnyBPWzR0dLn9iZg1d/prCkaDvQk9K2wjAh6DEC/k0f5Ekbk8uQc= ARC-Authentication-Results: i=1; server2.sourceware.org Received: by mail-pj1-x102e.google.com with SMTP id 98e67ed59e1d1-297108e7001so1729931a91.1 for ; Fri, 16 Feb 2024 07:17:14 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1708096633; x=1708701433; darn=sourceware.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=IFv6teZ6H/OJP5DU8POwM4h+WqkzO/3BTNGGL2IqGjo=; b=ZNsRo0RpEPFWml5yudmfySI/79Xr2JTCwS0NKZAmVE9KXIZkI2WiDop8M5f6uboFfN K4D5MOTNT/gsBt7YVT11TNxrqYZ+mOxM8qSjsmZvoa3ZWy+qWoCeKzdaeCmMArdBDJos ZGki18OaOq9qBMyk3M/xpjlHF1HpRkzb+ldbif08kaTWVsKIazgumXc0/sKiHfWiDeZD dHL/7DKqV1BrYOusk9LnIt+E5vTboe1DWKYIFE2gPNriZVMFehszwd0y+rgBNtfgQnwz 4M3/f6ZQ52CP7M9EPr0rdV/nrr3kfOSiN7orSYw6m1xpvxlP+WYUuC0QMh+X2q5WStXz nRpA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1708096633; x=1708701433; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=IFv6teZ6H/OJP5DU8POwM4h+WqkzO/3BTNGGL2IqGjo=; b=q1XtKgKlPXRrthBlc9lN4hGCx/xtS0qbfOdjTg9+EejdN5uAX8dXUUd2kYdZnLgS9/ t8+zJ99A3V7zu96ns/c8i/1s7WWN/9YOMtINAN6v6R8FdRiQLRhGlNgo9wT8ZxuhrLU5 VpABFjsenSmUzgTJH+gUIl3mV7PgYtwufhjcsDfFmik8Q5cwxmsGvzDBOzNwxMnSJqq2 E11BvU4BET5ltrjDVGblBn9bY4fMXMhGfUMwLW9/ceg5ZRIxd1mS8PQ/wp7tZ8Z1dTo1 uKETET0CSuQSX+tdBKDxMXNF+ej734rzxWnvxdJUORrAhWNH6BP/JBXDAJIUN/681ba+ 7h+w== X-Gm-Message-State: AOJu0YyT2WPDkAN/w4Vz/SV8wTCod/7QYdPX23b7c3TEZGBe2t2kmUKf y6h1YEfSB+pMfjDZX1Jh7iU3FA4LNMIcJKCI4tZr3yXhIdPwOjIzEPS5r/WV X-Google-Smtp-Source: AGHT+IEBwtWO/dXmlZADbE7nbeVIqUJWrRdG4g+E3C1mjveivJHSMILKOTOvl8CdN20zgGvbhp1jnA== X-Received: by 2002:a17:90a:1784:b0:299:3781:4871 with SMTP id q4-20020a17090a178400b0029937814871mr1472727pja.37.1708096633096; Fri, 16 Feb 2024 07:17:13 -0800 (PST) Received: from gnu-cfl-3.localdomain ([172.58.89.72]) by smtp.gmail.com with ESMTPSA id hg14-20020a17090b300e00b0029948eca3e6sm101709pjb.45.2024.02.16.07.17.12 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 16 Feb 2024 07:17:12 -0800 (PST) Received: from gnu-cfl-3.. (localhost [IPv6:::1]) by gnu-cfl-3.localdomain (Postfix) with ESMTP id 8549D740257; Fri, 16 Feb 2024 07:17:11 -0800 (PST) From: "H.J. Lu" To: libc-alpha@sourceware.org Cc: goldstein.w.n@gmail.com, fweimer@redhat.com, adhemerval.zanella@linaro.org Subject: [PATCH v8 1/2] x86-64: Save APX registers in ld.so trampoline Date: Fri, 16 Feb 2024 07:17:10 -0800 Message-ID: <20240216151711.2742988-2-hjl.tools@gmail.com> X-Mailer: git-send-email 2.43.2 In-Reply-To: <20240216151711.2742988-1-hjl.tools@gmail.com> References: <20240216151711.2742988-1-hjl.tools@gmail.com> MIME-Version: 1.0 X-Spam-Status: No, score=-3019.8 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, FREEMAIL_FROM, GIT_PATCH_0, RCVD_IN_ABUSEAT, RCVD_IN_DNSWL_NONE, RCVD_IN_SBL_CSS, SPF_HELO_NONE, SPF_PASS, TXREP, T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org X-BeenThere: libc-alpha@sourceware.org X-Mailman-Version: 2.1.30 Precedence: list List-Id: Libc-alpha mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: libc-alpha-bounces+patchwork=sourceware.org@sourceware.org Add APX registers to STATE_SAVE_MASK so that APX registers are saved in ld.so trampoline. This fixes BZ #31371. Also update STATE_SAVE_OFFSET and STATE_SAVE_MASK for i386 which will be used by i386 _dl_tlsdesc_dynamic. Reviewed-by: Noah Goldstein --- sysdeps/x86/sysdep.h | 52 +++++++++++++++++++++++++++++++++++++++----- 1 file changed, 46 insertions(+), 6 deletions(-) diff --git a/sysdeps/x86/sysdep.h b/sysdeps/x86/sysdep.h index 85d0a8c943..837fd28734 100644 --- a/sysdeps/x86/sysdep.h +++ b/sysdeps/x86/sysdep.h @@ -21,14 +21,54 @@ #include +/* The extended state feature IDs in the state component bitmap. */ +#define X86_XSTATE_X87_ID 0 +#define X86_XSTATE_SSE_ID 1 +#define X86_XSTATE_AVX_ID 2 +#define X86_XSTATE_BNDREGS_ID 3 +#define X86_XSTATE_BNDCFG_ID 4 +#define X86_XSTATE_K_ID 5 +#define X86_XSTATE_ZMM_H_ID 6 +#define X86_XSTATE_ZMM_ID 7 +#define X86_XSTATE_PKRU_ID 9 +#define X86_XSTATE_TILECFG_ID 17 +#define X86_XSTATE_TILEDATA_ID 18 +#define X86_XSTATE_APX_F_ID 19 + +#ifdef __x86_64__ /* Offset for fxsave/xsave area used by _dl_runtime_resolve. Also need space to preserve RCX, RDX, RSI, RDI, R8, R9 and RAX. It must be - aligned to 16 bytes for fxsave and 64 bytes for xsave. */ -#define STATE_SAVE_OFFSET (8 * 7 + 8) - -/* Save SSE, AVX, AVX512, mask and bound registers. */ -#define STATE_SAVE_MASK \ - ((1 << 1) | (1 << 2) | (1 << 3) | (1 << 5) | (1 << 6) | (1 << 7)) + aligned to 16 bytes for fxsave and 64 bytes for xsave. + + NB: Is is non-zero because of the 128-byte red-zone. Some registers + are saved on stack without adjusting stack pointer first. When we + update stack pointer to allocate more space, we need to take the + red-zone into account. */ +# define STATE_SAVE_OFFSET (8 * 7 + 8) + +/* Save SSE, AVX, AVX512, mask, bound and APX registers. Bound and APX + registers are mutually exclusive. */ +# define STATE_SAVE_MASK \ + ((1 << X86_XSTATE_SSE_ID) \ + | (1 << X86_XSTATE_AVX_ID) \ + | (1 << X86_XSTATE_BNDREGS_ID) \ + | (1 << X86_XSTATE_K_ID) \ + | (1 << X86_XSTATE_ZMM_H_ID) \ + | (1 << X86_XSTATE_ZMM_ID) \ + | (1 << X86_XSTATE_APX_F_ID)) +#else +/* Offset for fxsave/xsave area used by _dl_tlsdesc_dynamic. Since i386 + doesn't have red-zone, use 0 here. */ +# define STATE_SAVE_OFFSET 0 + +/* Save SSE, AVX, AXV512, mask and bound registers. */ +# define STATE_SAVE_MASK \ + ((1 << X86_XSTATE_SSE_ID) \ + | (1 << X86_XSTATE_AVX_ID) \ + | (1 << X86_XSTATE_BNDREGS_ID) \ + | (1 << X86_XSTATE_K_ID) \ + | (1 << X86_XSTATE_ZMM_H_ID)) +#endif /* Constants for bits in __x86_string_control: */