sysdeps/unix/sysv/linux/syscall.c is not referenced anywhere, let's remove it
Checks
Context |
Check |
Description |
redhat-pt-bot/TryBot-apply_patch |
success
|
Patch applied to master at the time it was sent
|
linaro-tcwg-bot/tcwg_glibc_build--master-aarch64 |
success
|
Testing passed
|
redhat-pt-bot/TryBot-32bit |
success
|
Build for i686
|
linaro-tcwg-bot/tcwg_glibc_check--master-aarch64 |
success
|
Testing passed
|
linaro-tcwg-bot/tcwg_glibc_build--master-arm |
success
|
Testing passed
|
linaro-tcwg-bot/tcwg_glibc_check--master-arm |
success
|
Testing passed
|
Commit Message
sysdeps/unix/sysv/linux/syscall.c is not referenced anywhere. In particular, it is not
referenced in sysdeps/unix/sysv/linux/Makefile . So, this syscall.c is dead code, let's
remove it.
Compile-tested on Linux x86_64
Signed-off-by: Askar Safin <safinaskar@zohomail.com>
---
This is another small issue I found when I was writing that "syscall_no_errno" patch
sysdeps/unix/sysv/linux/syscall.c | 43 -------------------------------
1 file changed, 43 deletions(-)
delete mode 100644 sysdeps/unix/sysv/linux/syscall.c
Comments
On 12/02/24 14:59, Askar Safin wrote:
> sysdeps/unix/sysv/linux/syscall.c is not referenced anywhere. In particular, it is not
> referenced in sysdeps/unix/sysv/linux/Makefile . So, this syscall.c is dead code, let's
> remove it.
>
> Compile-tested on Linux x86_64
>
> Signed-off-by: Askar Safin <safinaskar@zohomail.com>
It is used by hppa, loongarch, mips o32, ork1, and riscv.
PS: I think Rich is not really interested in this kind of discussion, so you
can drop him from CC.
> ---
>
> This is another small issue I found when I was writing that "syscall_no_errno" patch
>
> sysdeps/unix/sysv/linux/syscall.c | 43 -------------------------------
> 1 file changed, 43 deletions(-)
> delete mode 100644 sysdeps/unix/sysv/linux/syscall.c
>
> diff --git a/sysdeps/unix/sysv/linux/syscall.c b/sysdeps/unix/sysv/linux/syscall.c
> deleted file mode 100644
> index 3cff1d970a..0000000000
> --- a/sysdeps/unix/sysv/linux/syscall.c
> +++ /dev/null
> @@ -1,43 +0,0 @@
> -/* Indirect system call. Linux generic implementation.
> - Copyright (C) 1997-2024 Free Software Foundation, Inc.
> - This file is part of the GNU C Library.
> -
> - The GNU C Library is free software; you can redistribute it and/or
> - modify it under the terms of the GNU Lesser General Public
> - License as published by the Free Software Foundation; either
> - version 2.1 of the License, or (at your option) any later version.
> -
> - The GNU C Library is distributed in the hope that it will be useful,
> - but WITHOUT ANY WARRANTY; without even the implied warranty of
> - MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the GNU
> - Lesser General Public License for more details.
> -
> - You should have received a copy of the GNU Lesser General Public
> - License along with the GNU C Library. If not, see
> - <https://www.gnu.org/licenses/>. */
> -
> -#include <stdarg.h>
> -#include <sysdep.h>
> -
> -long int
> -syscall (long int number, ...)
> -{
> - va_list args;
> -
> - va_start (args, number);
> - long int a0 = va_arg (args, long int);
> - long int a1 = va_arg (args, long int);
> - long int a2 = va_arg (args, long int);
> - long int a3 = va_arg (args, long int);
> - long int a4 = va_arg (args, long int);
> - long int a5 = va_arg (args, long int);
> - va_end (args);
> -
> - long int r = INTERNAL_SYSCALL_NCS_CALL (number, a0, a1, a2, a3, a4, a5);
> - if (__glibc_unlikely (INTERNAL_SYSCALL_ERROR_P (r)))
> - {
> - __set_errno (-r);
> - return -1;
> - }
> - return r;
> -}
deleted file mode 100644
@@ -1,43 +0,0 @@
-/* Indirect system call. Linux generic implementation.
- Copyright (C) 1997-2024 Free Software Foundation, Inc.
- This file is part of the GNU C Library.
-
- The GNU C Library is free software; you can redistribute it and/or
- modify it under the terms of the GNU Lesser General Public
- License as published by the Free Software Foundation; either
- version 2.1 of the License, or (at your option) any later version.
-
- The GNU C Library is distributed in the hope that it will be useful,
- but WITHOUT ANY WARRANTY; without even the implied warranty of
- MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the GNU
- Lesser General Public License for more details.
-
- You should have received a copy of the GNU Lesser General Public
- License along with the GNU C Library. If not, see
- <https://www.gnu.org/licenses/>. */
-
-#include <stdarg.h>
-#include <sysdep.h>
-
-long int
-syscall (long int number, ...)
-{
- va_list args;
-
- va_start (args, number);
- long int a0 = va_arg (args, long int);
- long int a1 = va_arg (args, long int);
- long int a2 = va_arg (args, long int);
- long int a3 = va_arg (args, long int);
- long int a4 = va_arg (args, long int);
- long int a5 = va_arg (args, long int);
- va_end (args);
-
- long int r = INTERNAL_SYSCALL_NCS_CALL (number, a0, a1, a2, a3, a4, a5);
- if (__glibc_unlikely (INTERNAL_SYSCALL_ERROR_P (r)))
- {
- __set_errno (-r);
- return -1;
- }
- return r;
-}