Message ID | 20231228172026.2013007-3-adhemerval.zanella@linaro.org |
---|---|
State | Superseded |
Delegated to: | H.J. Lu |
Headers |
Return-Path: <libc-alpha-bounces+patchwork=sourceware.org@sourceware.org> X-Original-To: patchwork@sourceware.org Delivered-To: patchwork@sourceware.org Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id 2955A38582AE for <patchwork@sourceware.org>; Thu, 28 Dec 2023 17:21:12 +0000 (GMT) X-Original-To: libc-alpha@sourceware.org Delivered-To: libc-alpha@sourceware.org Received: from mail-pf1-x433.google.com (mail-pf1-x433.google.com [IPv6:2607:f8b0:4864:20::433]) by sourceware.org (Postfix) with ESMTPS id 561453858285 for <libc-alpha@sourceware.org>; Thu, 28 Dec 2023 17:20:35 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 561453858285 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=linaro.org ARC-Filter: OpenARC Filter v1.0.0 sourceware.org 561453858285 Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=2607:f8b0:4864:20::433 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1703784036; cv=none; b=PwpQ125AesEZTHv4XsbtZuZuJeVT+73q71S6H9mnutULoVgu18yEvUngZpH7Jl+ByX4fvn+uGi1PwWEAKR6N/gSwHW0NWFCHKhFAZqVCJ1YdCr6o2hrmlDaopYCjs4YKklFyja97UT1vvoOHPNA8ON55ckv2toAnOE6R7dAGiEs= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1703784036; c=relaxed/simple; bh=icbRRebo28bwbUjUPuHOu3TxXraa51y2/MbekaP6VW0=; h=DKIM-Signature:From:To:Subject:Date:Message-Id:MIME-Version; b=HAb3z7j54+Hdqi2MOAqOgrCYWqYpIVMZYfXQrZMK9OlISEIa8kp8bH5yWLcdmEjZZXSrIKn9/GCsP3HNrhtAFbCNNvylev6hlINT2DKw20zJUBrdb2jrdqjWa98Br+yOZjK1rlhsKsnLSmBKdp1KJ9xdIz0cpb3qwuX5W7DSbJs= ARC-Authentication-Results: i=1; server2.sourceware.org Received: by mail-pf1-x433.google.com with SMTP id d2e1a72fcca58-6d9ac5bd128so1319177b3a.0 for <libc-alpha@sourceware.org>; Thu, 28 Dec 2023 09:20:35 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1703784033; x=1704388833; darn=sourceware.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:to:from:from:to:cc:subject:date:message-id :reply-to; bh=Huesn2m2L4ex/SQtx9e/pU9r+ZSuhfpItQ8FOCLXjKk=; b=BolqM8BB1EGpYGIcONVeiMPhiZp7Lk0r5MzbsTbc6+NJYX4IKuib4dmI2ifCNNEAnM 1NZ2GJl9U7vCjvNrGeQFstqFGpjMV18c37v/DMjQEcO2NqoOdxoPht4MI9qB02sOFLTV s8Qay3P2VkXuYLl/Hx/zjNESWqxFvQUn6adtXyeY8xaHA5xqKvpdtIxtQtXpJ9FMH8I+ 9pe5z3wm+a8hf24x6XUXRtNAw+fAipaFJTFUoDNAPFBFMoLf/qeEKOT9z+NdOX4mOYiA o1lPeCqwpDXSWk6RML3pz4LqdBXXQSV39O0ZCyuwH7p3aVenjJfoa45ZMrsNaBAUqmRz jmtA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1703784033; x=1704388833; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=Huesn2m2L4ex/SQtx9e/pU9r+ZSuhfpItQ8FOCLXjKk=; b=k6VScDrE3HNA+/GE+cF0OXOVrjxkiKtB2sPu4NOvh5laZsFbARpnqdxETrQ/H9anSt 54P0Kq1ibHjuswJsBT0IGfERWE5BM8Vp5/0Uanrz5c3X87mkERo0P8CEut9Go73UJpe7 ofB5G76v0ov554kWeoT9JZPSgWCGJQPyIYRP0gUrpNptmCPdlqtmmXpXgqLIe0bXVB7h gLKXibXQegCuZV56dW1vlFELn7dXu6i8Xe6GTiZvm76Nlwc9g4JDHYrvpLVc8RDlFcTN 6TQo99BMlpveko0ZTjE6w08wDoxPfwdEc6E7RGzL4otdMFa0i7GhWvZPHl9Se+dWsLD2 OhmQ== X-Gm-Message-State: AOJu0Yw9BxrYhxxMqj3LGLlXeJkY+H3ioiZkTB/NJDDDjUpSpFGNGln1 uNtFkiv8at1C/Yqfs8a5i62zLB9kxdEsOrVW3pX1/sfLWGg= X-Google-Smtp-Source: AGHT+IGIcPlIlGGGZhT60GD3w2v2vEZ3fN6eIwOVRVN7apK06tSpb2RH+gcwSB2a87byrzeQNNIL7w== X-Received: by 2002:a05:6a20:734d:b0:196:65bd:7855 with SMTP id v13-20020a056a20734d00b0019665bd7855mr502116pzc.53.1703784033664; Thu, 28 Dec 2023 09:20:33 -0800 (PST) Received: from mandiga.. ([2804:1b3:a7c1:bd9:84dc:8a87:ea0:57d7]) by smtp.gmail.com with ESMTPSA id q7-20020aa79827000000b006d9a94a03a8sm9593839pfl.77.2023.12.28.09.20.31 for <libc-alpha@sourceware.org> (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 28 Dec 2023 09:20:32 -0800 (PST) From: Adhemerval Zanella <adhemerval.zanella@linaro.org> To: libc-alpha@sourceware.org Subject: [PATCH 02/12] powerpc: Add missing arch flags on rounding ifunc variants Date: Thu, 28 Dec 2023 14:20:16 -0300 Message-Id: <20231228172026.2013007-3-adhemerval.zanella@linaro.org> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20231228172026.2013007-1-adhemerval.zanella@linaro.org> References: <20231228172026.2013007-1-adhemerval.zanella@linaro.org> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Spam-Status: No, score=-12.1 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, GIT_PATCH_0, RCVD_IN_DNSWL_NONE, SPF_HELO_NONE, SPF_PASS, TXREP, T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org X-BeenThere: libc-alpha@sourceware.org X-Mailman-Version: 2.1.30 Precedence: list List-Id: Libc-alpha mailing list <libc-alpha.sourceware.org> List-Unsubscribe: <https://sourceware.org/mailman/options/libc-alpha>, <mailto:libc-alpha-request@sourceware.org?subject=unsubscribe> List-Archive: <https://sourceware.org/pipermail/libc-alpha/> List-Post: <mailto:libc-alpha@sourceware.org> List-Help: <mailto:libc-alpha-request@sourceware.org?subject=help> List-Subscribe: <https://sourceware.org/mailman/listinfo/libc-alpha>, <mailto:libc-alpha-request@sourceware.org?subject=subscribe> Errors-To: libc-alpha-bounces+patchwork=sourceware.org@sourceware.org |
Series |
Improve rounding to interger function for C23
|
|
Checks
Context | Check | Description |
---|---|---|
redhat-pt-bot/TryBot-apply_patch | success | Patch applied to master at the time it was sent |
Commit Message
Adhemerval Zanella Netto
Dec. 28, 2023, 5:20 p.m. UTC
The ifunc variants now uses the powerpc implementation which in turn uses the compiler builtin. Without the proper -mcpu switch the builtin does not generate the expected optimization. Checked on powerpc-linux-gnu. --- sysdeps/powerpc/powerpc32/power4/fpu/multiarch/Makefile | 6 ++++++ 1 file changed, 6 insertions(+)
Comments
On Thu, Dec 28, 2023 at 9:21 AM Adhemerval Zanella <adhemerval.zanella@linaro.org> wrote: > > The ifunc variants now uses the powerpc implementation which in turn > uses the compiler builtin. Without the proper -mcpu switch the builtin > does not generate the expected optimization. > > Checked on powerpc-linux-gnu. > --- > sysdeps/powerpc/powerpc32/power4/fpu/multiarch/Makefile | 6 ++++++ > 1 file changed, 6 insertions(+) > > diff --git a/sysdeps/powerpc/powerpc32/power4/fpu/multiarch/Makefile b/sysdeps/powerpc/powerpc32/power4/fpu/multiarch/Makefile > index 64317506c6..2f5c0eded6 100644 > --- a/sysdeps/powerpc/powerpc32/power4/fpu/multiarch/Makefile > +++ b/sysdeps/powerpc/powerpc32/power4/fpu/multiarch/Makefile > @@ -34,6 +34,12 @@ CFLAGS-s_modff-power5+.c = -mcpu=power5+ > CFLAGS-s_logbl-power7.c = -mcpu=power7 > CFLAGS-s_logb-power7.c = -mcpu=power7 > CFLAGS-s_logbf-power7.c = -mcpu=power7 > +CFLAGS-s_round-power5+.c += -mcpu=power5+ > +CFLAGS-s_roundf-power5+.c += -mcpu=power5+ > +CFLAGS-s_floor-power5+.c += -mcpu=power5+ > +CFLAGS-s_floorf-power5+.c += -mcpu=power5+ > +CFLAGS-s_trunc-power5+.c += -mcpu=power5+ > +CFLAGS-s_truncf-power5+.c += -mcpu=power5+ > > # These files quiet sNaNs in a way that is optimized away without > # -fsignaling-nans. > -- > 2.34.1 > LGTM. Reviewed-by: H.J. Lu <hjl.tools@gmail.com> Thanks.
On 4/1/24 8:59 AM, H.J. Lu wrote: > On Thu, Dec 28, 2023 at 9:21 AM Adhemerval Zanella > <adhemerval.zanella@linaro.org> wrote: >> >> The ifunc variants now uses the powerpc implementation which in turn >> uses the compiler builtin. Without the proper -mcpu switch the builtin >> does not generate the expected optimization. >> >> Checked on powerpc-linux-gnu. >> --- >> sysdeps/powerpc/powerpc32/power4/fpu/multiarch/Makefile | 6 ++++++ >> 1 file changed, 6 insertions(+) >> >> diff --git a/sysdeps/powerpc/powerpc32/power4/fpu/multiarch/Makefile b/sysdeps/powerpc/powerpc32/power4/fpu/multiarch/Makefile >> index 64317506c6..2f5c0eded6 100644 >> --- a/sysdeps/powerpc/powerpc32/power4/fpu/multiarch/Makefile >> +++ b/sysdeps/powerpc/powerpc32/power4/fpu/multiarch/Makefile >> @@ -34,6 +34,12 @@ CFLAGS-s_modff-power5+.c = -mcpu=power5+ >> CFLAGS-s_logbl-power7.c = -mcpu=power7 >> CFLAGS-s_logb-power7.c = -mcpu=power7 >> CFLAGS-s_logbf-power7.c = -mcpu=power7 >> +CFLAGS-s_round-power5+.c += -mcpu=power5+ >> +CFLAGS-s_roundf-power5+.c += -mcpu=power5+ >> +CFLAGS-s_floor-power5+.c += -mcpu=power5+ >> +CFLAGS-s_floorf-power5+.c += -mcpu=power5+ >> +CFLAGS-s_trunc-power5+.c += -mcpu=power5+ >> +CFLAGS-s_truncf-power5+.c += -mcpu=power5+ >> >> # These files quiet sNaNs in a way that is optimized away without >> # -fsignaling-nans. >> -- >> 2.34.1 >> > > LGTM. > > Reviewed-by: H.J. Lu <hjl.tools@gmail.com> This predated me taking over the Power port, but... LGTM too. Reviewed-by: Peter Bergner <bergner@linux.ibm.com> Peter
diff --git a/sysdeps/powerpc/powerpc32/power4/fpu/multiarch/Makefile b/sysdeps/powerpc/powerpc32/power4/fpu/multiarch/Makefile index 64317506c6..2f5c0eded6 100644 --- a/sysdeps/powerpc/powerpc32/power4/fpu/multiarch/Makefile +++ b/sysdeps/powerpc/powerpc32/power4/fpu/multiarch/Makefile @@ -34,6 +34,12 @@ CFLAGS-s_modff-power5+.c = -mcpu=power5+ CFLAGS-s_logbl-power7.c = -mcpu=power7 CFLAGS-s_logb-power7.c = -mcpu=power7 CFLAGS-s_logbf-power7.c = -mcpu=power7 +CFLAGS-s_round-power5+.c += -mcpu=power5+ +CFLAGS-s_roundf-power5+.c += -mcpu=power5+ +CFLAGS-s_floor-power5+.c += -mcpu=power5+ +CFLAGS-s_floorf-power5+.c += -mcpu=power5+ +CFLAGS-s_trunc-power5+.c += -mcpu=power5+ +CFLAGS-s_truncf-power5+.c += -mcpu=power5+ # These files quiet sNaNs in a way that is optimized away without # -fsignaling-nans.