From patchwork Tue Sep 5 15:27:02 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Peter Edwards X-Patchwork-Id: 75313 Return-Path: X-Original-To: patchwork@sourceware.org Delivered-To: patchwork@sourceware.org Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id 5F4F73858028 for ; Tue, 5 Sep 2023 15:27:38 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 5F4F73858028 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=sourceware.org; s=default; t=1693927658; bh=aTNhuUfJ9WAVBVsFUspf4oCjmPTWnHWowCRDL5m87T8=; h=To:Cc:Subject:Date:List-Id:List-Unsubscribe:List-Archive: List-Post:List-Help:List-Subscribe:From:Reply-To:From; b=R5u5E9uc06HsucaQRxbF2OyKlU3IaTtGtNl3EXVNlDGP8Ajl6UBKPO64lZXZpX+h3 Ko0uywGrWt9ba1mDYxDPrW/3BQ7nfn3nFmvKrvbSr+FVdFWEnVbUIWeWS4rqNu9ZyT hq4LfgjVEbgj/efcOvUjrh7h06uYDFo0hSOTH3lU= X-Original-To: libc-alpha@sourceware.org Delivered-To: libc-alpha@sourceware.org Received: from mail-wm1-x32f.google.com (mail-wm1-x32f.google.com [IPv6:2a00:1450:4864:20::32f]) by sourceware.org (Postfix) with ESMTPS id 6D5A23858D32 for ; Tue, 5 Sep 2023 15:27:13 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 6D5A23858D32 Received: by mail-wm1-x32f.google.com with SMTP id 5b1f17b1804b1-401ec23be82so28047495e9.0 for ; Tue, 05 Sep 2023 08:27:13 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1693927632; x=1694532432; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=aTNhuUfJ9WAVBVsFUspf4oCjmPTWnHWowCRDL5m87T8=; b=VJtml/Se0+vWy7QEB1yXJrI+4fiUqyoeEuCK+Yu2aYgd1Dmlfo4K4164KLd2a7YhBU Tj3fGY3TR4hcDOn2o0KfjvR40LKbqGEXrsaisy3Lu+a3gZou9fG0Vtk2B/el3sHQvFuM Dj4yeLYX2OvP3muiNGFaiplSXVqiNzXNey7hOuYfxKPvQux30rbsDg9YT/xdfpvfWbKl up4UE3gPvc5nZwo202IETbjuyygJkFlxjapcrue6QFajvjGWzM/Unnq+HEoSphu+Gkhk cpjffu3gFH2IKS+d9AAzsmIJMwIof7lO75xQOQdmk3xbETP6HcJgqRnJFwFdPyZHL8Oq siWg== X-Gm-Message-State: AOJu0YyRbLM62DDs3p5wnF/vSWqLOXFxMoZH2TpQEAfzSU57KGoMGb7D S347hE7Lr0reg0MKeZq5T1ArY2attEPWsRti0V0= X-Google-Smtp-Source: AGHT+IG+ttUVNeZW6Wzn8Utgtd2IH3/asTl/x0DUwBuqNPaiBy1cDgvsyJt8Qw+tHK9exDzuw5re9w== X-Received: by 2002:a05:600c:2a41:b0:401:be70:53b6 with SMTP id x1-20020a05600c2a4100b00401be7053b6mr68487wme.15.1693927631835; Tue, 05 Sep 2023 08:27:11 -0700 (PDT) Received: from AWAVAUATUSH.aristanetworks.com ([46.7.23.185]) by smtp.gmail.com with ESMTPSA id g26-20020a7bc4da000000b003fee8502999sm20335813wmk.18.2023.09.05.08.27.11 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 05 Sep 2023 08:27:11 -0700 (PDT) To: libc-alpha@sourceware.org Cc: Peter Edwards Subject: [PATCH] resolv: use proper bound in __gai_freemem Date: Tue, 5 Sep 2023 16:27:02 +0100 Message-ID: <20230905152702.619804-1-peadar@arista.com> X-Mailer: git-send-email 2.42.0.111.gd814540bb7 MIME-Version: 1.0 X-Spam-Status: No, score=-11.6 required=5.0 tests=BAYES_00, DKIMWL_WL_HIGH, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, GIT_PATCH_0, RCVD_IN_DNSWL_NONE, SPF_HELO_NONE, SPF_NONE, TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org X-BeenThere: libc-alpha@sourceware.org X-Mailman-Version: 2.1.30 Precedence: list List-Id: Libc-alpha mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-Patchwork-Original-From: Peter Edwards via Libc-alpha From: Peter Edwards Reply-To: Peter Edwards Errors-To: libc-alpha-bounces+patchwork=sourceware.org@sourceware.org Sender: "Libc-alpha" __gai_freemem participates in the __libc_freeres mechanism to clean up things at exit when requested by debugging/heap-checking tools such as valgrind The "pool" in gai_misc.c has valid data over the range [0, pool_size), but the allocation stretches as far as pool_max_size. The elements between pool_size and pool_max_size are uninitialized - so, use pool_size as the iteration limit when free'ing data from pool, not pool_max_size. --- resolv/gai_misc.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/resolv/gai_misc.c b/resolv/gai_misc.c index 9e3b1d29b7..0c0ae741f9 100644 --- a/resolv/gai_misc.c +++ b/resolv/gai_misc.c @@ -442,7 +442,7 @@ __gai_freemem (void) { size_t row; - for (row = 0; row < pool_max_size; ++row) + for (row = 0; row < pool_size; ++row) free (pool[row]); free (pool);