sysdeps: Add missing hidden definitions for i386

Message ID 20230706172047.528695-1-fberat@redhat.com
State Committed
Commit 19f9f7f9d5064ad6608e6d40a3aa1b3db8a4a1ae
Headers
Series sysdeps: Add missing hidden definitions for i386 |

Checks

Context Check Description
redhat-pt-bot/TryBot-apply_patch success Patch applied to master at the time it was sent
redhat-pt-bot/TryBot-32bit success Build for i686
linaro-tcwg-bot/tcwg_glibc_check--master-arm success Testing passed
linaro-tcwg-bot/tcwg_glibc_build--master-aarch64 warning Patch failed to apply
linaro-tcwg-bot/tcwg_glibc_check--master-aarch64 warning Patch failed to apply
linaro-tcwg-bot/tcwg_glibc_build--master-arm warning Patch failed to apply

Commit Message

Frederic Berat July 6, 2023, 5:20 p.m. UTC
  Add missing libc_hidden_builtin_def for memset_chk and MEMCPY_CHK on
i386.
---
 sysdeps/i386/memcpy.S | 1 +
 sysdeps/i386/memset.S | 1 +
 2 files changed, 2 insertions(+)
  

Comments

Andreas Schwab July 10, 2023, 8:07 a.m. UTC | #1
On Jul 06 2023, Frédéric Bérat wrote:

> Add missing libc_hidden_builtin_def for memset_chk and MEMCPY_CHK on
> i386.

Ok.
  

Patch

diff --git a/sysdeps/i386/memcpy.S b/sysdeps/i386/memcpy.S
index a6512b453e..e48396ea21 100644
--- a/sysdeps/i386/memcpy.S
+++ b/sysdeps/i386/memcpy.S
@@ -46,6 +46,7 @@  ENTRY (MEMCPY_CHK)
 	cmpl	%eax, 16(%esp)
 	jb	HIDDEN_JUMPTARGET (__chk_fail)
 END (MEMCPY_CHK)
+libc_hidden_builtin_def (MEMCPY_CHK)
 #endif
 ENTRY (MEMCPY)
 	PUSH	(%esi)
diff --git a/sysdeps/i386/memset.S b/sysdeps/i386/memset.S
index 4a107d604b..855720822e 100644
--- a/sysdeps/i386/memset.S
+++ b/sysdeps/i386/memset.S
@@ -40,6 +40,7 @@  ENTRY (__memset_chk)
 	cmpl	%eax, 16(%esp)
 	jb	HIDDEN_JUMPTARGET (__chk_fail)
 END (__memset_chk)
+libc_hidden_builtin_def (__memset_chk)
 #endif
 ENTRY (memset)
 	PUSH    (%edi)