Stop applying a GCC-specific workaround on clang [BZ #30550]
Checks
Context |
Check |
Description |
redhat-pt-bot/TryBot-apply_patch |
success
|
Patch applied to master at the time it was sent
|
redhat-pt-bot/TryBot-32bit |
success
|
Build for i686
|
linaro-tcwg-bot/tcwg_glibc_build--master-aarch64 |
success
|
Testing passed
|
linaro-tcwg-bot/tcwg_glibc_build--master-arm |
success
|
Testing passed
|
linaro-tcwg-bot/tcwg_glibc_check--master-arm |
success
|
Testing passed
|
linaro-tcwg-bot/tcwg_glibc_check--master-aarch64 |
success
|
Testing passed
|
Commit Message
From: Tulio Magno Quites Machado Filho <tuliom@redhat.com>
GCC was the only compiler affected by the issue with
__builtin_isinf_sign and float128.
Fix BZ #30550.
---
math/math.h | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
Comments
* Tulio Magno Quites Machado Filho via Libc-alpha:
> From: Tulio Magno Quites Machado Filho <tuliom@redhat.com>
>
> GCC was the only compiler affected by the issue with
> __builtin_isinf_sign and float128.
>
> Fix BZ #30550.
> ---
> math/math.h | 3 ++-
> 1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/math/math.h b/math/math.h
> index 6427c72276..f13639943e 100644
> --- a/math/math.h
> +++ b/math/math.h
> @@ -1015,7 +1015,8 @@ enum
>
> /* Return nonzero value if X is positive or negative infinity. */
> # if __HAVE_DISTINCT_FLOAT128 && !__GNUC_PREREQ (7,0) \
> - && !defined __SUPPORT_SNAN__ && !defined __cplusplus
> + && !defined __SUPPORT_SNAN__ && !defined __cplusplus \
> + && !defined __clang__
> /* Since __builtin_isinf_sign is broken for float128 before GCC 7.0,
> use the helper function, __isinff128, with older compilers. This is
> only provided for C mode, because in C++ mode, GCC has no support
This looks okay to me.
Reviewed-by: Florian Weimer <fweimer@redhat.com>
Thanks,
Florian
Florian Weimer <fweimer@redhat.com> writes:
> This looks okay to me.
>
> Reviewed-by: Florian Weimer <fweimer@redhat.com>
I added the Reported-by that I had forgotten to add initially and pushed
this as 0a9e93842d8e535ac8174cb4ff7fb830b20e4ae7.
Thanks!
@@ -1015,7 +1015,8 @@ enum
/* Return nonzero value if X is positive or negative infinity. */
# if __HAVE_DISTINCT_FLOAT128 && !__GNUC_PREREQ (7,0) \
- && !defined __SUPPORT_SNAN__ && !defined __cplusplus
+ && !defined __SUPPORT_SNAN__ && !defined __cplusplus \
+ && !defined __clang__
/* Since __builtin_isinf_sign is broken for float128 before GCC 7.0,
use the helper function, __isinff128, with older compilers. This is
only provided for C mode, because in C++ mode, GCC has no support