[v2] x86-64: Use YMM registers in memcmpeq-evex.S

Message ID 20230601155335.71684-1-hjl.tools@gmail.com
State Committed
Commit a8c888997845c5192e446176374c2e13bb3e2195
Headers
Series [v2] x86-64: Use YMM registers in memcmpeq-evex.S |

Checks

Context Check Description
redhat-pt-bot/TryBot-apply_patch success Patch applied to master at the time it was sent
redhat-pt-bot/TryBot-32bit success Build for i686
linaro-tcwg-bot/tcwg_glibc_build--master-arm success Testing passed
linaro-tcwg-bot/tcwg_glibc_build--master-aarch64 success Testing passed
linaro-tcwg-bot/tcwg_glibc_check--master-aarch64 pending Patch applied
linaro-tcwg-bot/tcwg_glibc_check--master-arm pending Patch applied

Commit Message

H.J. Lu June 1, 2023, 3:53 p.m. UTC
  Since the assembly source file with -evex suffix should use YMM registers,
not ZMM registers, include x86-evex256-vecs.h by default to use YMM
registers in memcmpeq-evex.S
---
 sysdeps/x86_64/multiarch/memcmpeq-evex.S | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
  

Comments

Noah Goldstein June 1, 2023, 4:08 p.m. UTC | #1
On Thu, Jun 1, 2023 at 10:53 AM H.J. Lu <hjl.tools@gmail.com> wrote:
>
> Since the assembly source file with -evex suffix should use YMM registers,
> not ZMM registers, include x86-evex256-vecs.h by default to use YMM
> registers in memcmpeq-evex.S
> ---
>  sysdeps/x86_64/multiarch/memcmpeq-evex.S | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/sysdeps/x86_64/multiarch/memcmpeq-evex.S b/sysdeps/x86_64/multiarch/memcmpeq-evex.S
> index 3666f649cd..7eefff77f1 100644
> --- a/sysdeps/x86_64/multiarch/memcmpeq-evex.S
> +++ b/sysdeps/x86_64/multiarch/memcmpeq-evex.S
> @@ -42,7 +42,7 @@
>  # endif
>
>  # ifndef VEC_SIZE
> -#  include "x86-evex512-vecs.h"
> +#  include "x86-evex256-vecs.h"
>  # endif
>  # include "reg-macros.h"
>
> --
> 2.40.1
>

LGTM.

Reviewed-by: Noah Goldstein <goldstein.w.n@gmail.com>
  

Patch

diff --git a/sysdeps/x86_64/multiarch/memcmpeq-evex.S b/sysdeps/x86_64/multiarch/memcmpeq-evex.S
index 3666f649cd..7eefff77f1 100644
--- a/sysdeps/x86_64/multiarch/memcmpeq-evex.S
+++ b/sysdeps/x86_64/multiarch/memcmpeq-evex.S
@@ -42,7 +42,7 @@ 
 # endif
 
 # ifndef VEC_SIZE
-#  include "x86-evex512-vecs.h"
+#  include "x86-evex256-vecs.h"
 # endif
 # include "reg-macros.h"