From patchwork Sat Apr 29 13:13:49 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Sergey Bugaev X-Patchwork-Id: 68543 Return-Path: X-Original-To: patchwork@sourceware.org Delivered-To: patchwork@sourceware.org Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id 4B4B8385700F for ; Sat, 29 Apr 2023 13:14:22 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 4B4B8385700F DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=sourceware.org; s=default; t=1682774062; bh=e/4kHgS4eq3VRSTYtybNAaxVSrKUW2DssEM8aUPTjc8=; h=To:Cc:Subject:Date:In-Reply-To:References:List-Id: List-Unsubscribe:List-Archive:List-Post:List-Help:List-Subscribe: From:Reply-To:From; b=bllFIkSvbx/0ePg7cHs68VECkah65jkDPAS5GcGFYBjPIRL5I+2Vy6PF/KC/qCB1+ hYk+h6CmX/fZDo2J8MZuuXvZA4ZiUK8A7RGGKDDXf4CobJ5behyHcdgx0ueb+ez1DE USZyfaQY9VJ1O5t+oJBBKfi/tkvUOXa/gsTaXkHg= X-Original-To: libc-alpha@sourceware.org Delivered-To: libc-alpha@sourceware.org Received: from mail-lf1-x12a.google.com (mail-lf1-x12a.google.com [IPv6:2a00:1450:4864:20::12a]) by sourceware.org (Postfix) with ESMTPS id D0B4B3858C54 for ; Sat, 29 Apr 2023 13:13:58 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org D0B4B3858C54 Received: by mail-lf1-x12a.google.com with SMTP id 2adb3069b0e04-4effb818c37so1059333e87.3 for ; Sat, 29 Apr 2023 06:13:58 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1682774037; x=1685366037; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=e/4kHgS4eq3VRSTYtybNAaxVSrKUW2DssEM8aUPTjc8=; b=hTsP+mybmKstGBlhm6+oGmaCB8tIQNwDwmOo6EpWtVZcucGdlrer3PEkd6WIU/RQC1 t7ra6UKkgcaz8MHCp5y8PY9Tk4gJQnQ0BgAtUvNHZ+/lseCKS1GGV1D/PPLmq039oE/J P26721CP6UZxu83gI2JuvdDPCdW9IjcCD4u91pn1oQ2v9w4rjdChyxzaxYg2mVYdOumm R1O2pEjeUvC9MiIBfRClSk4y/6i1ftqFezRy8AXGjhljLeU86oGS+vlgLOIoMQ7ORK7L 5M93fULq/Vnlswc2Y0yVsaQkZ9rC4O4Od14FJ2t8xCrFWQrWRtIEb1LLmVVs287aE8Sz OaLA== X-Gm-Message-State: AC+VfDyprUXd95YmiO7nEi12/uTpEOUroVrX7l6C75GHVdO77Vj0eHAX TPI3o5QyywUUmbCS95n/ejd5FYjRBsGa0w== X-Google-Smtp-Source: ACHHUZ7Y90PybLFHL5Q4YxOWLYAylBpRZ3N0+L+WAwXQTPwBiaqOfjRpwCNzgvA3+0EDrra43ANatQ== X-Received: by 2002:ac2:5930:0:b0:4ef:ec33:9155 with SMTP id v16-20020ac25930000000b004efec339155mr2408166lfi.28.1682774036899; Sat, 29 Apr 2023 06:13:56 -0700 (PDT) Received: from surface-pro-6.. ([2a00:1370:818c:4a57:8a14:19ba:9e6b:1866]) by smtp.gmail.com with ESMTPSA id f27-20020ac251bb000000b004eb018fac57sm3744851lfk.191.2023.04.29.06.13.56 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 29 Apr 2023 06:13:56 -0700 (PDT) To: libc-alpha@sourceware.org Cc: bug-hurd@gnu.org, Samuel Thibault Subject: [PATCH 2/7] hurd: Move libc_hidden_def's around Date: Sat, 29 Apr 2023 16:13:49 +0300 Message-Id: <20230429131354.2507443-2-bugaevc@gmail.com> X-Mailer: git-send-email 2.40.1 In-Reply-To: <20230429131354.2507443-1-bugaevc@gmail.com> References: <20230429131354.2507443-1-bugaevc@gmail.com> MIME-Version: 1.0 X-Spam-Status: No, score=-11.3 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, FREEMAIL_FROM, GIT_PATCH_0, RCVD_IN_DNSWL_NONE, SPF_HELO_NONE, SPF_PASS, TXREP, T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org X-BeenThere: libc-alpha@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Libc-alpha mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-Patchwork-Original-From: Sergey Bugaev via Libc-alpha From: Sergey Bugaev Reply-To: Sergey Bugaev Errors-To: libc-alpha-bounces+patchwork=sourceware.org@sourceware.org Sender: "Libc-alpha" Each libc_hidden_def should be placed immediately next to its function, not in some random unrelated place. No functional change. Fixes: 653d74f12abea144219af00400ed1f1ac5dfa79f "hurd: Global signal disposition" Signed-off-by: Sergey Bugaev --- hurd/hurdsig.c | 9 +++++---- 1 file changed, 5 insertions(+), 4 deletions(-) diff --git a/hurd/hurdsig.c b/hurd/hurdsig.c index c84de4db..78ea59d9 100644 --- a/hurd/hurdsig.c +++ b/hurd/hurdsig.c @@ -174,6 +174,7 @@ _hurd_sigstate_set_global_rcv (struct hurd_sigstate *ss) assert (ss->thread != MACH_PORT_NULL); ss->actions[0].sa_handler = SIG_IGN; } +libc_hidden_def (_hurd_sigstate_set_global_rcv) /* Check whether SS is a global receiver. */ static int @@ -193,6 +194,8 @@ _hurd_sigstate_lock (struct hurd_sigstate *ss) __spin_lock (&_hurd_global_sigstate->lock); __spin_lock (&ss->lock); } +libc_hidden_def (_hurd_sigstate_lock) + void _hurd_sigstate_unlock (struct hurd_sigstate *ss) { @@ -200,7 +203,7 @@ _hurd_sigstate_unlock (struct hurd_sigstate *ss) if (sigstate_is_global_rcv (ss)) __spin_unlock (&_hurd_global_sigstate->lock); } -libc_hidden_def (_hurd_sigstate_set_global_rcv) +libc_hidden_def (_hurd_sigstate_unlock) /* Retrieve a thread's full set of pending signals, including the global ones if appropriate. SS must be locked. */ @@ -212,6 +215,7 @@ _hurd_sigstate_pending (const struct hurd_sigstate *ss) __sigorset (&pending, &pending, &_hurd_global_sigstate->pending); return pending; } +libc_hidden_def (_hurd_sigstate_pending) /* Clear a pending signal and return the associated detailed signal information. SS must be locked, and must have signal SIGNO @@ -230,8 +234,6 @@ sigstate_clear_pending (struct hurd_sigstate *ss, int signo) __sigdelset (&ss->pending, signo); return ss->pending_data[signo]; } -libc_hidden_def (_hurd_sigstate_lock) -libc_hidden_def (_hurd_sigstate_unlock) /* Retrieve a thread's action vector. SS must be locked. */ struct sigaction * @@ -242,7 +244,6 @@ _hurd_sigstate_actions (struct hurd_sigstate *ss) else return ss->actions; } -libc_hidden_def (_hurd_sigstate_pending) /* Signal delivery itself is on this page. */