diff mbox series

[v4,06/15] sysdeps/pthread/eintr.c: fix warn unused result

Message ID 20230428122142.928135-7-fberat@redhat.com
State Committed
Commit 7aec73c40691b7dfa48d22941ff72238aebe82eb
Delegated to: Siddhesh Poyarekar
Headers
Series Fix warn unused result |

Commit Message

Frederic Berat April 28, 2023, 12:21 p.m. UTC 
  Fix unused result warnings, detected when _FORTIFY_SOURCE is enabled in
glibc.
---
 sysdeps/pthread/eintr.c | 6 ++++--
 1 file changed, 4 insertions(+), 2 deletions(-)

Comments

Siddhesh Poyarekar May 25, 2023, 12:59 a.m. UTC | #1 
On 2023-04-28 08:21, Frédéric Bérat wrote:
> Fix unused result warnings, detected when _FORTIFY_SOURCE is enabled in
> glibc.
> ---
>   sysdeps/pthread/eintr.c | 6 ++++--
>   1 file changed, 4 insertions(+), 2 deletions(-)

LGTM.

Reviewed-by: Siddhesh Poyarekar <siddhesh@sourceware.org>

> 
> diff --git a/sysdeps/pthread/eintr.c b/sysdeps/pthread/eintr.c
> index 000649d24e..16191395a7 100644
> --- a/sysdeps/pthread/eintr.c
> +++ b/sysdeps/pthread/eintr.c
> @@ -31,10 +31,12 @@ eintr_handler (int sig)
>   {
>     if (sig != the_sig)
>       {
> -      write (STDOUT_FILENO, "eintr_handler: signal number wrong\n", 35);
> +      /* empty if statement avoids warn unused result */
> +      if (write (STDOUT_FILENO,
> +		 "eintr_handler: signal number wrong\n", 35) < 35) {};
>         _exit (1);
>       }
> -  write (STDOUT_FILENO, ".", 1);
> +  if (write (STDOUT_FILENO, ".", 1)) {/* Avoid warn unused result */};
>   }
>   
>
diff mbox series

Patch

diff --git a/sysdeps/pthread/eintr.c b/sysdeps/pthread/eintr.c
index 000649d24e..16191395a7 100644
--- a/sysdeps/pthread/eintr.c
+++ b/sysdeps/pthread/eintr.c
@@ -31,10 +31,12 @@  eintr_handler (int sig)
 {
   if (sig != the_sig)
     {
-      write (STDOUT_FILENO, "eintr_handler: signal number wrong\n", 35);
+      /* empty if statement avoids warn unused result */
+      if (write (STDOUT_FILENO,
+		 "eintr_handler: signal number wrong\n", 35) < 35) {};
       _exit (1);
     }
-  write (STDOUT_FILENO, ".", 1);
+  if (write (STDOUT_FILENO, ".", 1)) {/* Avoid warn unused result */};
 }