[v6,2/3] aarch64: Set the syscall register right before doing the syscall.
Checks
| Context |
Check |
Description |
| dj/TryBot-apply_patch |
success
|
Patch applied to master at the time it was sent
|
Commit Message
To make identifying syscalls easier during call tree analysis load the
syscall number just before performing the syscall.
Compiler optimizations can place quite a few instructions between the
setting of the syscall number and the syscall instruction. During call
tree analysis the number of instructions between the two can lead to
more difficulty for both tools and humans in properly identifying the
syscall number. Having the syscall number set in the prior instruction
to the syscall instruction makes this task easier and less error prone.
Being able to reliably identify syscalls made by a given API will make
it easier to understand and verify the safety and security of glibc.
---
sysdeps/unix/sysv/linux/aarch64/sysdep.h | 29 ++++++++++++++++--------
1 file changed, 20 insertions(+), 9 deletions(-)
Comments
The 04/24/2023 11:03, Joe Simmons-Talbott via Libc-alpha wrote:
> To make identifying syscalls easier during call tree analysis load the
> syscall number just before performing the syscall.
>
> Compiler optimizations can place quite a few instructions between the
> setting of the syscall number and the syscall instruction. During call
> tree analysis the number of instructions between the two can lead to
> more difficulty for both tools and humans in properly identifying the
> syscall number. Having the syscall number set in the prior instruction
> to the syscall instruction makes this task easier and less error prone.
> Being able to reliably identify syscalls made by a given API will make
> it easier to understand and verify the safety and security of glibc.
This is OK to commit.
Reviewed-by: Szabolcs Nagy <szabolcs.nagy@arm.com>
> ---
> sysdeps/unix/sysv/linux/aarch64/sysdep.h | 29 ++++++++++++++++--------
> 1 file changed, 20 insertions(+), 9 deletions(-)
>
> diff --git a/sysdeps/unix/sysv/linux/aarch64/sysdep.h b/sysdeps/unix/sysv/linux/aarch64/sysdep.h
> index e94d1703ad..6fe40aaf89 100644
> --- a/sysdeps/unix/sysv/linux/aarch64/sysdep.h
> +++ b/sysdeps/unix/sysv/linux/aarch64/sysdep.h
> @@ -168,15 +168,26 @@
> # define HAVE_CLONE3_WRAPPER 1
>
> # undef INTERNAL_SYSCALL_RAW
> -# define INTERNAL_SYSCALL_RAW(name, nr, args...) \
> - ({ long _sys_result; \
> - { \
> - LOAD_ARGS_##nr (args) \
> - register long _x8 asm ("x8") = (name); \
> - asm volatile ("svc 0 // syscall " # name \
> - : "=r" (_x0) : "r"(_x8) ASM_ARGS_##nr : "memory"); \
> - _sys_result = _x0; \
> - } \
> +# define INTERNAL_SYSCALL_RAW(name, nr, args...) \
> + ({ long _sys_result; \
> + { \
> + LOAD_ARGS_##nr (args) \
> + if (__builtin_constant_p(name)) \
> + asm volatile ("mov x8, %1 // syscall " # name "\n" \
> + "svc 0" \
> + : "=r" (_x0) \
> + : "i" (name) ASM_ARGS_##nr \
> + : "x8", "memory"); \
> + else \
> + { \
> + register long _x8 asm ("x8") = (name); \
> + asm volatile ("svc 0" \
> + : "=r" (_x0) \
> + : "r"(_x8) ASM_ARGS_##nr \
> + : "memory"); \
> + } \
> + _sys_result = _x0; \
> + } \
> _sys_result; })
>
> # undef INTERNAL_SYSCALL
> --
> 2.39.2
>
@@ -168,15 +168,26 @@
# define HAVE_CLONE3_WRAPPER 1
# undef INTERNAL_SYSCALL_RAW
-# define INTERNAL_SYSCALL_RAW(name, nr, args...) \
- ({ long _sys_result; \
- { \
- LOAD_ARGS_##nr (args) \
- register long _x8 asm ("x8") = (name); \
- asm volatile ("svc 0 // syscall " # name \
- : "=r" (_x0) : "r"(_x8) ASM_ARGS_##nr : "memory"); \
- _sys_result = _x0; \
- } \
+# define INTERNAL_SYSCALL_RAW(name, nr, args...) \
+ ({ long _sys_result; \
+ { \
+ LOAD_ARGS_##nr (args) \
+ if (__builtin_constant_p(name)) \
+ asm volatile ("mov x8, %1 // syscall " # name "\n" \
+ "svc 0" \
+ : "=r" (_x0) \
+ : "i" (name) ASM_ARGS_##nr \
+ : "x8", "memory"); \
+ else \
+ { \
+ register long _x8 asm ("x8") = (name); \
+ asm volatile ("svc 0" \
+ : "=r" (_x0) \
+ : "r"(_x8) ASM_ARGS_##nr \
+ : "memory"); \
+ } \
+ _sys_result = _x0; \
+ } \
_sys_result; })
# undef INTERNAL_SYSCALL