[01/19] <bits/platform/x86.h>: Rename to x86_cpu_INDEX_7_ECX_15

Message ID 20230405162144.984598-2-hjl.tools@gmail.com
State Committed
Commit 2d8c590a5e9bfe1344b638c897c7d731365cfaca
Headers
Series <sys/platform/x86.h>: Update CPUID features |

Checks

Context Check Description
dj/TryBot-apply_patch success Patch applied to master at the time it was sent

Commit Message

H.J. Lu April 5, 2023, 4:21 p.m. UTC
  Rename x86_cpu_INDEX_7_ECX_1 to x86_cpu_INDEX_7_ECX_15 for the unused bit
15 in ECX from CPUID with EAX == 0x7 and ECX == 0.
---
 sysdeps/x86/bits/platform/x86.h | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
  

Comments

Noah Goldstein April 5, 2023, 9:02 p.m. UTC | #1
On Wed, Apr 5, 2023 at 11:23 AM H.J. Lu via Libc-alpha
<libc-alpha@sourceware.org> wrote:
>
> Rename x86_cpu_INDEX_7_ECX_1 to x86_cpu_INDEX_7_ECX_15 for the unused bit
> 15 in ECX from CPUID with EAX == 0x7 and ECX == 0.
> ---
>  sysdeps/x86/bits/platform/x86.h | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/sysdeps/x86/bits/platform/x86.h b/sysdeps/x86/bits/platform/x86.h
> index 25a970b185..1ed24d7024 100644
> --- a/sysdeps/x86/bits/platform/x86.h
> +++ b/sysdeps/x86/bits/platform/x86.h
> @@ -181,7 +181,7 @@ enum
>    x86_cpu_AVX512_BITALG                = x86_cpu_index_7_ecx + 12,
>    x86_cpu_INDEX_7_ECX_13       = x86_cpu_index_7_ecx + 13,
>    x86_cpu_AVX512_VPOPCNTDQ     = x86_cpu_index_7_ecx + 14,
> -  x86_cpu_INDEX_7_ECX_1                = x86_cpu_index_7_ecx + 15,
> +  x86_cpu_INDEX_7_ECX_15       = x86_cpu_index_7_ecx + 15,
>    x86_cpu_INDEX_7_ECX_16       = x86_cpu_index_7_ecx + 16,
>  /* Note: Bits 17-21: The value of MAWAU used by the BNDLDX and BNDSTX
>     instructions in 64-bit mode.  */
> --
> 2.39.2
>
LGTM
Reviewed-by: Noah Goldstein <goldstein.w.n@gmail.com>
  

Patch

diff --git a/sysdeps/x86/bits/platform/x86.h b/sysdeps/x86/bits/platform/x86.h
index 25a970b185..1ed24d7024 100644
--- a/sysdeps/x86/bits/platform/x86.h
+++ b/sysdeps/x86/bits/platform/x86.h
@@ -181,7 +181,7 @@  enum
   x86_cpu_AVX512_BITALG		= x86_cpu_index_7_ecx + 12,
   x86_cpu_INDEX_7_ECX_13	= x86_cpu_index_7_ecx + 13,
   x86_cpu_AVX512_VPOPCNTDQ	= x86_cpu_index_7_ecx + 14,
-  x86_cpu_INDEX_7_ECX_1		= x86_cpu_index_7_ecx + 15,
+  x86_cpu_INDEX_7_ECX_15	= x86_cpu_index_7_ecx + 15,
   x86_cpu_INDEX_7_ECX_16	= x86_cpu_index_7_ecx + 16,
 /* Note: Bits 17-21: The value of MAWAU used by the BNDLDX and BNDSTX
    instructions in 64-bit mode.  */