From patchwork Wed Apr 5 12:06:44 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Adhemerval Zanella X-Patchwork-Id: 67302 Return-Path: X-Original-To: patchwork@sourceware.org Delivered-To: patchwork@sourceware.org Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id BAA10385735C for ; Wed, 5 Apr 2023 12:07:11 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org BAA10385735C DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=sourceware.org; s=default; t=1680696431; bh=i95EiY8722ffoayff1HvYhxIqnEnY5AXqhSRmmAyA8M=; h=To:Subject:Date:List-Id:List-Unsubscribe:List-Archive:List-Post: List-Help:List-Subscribe:From:Reply-To:From; b=TOSVq9G2Yg4u2wv231QnlroIRlVmDdFtrUeIoUWpTz6IcFctxOiNAdy1DmKVcqFwm 8arDRLUBG0SBiesxXxFEEGEpno07wBnNBZviAwgAhWiRsos0cj0LRZXt8vhnS3v042 BHDfYL+EI6BYaR+DNgs7B0p3Ulmz1FBv6C3e4yRE= X-Original-To: libc-alpha@sourceware.org Delivered-To: libc-alpha@sourceware.org Received: from mail-ot1-x32f.google.com (mail-ot1-x32f.google.com [IPv6:2607:f8b0:4864:20::32f]) by sourceware.org (Postfix) with ESMTPS id 4BBC53858D38 for ; Wed, 5 Apr 2023 12:06:50 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 4BBC53858D38 Received: by mail-ot1-x32f.google.com with SMTP id x8-20020a9d3788000000b0069f922cd5ceso18904613otb.12 for ; Wed, 05 Apr 2023 05:06:50 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; t=1680696409; h=content-transfer-encoding:mime-version:message-id:date:subject:to :from:x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=i95EiY8722ffoayff1HvYhxIqnEnY5AXqhSRmmAyA8M=; b=SFuYTy3eByfTm5lRaKERLY/KtypO6qY7mD7Bb2WavbUUS+uuglqz7pwz0revgCFwJJ Eyp0Z3tAP6dqsrOrPBR8DbbZ4mq+LoRRxTHAp8/yZBUtygmVWaU9nYNgriZJE24ckQEY Rnxg+y2pCLXLkSGs0DtUXXue3BUHF//BwfRQ8LVgR1yVbFVCCxDgEl5aXME167HeF8k9 qJpfCz+eEvvgnBTXU25kdF/jSMaAgG+FAqbOSxFJTTKim6xesJKnSECeOClgL5EHrwTa PdnOkRb65/O7XsT+/P/WXBN3IPZqs3ZpOBtT231zqdfSymqFdiA0cV8tG7DcP+f5139i eKbA== X-Gm-Message-State: AAQBX9d+V6xCKlGlozCN5HqAHDonAguQeh1QG6ePo5X6SximQagUDrvS QeTKwQCUlYa3HG/Et0kZbjw99QRYl4E292oC/gla+g== X-Google-Smtp-Source: AKy350YHTILhqUvQDPAizmFe6s5KsJoB2hFRicuGbVNv9M8BRsThEfppwChr0EyMSahWoTWmZMT+TA== X-Received: by 2002:a9d:7515:0:b0:6a1:33a0:3af8 with SMTP id r21-20020a9d7515000000b006a133a03af8mr2558849otk.38.1680696408826; Wed, 05 Apr 2023 05:06:48 -0700 (PDT) Received: from mandiga.. ([2804:1b3:a7c1:e5a5:3bc8:91d9:542c:3c10]) by smtp.gmail.com with ESMTPSA id d16-20020a056830139000b006a1394ea9f3sm6650876otq.30.2023.04.05.05.06.47 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 05 Apr 2023 05:06:48 -0700 (PDT) To: libc-alpha@sourceware.org Subject: [COMMITTED] malloc: Only set pragma weak for rpc freemem if required Date: Wed, 5 Apr 2023 09:06:44 -0300 Message-Id: <20230405120644.541570-1-adhemerval.zanella@linaro.org> X-Mailer: git-send-email 2.34.1 MIME-Version: 1.0 X-Spam-Status: No, score=-12.8 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, GIT_PATCH_0, RCVD_IN_DNSWL_NONE, SPF_HELO_NONE, SPF_PASS, TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org X-BeenThere: libc-alpha@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Libc-alpha mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-Patchwork-Original-From: Adhemerval Zanella via Libc-alpha From: Adhemerval Zanella Reply-To: Adhemerval Zanella Errors-To: libc-alpha-bounces+patchwork=sourceware.org@sourceware.org Sender: "Libc-alpha" Both __rpc_freemem and __rpc_thread_destroy are only used if the the compat symbols are required. --- malloc/set-freeres.c | 6 ++++-- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/malloc/set-freeres.c b/malloc/set-freeres.c index 42d70d3971..1aab34b586 100644 --- a/malloc/set-freeres.c +++ b/malloc/set-freeres.c @@ -51,8 +51,10 @@ # pragma weak __libc_printf_freemem # pragma weak __libc_fmtmsg_freemem # pragma weak __libc_setenv_freemem -# pragma weak __rpc_freemem -# pragma weak __rpc_thread_destroy +# if SHLIB_COMPAT (libc, GLIBC_2_0, GLIBC_2_31) +# pragma weak __rpc_freemem +# pragma weak __rpc_thread_destroy +# endif # pragma weak __libc_getaddrinfo_freemem # pragma weak __libc_tzset_freemem # pragma weak __libc_localealias_freemem