From patchwork Mon Mar 20 16:20:48 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Cupertino Miranda X-Patchwork-Id: 66651 Return-Path: X-Original-To: patchwork@sourceware.org Delivered-To: patchwork@sourceware.org Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id A41BE3850438 for ; Mon, 20 Mar 2023 16:21:38 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org A41BE3850438 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=sourceware.org; s=default; t=1679329298; bh=SfF2Si+F7k0IS1b1x0to8E+sGLcdOyD5IxEL0D8HS9Q=; h=To:Cc:Subject:Date:In-Reply-To:References:List-Id: List-Unsubscribe:List-Archive:List-Post:List-Help:List-Subscribe: From:Reply-To:From; b=AoXz4sLEAOXsFttdSMxlym9+r8OQ8GfmJFNzUEAxOupgy1i0DS8iUVrN8LkI8oza8 0ySBwpZbCqlpkJBIbQ1GeddOo24mQjPzO6WNDsSqgPhpSjJcU2BlffJOaNi1XECXwC d7x4JWzDcUbkkUv/5n35cY/721ZjadWlSUdbVP3w= X-Original-To: libc-alpha@sourceware.org Delivered-To: libc-alpha@sourceware.org Received: from mx0a-00069f02.pphosted.com (mx0a-00069f02.pphosted.com [205.220.165.32]) by sourceware.org (Postfix) with ESMTPS id 63C8C385DC3C for ; Mon, 20 Mar 2023 16:21:15 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 63C8C385DC3C Received: from pps.filterd (m0246617.ppops.net [127.0.0.1]) by mx0b-00069f02.pphosted.com (8.17.1.19/8.17.1.19) with ESMTP id 32KFwvDF018140 for ; Mon, 20 Mar 2023 16:21:13 GMT Received: from iadpaimrmta02.imrmtpd1.prodappiadaev1.oraclevcn.com (iadpaimrmta02.appoci.oracle.com [147.154.18.20]) by mx0b-00069f02.pphosted.com (PPS) with ESMTPS id 3pd5uubsxb-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK) for ; Mon, 20 Mar 2023 16:21:13 +0000 Received: from pps.filterd (iadpaimrmta02.imrmtpd1.prodappiadaev1.oraclevcn.com [127.0.0.1]) by iadpaimrmta02.imrmtpd1.prodappiadaev1.oraclevcn.com (8.17.1.5/8.17.1.5) with ESMTP id 32KFVEOT010394 for ; Mon, 20 Mar 2023 16:21:11 GMT Received: from nam12-dm6-obe.outbound.protection.outlook.com (mail-dm6nam12lp2171.outbound.protection.outlook.com [104.47.59.171]) by iadpaimrmta02.imrmtpd1.prodappiadaev1.oraclevcn.com (PPS) with ESMTPS id 3peqjmj5wm-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK) for ; Mon, 20 Mar 2023 16:21:11 +0000 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=lu/iB+cPedzhDWvbshnuCa3rEdG1LsC54ipVxXz0wlSu1fAK8MRI+1pKIYB+D+o+hJYSTpfySQq6QL1U+hyA/bpiWh0EKDxsNe8ZB0yGqt8VjPt1VQa0WCKTQ+pEYBP7PLxcZ1GbxnvXruWZv4Q6xzrnBC81F1HCYh9M97SVv7rI1rZZVraPAx1d9hU6lvswXBZ+9aglA8K+cXUU46kZK2om1gvcfshz2K75kPiSVbtVJIN4uPjkckxA62PGz5lK1JtfFG805NtvJYJOH6vapQFofr1IWZixp7CP27IFOOhGbTa4JHFD5abB85y3mcR/qgrj/03Vt5NHI60EwtoQ4w== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=SfF2Si+F7k0IS1b1x0to8E+sGLcdOyD5IxEL0D8HS9Q=; b=Q2WR7d5Hn4JlCPs0eGe+cv9a6hH4N/9Apef/nGhB2J4W9oEYB4tnJIbpFs8Tk1VIcAwaEvwP2OE5mS4NEHJPKh2389m62KwDX1MFL2NW6RAO6Dq+MGMZiVLl27ikCWaheSG2kUnmJnUpgR4eURJed0wR/ljk4Oh4X6UH2oxw8ZHg+rVCWF675z1SUODPN/EZ5kPaFq2UB7V0bJl+iA5QdnQXdUzEcFkjSFOQ8G1HaLkY7LkEZh9X3/EqJpqBiY41c9I0/tOr9F3qjTC9yYoH84I4N6/qaSIrfDwaxWME9iJcFSkaeL53OjpHzOWyT+gsYRH/3IzZXj+B0jWr/v1vPw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=oracle.com; dmarc=pass action=none header.from=oracle.com; dkim=pass header.d=oracle.com; arc=none Received: from BN6PR1001MB2340.namprd10.prod.outlook.com (2603:10b6:405:30::36) by CH0PR10MB5305.namprd10.prod.outlook.com (2603:10b6:610:d9::20) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6178.37; Mon, 20 Mar 2023 16:21:09 +0000 Received: from BN6PR1001MB2340.namprd10.prod.outlook.com ([fe80::a502:c948:c3f6:9728]) by BN6PR1001MB2340.namprd10.prod.outlook.com ([fe80::a502:c948:c3f6:9728%6]) with mapi id 15.20.6178.036; Mon, 20 Mar 2023 16:21:05 +0000 To: libc-alpha@sourceware.org Cc: jose.marchesi@oracle.com, elena.zannoni@oracle.com, Cupertino Miranda Subject: [PATCH v2 1/1] Created tunable to force small pages on stack allocation. Date: Mon, 20 Mar 2023 16:20:48 +0000 Message-Id: <20230320162048.550179-2-cupertino.miranda@oracle.com> X-Mailer: git-send-email 2.30.2 In-Reply-To: <20230320162048.550179-1-cupertino.miranda@oracle.com> References: <20230320162048.550179-1-cupertino.miranda@oracle.com> X-ClientProxiedBy: LO4P123CA0073.GBRP123.PROD.OUTLOOK.COM (2603:10a6:600:190::6) To BN6PR1001MB2340.namprd10.prod.outlook.com (2603:10b6:405:30::36) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: BN6PR1001MB2340:EE_|CH0PR10MB5305:EE_ X-MS-Office365-Filtering-Correlation-Id: b726c27e-b166-40c6-e06f-08db295f1ad7 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: 32Aw2EbNTEAgTUMh9GA0AmmcoXbsSJl27N5mCixyt2zasAKvdYu0o9nTMV92cfBT+yCG84lJyx9Oi2Ymeq4DObVJL4S22Y39WAwMltqLybU17Kh5VXsokc2coli2xd3lTiicNQUsxL9YvZW6WRXoUL1Uk+PUsSP43jZsNHN+n7uDUIG2mtmSc+htDnifRBIYrUVXZ/ixXll4Y4AcYCafJTGIOui+Dx6dnLKybbD/sn51PIPfMtvWidHuRltZOdixeGtEb+rvoubHhy1uopoWMieFKL3T32wmHCtKM9e5tU/77cgiQ1j1Z5RLRLRhBO/IkZDmnk2cZq/jQceInjSLJbSGpd5i1vniKagFiOVRo1If39xq4yIsLfnS8sGf7uakAP0iT8GC/dnmctly9tSghtJ7TNbIyeWFfNojRdo20yLjfeMtduFi2vqBgG03SZqW8fot3/GlmmcTFcB2tOQV9V4vNHA/ZgPGDpQH/3Qq16VFIDgj2I4QgzbW9PYQm3t6NXP+nc3gw0pYTihg53G/4ECkXeybKvA7iYeIsnVV4yqsZZrgkVpfn9j1jOoBdnClI4J6+yKIYnDaazf51Og8riDV7Q6yaM1aUkBxAHjQ7v/grfxSAO//aZT2HTfVaTW0BtCC6DqLXazjU9Dnh2kYyA== X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:BN6PR1001MB2340.namprd10.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230025)(136003)(39860400002)(366004)(396003)(376002)(346002)(451199018)(2616005)(107886003)(6486002)(4326008)(6666004)(478600001)(316002)(66476007)(66946007)(66556008)(6916009)(8676002)(1076003)(186003)(6512007)(6506007)(8936002)(44832011)(41300700001)(5660300002)(38100700002)(36756003)(2906002)(86362001); DIR:OUT; SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: tSU7TJ5xDzaseyTIoXbc9j86/1aDslCGpMb1Z1hxrapySqDioP8BZvhEbGg9foF9FNq25vc63KaqenctumJLGoxZG8V7gTJjyxdtEmOoBRdm7BTeaNzdbu6IXBpzByAMM4AtGrKhrxoaftLezfEm2jOZsfV1KCgsyRlWkuO3U9yz0yD33emUy/4k+x6ZGasVUb9bOa0uOQ6eP2I8XW+gtK7LvAAMXxkZ9++8zoZLty5wVvKsjF/I/Run8Cb7d+5Yde7Mtp0D78WhB20U+M0kTBFQ9LSvwzzUWS/8FoXC8fCuy06tK2WjmXbSUO15V/PZPFAJAu/JENQCbPBkGvDXpArKcNyC1d2U2JVQq2YdzZi3OkY9WQ+LdrFra47CNSpzP5XaHyi5FaALbJnBbsL+exExcdUfp1/gVhPHNUqxFJ8q91gBqfAjkUNjlxu7n4WG6LqQ3xPx5jPak1MSOMbf/RaIxXc10leW4OFyg+o+/soi4pTH8MDdKnTiMfS3XbWY/3zJHuQpR/BX+KZzaeV8WAwJBi4bpc1os1aOZQE2FV5E4FNqH0YnM3NBiLxH8hEVnZJJ7V0ybhAuzQ0DmLuybV2JWAZUToUIPO1XJTMEcLtWlm0wP9hZ48uhLIqYzqHApF6xRIBCe8rhfSP+IelQr5Z2Ox4xtPArzrmsaHlCc9rq3uZoTP1Zq4NVqGh5MI4BHeT4n2nm74c9Cw+rQ6OtjC8tsavltQl4aJmnd2aiZG7zwj8jHk2IvtmIYjESPX7tsPDUjN0NxJZ/maFvNwzg2f6ydLHs1oUxIFlzgQ2gtPYMArfRbnc8Yn3BYK3WF34JcxVwEiQ5sNLZgDDc+7diTmD3rZwhVZP1AYXh33fTcEjy2VtBQ7GZr8+RGMoRpYPKHzJE+F2uuVOBBbAxLtuvLrRuCVzc1Fy1TN2xnsrfDIHn3oWq0JB9wIPB2HvKk8Md2ZYrzG4VV37kq2s48R4k61LnlXqG6kjq+MrxH9VA2Nk+0LkbBGEH5fumKMit0gbnbEXgvegDLvJM7mPJCARrsDGSODGXbheam8HiUDdAvF2ttkErgi5v01E1KSqAFE0FaKvHxrMA8maJOYWJkxJL8O2vedyGper5IgU80zAn+Ux7j+9l2X93YEhMfdP+ZTF5Z6Saq08+o5liQuOM4jV0/q+hgt4wkzuGOdbYgTtneVgV0FmSQ3Taokww509jga4JbtFJRxxHdC+nlQIrfwIAHDvwwd9pL3+2BvqhGzL7muegA0vq9QrNwiBRlGtfao9v8H+zp8pazTvee7/yrOdmp3iGzSGiblKcLJvweBUWukAlKyTytcx5/v7dEw6w2HVh/m3O7iCHHIVGTWzg62DoDrAAZBIKoeea4aOAz7OU3b0uiA53EbExl+n/IyutpphVPQTcWd+lAwnNQOmsP63B0jqCKEndTgKEwLOlhXn5280bMQR7kbsXyyY2EPKN3FuhBEbSXRIRQxas8Ad7d2KDgCjG6ik1wpFod6vxF1byozcIT0dTh31Vfds8uA06pzlKyJD7q43vUO2zuGhejfRWYtFvKiT9KfsBc4sV6fkklbIOM79a0HjCWqQFZ3DO0iF9QrOT4hwATQgQDBNWKlsTMINyEBeQrolKkyz3dsiYLRzfm4K2W0smSic6yavMdxtc X-MS-Exchange-AntiSpam-ExternalHop-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-ExternalHop-MessageData-0: 7yCgCDS1HdceXxGjuh+aQ2bss00fH5L7iBBBrtzQ+Ksq+ezlE5dnnstxvIeKPIrwuRiOCEDWJKCKAB3HcayolRFt1m2zUvR5jXl7VMm7u4eUPt/xhN0kGiq9M6rSydmURGC7IUaPjDDbzeehP+qzs5j1rLX84SciMfJmH8Ag8e0DopOnj2zIaHpx3s1EZFuV1duVwJvXslhVYUJ6IWKLlC1clCMCQK7Yncil9v3Qiv7hc0vuagA+uIzUGgwFk6CIsYuL68RBvy+pesRo0H7MgQgGMRdU/ZrhSQQMowCjMhzyxxRONqCoLrcHEaMvykI6TfzI4ihqQchIOWEZj+RWJ6YPc/CXsAJ8jC3Kl418Spk+hTtxbXsuE2EnssQizpR770b3wqdZFKM/HeZAAYClQv53vGKGnAsyfBDDDPxb62nFp7wBSmu/uZsdBLZhT1M+bNQ7O/Q8cBV82eT6ReegPlTeZPp0ZkUA6v4bKqsPh15ihr+Z7DZH6R46jHo0HQIt+DE9BLQQYb3OFxxk1G0ul6+OykGyWt1SmKWclGHKHtmaZFz9B+kigL31q3GUGtkFWo+w+79nBofcfQdsV37hZBV75Zb5ARnPhk9w9W5FdRE3HPxruAoGJ36a6FqzVorh/fVxPj3IvB1IpbH4JQGzeW7j0U55v+RxGs87EKNVkXKxI2YqBzzNn+4sjFA2CSY10CWmHxeicTmuAv5CcQhbGXduXmINAqyM0F2es+KVMzFlRVz6rWfUJu3bjXNxzq1n X-OriginatorOrg: oracle.com X-MS-Exchange-CrossTenant-Network-Message-Id: b726c27e-b166-40c6-e06f-08db295f1ad7 X-MS-Exchange-CrossTenant-AuthSource: BN6PR1001MB2340.namprd10.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 20 Mar 2023 16:21:05.4544 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 4e2c6054-71cb-48f1-bd6c-3a9705aca71b X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: g6LYR8LvMy+PQ0O+SCmnMMUHtE+AHfgyL7NEO5V4guIR8WNy2aqvl47rAcsF0vqSuR+wrBAHRrNAk8q3vVq+btpDCAKW49ewMZpOwVpfa4s= X-MS-Exchange-Transport-CrossTenantHeadersStamped: CH0PR10MB5305 X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.254,Aquarius:18.0.942,Hydra:6.0.573,FMLib:17.11.170.22 definitions=2023-03-20_13,2023-03-20_02,2023-02-09_01 X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 adultscore=0 mlxlogscore=999 phishscore=0 suspectscore=0 malwarescore=0 mlxscore=0 spamscore=0 bulkscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2303150002 definitions=main-2303200139 X-Proofpoint-GUID: hzGAd8CQhwo34m59kQWfMt-8CB_SoATw X-Proofpoint-ORIG-GUID: hzGAd8CQhwo34m59kQWfMt-8CB_SoATw X-Spam-Status: No, score=-11.8 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, GIT_PATCH_0, RCVD_IN_DNSWL_LOW, RCVD_IN_MSPIKE_H2, SPF_HELO_NONE, SPF_NONE, TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org X-BeenThere: libc-alpha@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Libc-alpha mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-Patchwork-Original-From: Cupertino Miranda via Libc-alpha From: Cupertino Miranda Reply-To: Cupertino Miranda Errors-To: libc-alpha-bounces+patchwork=sourceware.org@sourceware.org Sender: "Libc-alpha" Created tunable glibc.pthread.stack_hugetlb to control when hugepages can be used for stack allocation. In case THP are enabled and glibc.pthread.stack_hugetlb is set to 0, glibc will madvise the kernel not to use allow hugepages for stack allocations. Changed from v1: - removed the __malloc_thp_mode calls to check if hugetlb is enabled. --- nptl/allocatestack.c | 6 ++++++ nptl/nptl-stack.c | 1 + nptl/nptl-stack.h | 3 +++ nptl/pthread_mutex_conf.c | 8 ++++++++ sysdeps/nptl/dl-tunables.list | 6 ++++++ 5 files changed, 24 insertions(+) diff --git a/nptl/allocatestack.c b/nptl/allocatestack.c index c7adbccd6f..c792c6ed1f 100644 --- a/nptl/allocatestack.c +++ b/nptl/allocatestack.c @@ -369,6 +369,12 @@ allocate_stack (const struct pthread_attr *attr, struct pthread **pdp, if (__glibc_unlikely (mem == MAP_FAILED)) return errno; + /* Do madvise in case the tunable glibc.pthread.stack_hugetlb is + set to 0, disabling hugetlb. */ + if (__glibc_unlikely (__nptl_stack_hugetlb == 0) + && __madvise(mem, size, MADV_NOHUGEPAGE) != 0) + return errno; + /* SIZE is guaranteed to be greater than zero. So we can never get a null pointer back from mmap. */ assert (mem != NULL); diff --git a/nptl/nptl-stack.c b/nptl/nptl-stack.c index 5eb7773575..e829711cb5 100644 --- a/nptl/nptl-stack.c +++ b/nptl/nptl-stack.c @@ -21,6 +21,7 @@ #include size_t __nptl_stack_cache_maxsize = 40 * 1024 * 1024; +int32_t __nptl_stack_hugetlb = 1; void __nptl_stack_list_del (list_t *elem) diff --git a/nptl/nptl-stack.h b/nptl/nptl-stack.h index 34f8bbb15e..d5b2612b4a 100644 --- a/nptl/nptl-stack.h +++ b/nptl/nptl-stack.h @@ -27,6 +27,9 @@ /* Maximum size of the cache, in bytes. 40 MiB by default. */ extern size_t __nptl_stack_cache_maxsize attribute_hidden; +/* Should allow stacks to use hugetlb. 1 is default */ +extern int32_t __nptl_stack_hugetlb; + /* Check whether the stack is still used or not. */ static inline bool __nptl_stack_in_use (struct pthread *pd) diff --git a/nptl/pthread_mutex_conf.c b/nptl/pthread_mutex_conf.c index 329c4cbb8f..60ef9095aa 100644 --- a/nptl/pthread_mutex_conf.c +++ b/nptl/pthread_mutex_conf.c @@ -45,6 +45,12 @@ TUNABLE_CALLBACK (set_stack_cache_size) (tunable_val_t *valp) __nptl_stack_cache_maxsize = valp->numval; } +static void +TUNABLE_CALLBACK (set_stack_hugetlb) (tunable_val_t *valp) +{ + __nptl_stack_hugetlb = (int32_t) valp->numval; +} + void __pthread_tunables_init (void) { @@ -52,5 +58,7 @@ __pthread_tunables_init (void) TUNABLE_CALLBACK (set_mutex_spin_count)); TUNABLE_GET (stack_cache_size, size_t, TUNABLE_CALLBACK (set_stack_cache_size)); + TUNABLE_GET (stack_hugetlb, int32_t, + TUNABLE_CALLBACK (set_stack_hugetlb)); } #endif diff --git a/sysdeps/nptl/dl-tunables.list b/sysdeps/nptl/dl-tunables.list index bd1ddb121d..22fa9e0d12 100644 --- a/sysdeps/nptl/dl-tunables.list +++ b/sysdeps/nptl/dl-tunables.list @@ -33,5 +33,11 @@ glibc { maxval: 1 default: 1 } + stack_hugetlb { + type: INT_32 + minval: 0 + maxval: 1 + default: 0 + } } }